Bug 184456 - devel/mercurial stage warnings
Summary: devel/mercurial stage warnings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-02 21:40 UTC by Matthias Andree
Modified: 2013-12-03 12:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2013-12-02 21:40:00 UTC
Running stage-qa on Mercurial - which is other than that a nice port -
yields:

Error: /usr/bin/python is an invalid shebang you need USES=shebangfix for share/mercurial/contrib/tmplrewrite.py
Warning: /var/tmp/usr/ports/devel/mercurial/work/stage/usr/local/lib/python2.7/site-packages/mercurial/base85.so is not stripped consider using ${STRIP_CMD}
Warning: /var/tmp/usr/ports/devel/mercurial/work/stage/usr/local/lib/python2.7/site-packages/mercurial/bdiff.so is not stripped consider using ${STRIP_CMD}
Warning: /var/tmp/usr/ports/devel/mercurial/work/stage/usr/local/lib/python2.7/site-packages/mercurial/diffhelpers.so is not stripped consider using ${STRIP_CMD}
Warning: /var/tmp/usr/ports/devel/mercurial/work/stage/usr/local/lib/python2.7/site-packages/mercurial/mpatch.so is not stripped consider using ${STRIP_CMD}
Warning: /var/tmp/usr/ports/devel/mercurial/work/stage/usr/local/lib/python2.7/site-packages/mercurial/parsers.so is not stripped consider using ${STRIP_CMD}
Warning: /var/tmp/usr/ports/devel/mercurial/work/stage/usr/local/lib/python2.7/site-packages/mercurial/osutil.so is not stripped consider using ${STRIP_CMD}

Could someone look into this and fix these nits?
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-02 21:40:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-12-03 11:47:06 UTC
Responsible Changed
From-To: freebsd-python->sunpoet

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-12-03 12:16:10 UTC
Author: sunpoet
Date: Tue Dec  3 12:16:00 2013
New Revision: 335564
URL: http://svnweb.freebsd.org/changeset/ports/335564

Log:
  - Fix shebang
  - Strip shared library
  - Bump PORTREVISION for package change
  
  PR:		ports/184456
  Submitted by:	mandree

Modified:
  head/devel/mercurial/Makefile

Modified: head/devel/mercurial/Makefile
==============================================================================
--- head/devel/mercurial/Makefile	Tue Dec  3 12:15:56 2013	(r335563)
+++ head/devel/mercurial/Makefile	Tue Dec  3 12:16:00 2013	(r335564)
@@ -3,6 +3,7 @@
 
 PORTNAME=	mercurial
 PORTVERSION=	2.8.1
+PORTREVISION=	1
 CATEGORIES=	devel python
 MASTER_SITES=	http://mercurial.selenic.com/release/
 
@@ -13,6 +14,7 @@ LICENSE=	GPLv2
 
 USE_PYTHON=	-2.7
 USE_PYDISTUTILS=yes
+USES=		shebangfix
 
 OPTIONS_DEFINE=	CA_BUNDLE DATA DOCS NLS
 OPTIONS_DEFAULT=DATA
@@ -55,6 +57,8 @@ CONTRIB_FILES=	bash_completion \
 		vim/patchreview.vim
 DOCS=		CONTRIBUTORS README
 
+SHEBANG_FILES=	contrib/tmplrewrite.py
+
 CA_BUNDLE_RUN_DEPENDS=	${LOCALBASE}/share/certs/ca-root-nss.crt:${PORTSDIR}/security/ca_root_nss
 NLS_USES=		gettext
 
@@ -71,6 +75,7 @@ EXTRA_PATCHES+=	${FILESDIR}/extra-patch-
 post-install:
 	${INSTALL_MAN} ${WRKSRC}/doc/*.1 ${STAGEDIR}${PREFIX}/man/man1/
 	${INSTALL_MAN} ${WRKSRC}/doc/*.5 ${STAGEDIR}${PREFIX}/man/man5/
+	${STRIP_CMD} ${STAGEDIR}${PYTHON_SITELIBDIR}/${PORTNAME}/*.so
 .if ${PORT_OPTIONS:MDATA}
 	${MKDIR} ${STAGEDIR}${DATADIR}
 	${MKDIR} ${STAGEDIR}${DATADIR}/contrib
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-12-03 12:19:53 UTC
State Changed
From-To: open->closed

Committed. Thanks!