Bug 184460 - devel/liboop stage fix
Summary: devel/liboop stage fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-02 23:30 UTC by Rodrigo OSORIO
Modified: 2013-12-05 20:31 UTC (History)
0 users

See Also:


Attachments
liboop.diff (1.42 KB, patch)
2013-12-02 23:30 UTC, Rodrigo OSORIO
no flags Details | Diff
liboop1.diff (1.12 KB, patch)
2013-12-05 12:56 UTC, Rodrigo OSORIO
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rodrigo OSORIO 2013-12-02 23:30:01 UTC
	Fix stage
	Add license
	Strip binary
	Multiple fixes to make porlint happy
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-02 23:30:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

sunpoet@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-12-03 14:19:36 UTC
State Changed
From-To: open->feedback

My build does not generate lib/liboop-glib2.*. The patch does not seem 
to contain corresponding change to liboop-glib2.*. Would you please 
check it again? Thanks!
Comment 3 Rodrigo OSORIO 2013-12-05 12:56:37 UTC
> My build does not generate lib/liboop-glib2.*. The patch does not seem
> to contain corresponding change to liboop-glib2.*. Would you please
> check it again? Thanks!

I'd test the port in several conditions but in a clean tinderboxed env,
liboop-glib2.* files aren't generated at all. I think this is an autotool
trick I need to investigate ; afterward.
Attached to this mail, a new patch who complies with ports building requirements.

Regards,
 - rodrigo
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-12-05 20:26:11 UTC
Author: sunpoet
Date: Thu Dec  5 20:25:59 2013
New Revision: 335688
URL: http://svnweb.freebsd.org/changeset/ports/335688

Log:
  - Add LICENSE
  - Strip shared library
  - Support STAGEDIR
  - Pet Portlint
  - While I'm here:
    - Remove leading indefinite article from COMMENT
    - Simplify Makefile
    - Sort PLIST
  
  PR:		ports/184460
  Submitted by:	Rodrigo Osorio <rodrigo@bebik.net> (maintainer)

Modified:
  head/devel/liboop/Makefile   (contents, props changed)
  head/devel/liboop/pkg-plist   (contents, props changed)

Modified: head/devel/liboop/Makefile
==============================================================================
--- head/devel/liboop/Makefile	Thu Dec  5 20:25:54 2013	(r335687)
+++ head/devel/liboop/Makefile	Thu Dec  5 20:25:59 2013	(r335688)
@@ -9,24 +9,25 @@ MASTER_SITES=	GENTOO/distfiles \
 		http://download.ofb.net/liboop/
 
 MAINTAINER=	rodrigo@bebik.net
-COMMENT=	A low-level event loop management library for POSIX-based OS
+COMMENT=	Low-level event loop management library for POSIX-based OS
 
-LIB_DEPENDS=	adns.1:${PORTSDIR}/dns/adns \
-		wwwcore.1:${PORTSDIR}/www/libwww
+LICENSE=	GPLv2
+
+LIB_DEPENDS=	libadns.so:${PORTSDIR}/dns/adns \
+		libwwwcore.so:${PORTSDIR}/www/libwww
 
-USE_BZIP2=	yes
-USE_GNOME=	glib12 glib20 gnomehack
-USE_TCL_BUILD=	yes
-USE_TCL=	yes
-USE_AUTOTOOLS=	libtool
 CONFIGURE_ARGS=	--with-libwww
+MAKE_ENV=	INSTALL_STRIP_FLAG=${STRIP}
+MAKE_JOBS_UNSAFE=	yes
+USE_AUTOTOOLS=	libtool
+USE_BZIP2=	yes
+USE_GNOME=	glib12 glib20
 USE_LDCONFIG=	yes
-MAKE_JOBS_UNSAFE=yes
+USES=		pathfix tcl
 
 CPPFLAGS+=	-I${TCL_INCLUDEDIR} -I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 
-NO_STAGE=	yes
 post-patch:
 	@${REINPLACE_CMD} -e 's|8\.4|${TCL_VER:S/.//}|g' ${WRKSRC}/configure
 

Modified: head/devel/liboop/pkg-plist
==============================================================================
--- head/devel/liboop/pkg-plist	Thu Dec  5 20:25:54 2013	(r335687)
+++ head/devel/liboop/pkg-plist	Thu Dec  5 20:25:59 2013	(r335688)
@@ -1,10 +1,14 @@
+include/oop.h
 include/oop-adns.h
 include/oop-glib.h
 include/oop-read.h
 include/oop-rl.h
 include/oop-tcl.h
 include/oop-www.h
-include/oop.h
+lib/liboop.a
+lib/liboop.la
+lib/liboop.so
+lib/liboop.so.4
 lib/liboop-adns.a
 lib/liboop-adns.la
 lib/liboop-adns.so
@@ -25,9 +29,5 @@ lib/liboop-www.a
 lib/liboop-www.la
 lib/liboop-www.so
 lib/liboop-www.so.0
-lib/liboop.a
-lib/liboop.la
-lib/liboop.so
-lib/liboop.so.4
-libdata/pkgconfig/liboop-glib2.pc
 libdata/pkgconfig/liboop.pc
+libdata/pkgconfig/liboop-glib2.pc
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-12-05 20:31:32 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!