Bug 184616 - ftp/ftpproxy: [PATCH] unbreak on F10 and head
Summary: ftp/ftpproxy: [PATCH] unbreak on F10 and head
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-09 00:20 UTC by John Marino
Modified: 2013-12-26 13:10 UTC (History)
0 users

See Also:


Attachments
file.diff (905 bytes, patch)
2013-12-09 00:20 UTC, John Marino
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino 2013-12-09 00:20:01 UTC
This port does not build on FreeBSD 10 or head because the internal makefile hardcodes "make" when the port specifies gmake is needed.  As a result, bmake is used instead which fails on head.

Attached patch fixes build by using gmake as intended.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-09 00:20:08 UTC
Maintainer of ftp/ftpproxy,

Please note that PR ports/184616 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184616

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-09 00:20:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 John Marino freebsd_committer freebsd_triage 2013-12-09 01:19:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marino

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-12-24 21:28:52 UTC
Author: marino
Date: Tue Dec 24 21:28:45 2013
New Revision: 337387
URL: http://svnweb.freebsd.org/changeset/ports/337387

Log:
  ftp/ftpproxy: Unbreak on FreeBSD 10+
  
  The breakage was caused by processing makefiles with bmake instead of the
  specified gmake.
  
  PR:		ports/184616
  Approved by:	maintainer timeout

Added:
  head/ftp/ftpproxy/files/
  head/ftp/ftpproxy/files/patch-Makefile   (contents, props changed)

Added: head/ftp/ftpproxy/files/patch-Makefile
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/ftp/ftpproxy/files/patch-Makefile	Tue Dec 24 21:28:45 2013	(r337387)
@@ -0,0 +1,20 @@
+--- Makefile.orig	2004-07-30 12:49:27.000000000 +0000
++++ Makefile
+@@ -9,7 +9,7 @@ TARGETS =	ftp.proxy
+ 
+ 
+ all:	$(TARGETS)
+-	cd src; make all 
++	cd src; $(MAKE) all 
+ 
+ 
+ install:	all
+@@ -18,7 +18,7 @@ install:	all
+ 
+ 
+ ftp.proxy:
+-	cd src; make ftp.proxy 
++	cd src; $(MAKE) ftp.proxy 
+ 
+ 
+ tar:		clean
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 John Marino freebsd_committer freebsd_triage 2013-12-24 21:32:30 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-12-26 13:03:57 UTC
Author: mat
Date: Thu Dec 26 13:03:50 2013
New Revision: 337489
URL: http://svnweb.freebsd.org/changeset/ports/337489

Log:
  MFH: r337387
  
  ftp/ftpproxy: Unbreak on FreeBSD 10+
  
  The breakage was caused by processing makefiles with bmake instead of the
  specified gmake.
  
  PR:		ports/184616
  Approved by:	maintainer timeout
  Approved by:	portmgr (implicit)

Added:
  branches/2014Q1/ftp/ftpproxy/files/
     - copied from r337387, head/ftp/ftpproxy/files/
Modified:
Directory Properties:
  branches/2014Q1/   (props changed)
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"