- Fix build with clang New file: files/patch-xorgedit__guiframe.cpp
Responsible Changed From-To: freebsd-ports-bugs->pawel I'll take it.
State Changed From-To: open->closed Committed. Thanks!
Author: pawel Date: Thu Dec 19 19:16:55 2013 New Revision: 336948 URL: http://svnweb.freebsd.org/changeset/ports/336948 Log: - Fix build with clang - Support staging PR: ports/184828 Submitted by: KATO Tsuguru <tkato432@yahoo.com> Added: head/x11/xorg-edit/files/ head/x11/xorg-edit/files/patch-xorgedit__guiframe.cpp (contents, props changed) Modified: head/x11/xorg-edit/Makefile Modified: head/x11/xorg-edit/Makefile ============================================================================== --- head/x11/xorg-edit/Makefile Thu Dec 19 19:04:25 2013 (r336947) +++ head/x11/xorg-edit/Makefile Thu Dec 19 19:16:55 2013 (r336948) @@ -15,10 +15,10 @@ LICENSE= GPLv3 WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} USE_BZIP2= yes +USES= dos2unix gmake DOS2UNIX_GLOB= *.cpp *.h USE_WX= 2.6+ WX_UNICODE= yes -USES= dos2unix gmake PLIST_FILES= bin/xorg-edit \ lib/xorg-edit/de_DE/LC_MESSAGES/xorg-edit.mo \ @@ -34,7 +34,6 @@ PLIST_DIRS= lib/xorg-edit/options/device DESKTOP_ENTRIES="Xorg Edit" "" "" "${PORTNAME}" "Settings;" true -NO_STAGE= yes post-patch: @${REINPLACE_CMD} -e \ 's|^CXX =|CXX ?=| ; \ @@ -58,15 +57,15 @@ do-configure: @${ECHO_CMD} ' $$(MAKE) -C xorgedit' >> ${WRKSRC}/Makefile do-install: - (cd ${WRKDIR} && ${INSTALL_SCRIPT} xorg-edit ${PREFIX}/bin) - @${MKDIR} ${PREFIX}/lib/xorg-edit + (cd ${WRKDIR} && ${INSTALL_SCRIPT} xorg-edit ${STAGEDIR}${PREFIX}/bin) + @${MKDIR} ${STAGEDIR}${PREFIX}/lib/xorg-edit (cd ${WRKSRC} && ${INSTALL_PROGRAM} xorg-edit \ - ${PREFIX}/lib/xorg-edit) - @${MKDIR} ${PREFIX}/lib/xorg-edit/de_DE/LC_MESSAGES + ${STAGEDIR}${PREFIX}/lib/xorg-edit) + @${MKDIR} ${STAGEDIR}${PREFIX}/lib/xorg-edit/de_DE/LC_MESSAGES (cd ${WRKSRC}/de_DE/LC_MESSAGES && ${INSTALL_DATA} ${PORTNAME}.mo \ - ${PREFIX}/lib/xorg-edit/de_DE/LC_MESSAGES) - @${MKDIR} ${PREFIX}/lib/xorg-edit/options/devices + ${STAGEDIR}${PREFIX}/lib/xorg-edit/de_DE/LC_MESSAGES) + @${MKDIR} ${STAGEDIR}${PREFIX}/lib/xorg-edit/options/devices (cd ${WRKSRC}/options/devices && ${INSTALL_DATA} *.xml \ - ${PREFIX}/lib/xorg-edit/options/devices) + ${STAGEDIR}${PREFIX}/lib/xorg-edit/options/devices) .include <bsd.port.mk> Added: head/x11/xorg-edit/files/patch-xorgedit__guiframe.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/x11/xorg-edit/files/patch-xorgedit__guiframe.cpp Thu Dec 19 19:16:55 2013 (r336948) @@ -0,0 +1,54 @@ +--- xorgedit/guiframe.cpp.orig ++++ xorgedit/guiframe.cpp +@@ -182,8 +182,13 @@ + otherSectionTab = new wxPanel(layout); // iles/modules/extensions/dri tab panel + wxBoxSizer *otherSectionTabSizer=new wxBoxSizer(wxVERTICAL); + ++#ifdef __clang__ ++ wxString *tempList = new wxString[devListSize+1]; // initial list for combo und choice elements ++ wxString *optList = new wxString[optListSize]; // initial list for option combo und choice elements ++#else + wxString tempList[devListSize+1]; // initial list for combo und choice elements + wxString optList[optListSize]; // initial list for option combo und choice elements ++#endif + + optList[0]=_("----------"); + optList[1]=_("Add Option"); +@@ -821,6 +826,11 @@ + if (ShowError()) return; + } + SetSaved(true); ++ ++#ifdef __clang__ ++ delete[] optList; ++ delete[] tempList; ++#endif + } + + const bool GuiFrame::CreateBackup(void) const +@@ -1832,8 +1842,13 @@ + + warningText->SetLabel(_("Warning: Improper use of this tool can cause damage to your\nxorg.conf and may not start your Xserver.\nYou must restart X to take the changes effect.")); + ++#ifdef __clang__ ++ wxString *tempList = new wxString[devListSize+1]; // initial list for combo und choice elements ++ wxString *optList = new wxString[optListSize]; // initial list for option combo und choice elements ++#else + wxString tempList[devListSize+1]; // initial list for combo und choice elements + wxString optList[optListSize]; // initial list for option combo und choice elements ++#endif + unsigned int offset=0; + unsigned int i; + +@@ -2269,6 +2284,11 @@ + + driBox->SetLabel(_("DRI")); + return(false); ++ ++#ifdef __clang__ ++ delete[] optList; ++ delete[] tempList; ++#endif + } + + void GuiFrame::SetSaved(const bool save) _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Author: bapt Date: Fri Dec 20 08:01:45 2013 New Revision: 336981 URL: http://svnweb.freebsd.org/changeset/ports/336981 Log: MFH: r336948 - Fix build with clang - Support staging PR: ports/184828 Submitted by: KATO Tsuguru <tkato432@yahoo.com> Added: branches/2014Q1/x11/xorg-edit/files/ - copied from r336948, head/x11/xorg-edit/files/ Modified: branches/2014Q1/x11/xorg-edit/Makefile Directory Properties: branches/2014Q1/ (props changed) Modified: branches/2014Q1/x11/xorg-edit/Makefile ============================================================================== --- branches/2014Q1/x11/xorg-edit/Makefile Fri Dec 20 08:00:46 2013 (r336980) +++ branches/2014Q1/x11/xorg-edit/Makefile Fri Dec 20 08:01:45 2013 (r336981) @@ -15,10 +15,10 @@ LICENSE= GPLv3 WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} USE_BZIP2= yes +USES= dos2unix gmake DOS2UNIX_GLOB= *.cpp *.h USE_WX= 2.6+ WX_UNICODE= yes -USES= dos2unix gmake PLIST_FILES= bin/xorg-edit \ lib/xorg-edit/de_DE/LC_MESSAGES/xorg-edit.mo \ @@ -34,7 +34,6 @@ PLIST_DIRS= lib/xorg-edit/options/device DESKTOP_ENTRIES="Xorg Edit" "" "" "${PORTNAME}" "Settings;" true -NO_STAGE= yes post-patch: @${REINPLACE_CMD} -e \ 's|^CXX =|CXX ?=| ; \ @@ -58,15 +57,15 @@ do-configure: @${ECHO_CMD} ' $$(MAKE) -C xorgedit' >> ${WRKSRC}/Makefile do-install: - (cd ${WRKDIR} && ${INSTALL_SCRIPT} xorg-edit ${PREFIX}/bin) - @${MKDIR} ${PREFIX}/lib/xorg-edit + (cd ${WRKDIR} && ${INSTALL_SCRIPT} xorg-edit ${STAGEDIR}${PREFIX}/bin) + @${MKDIR} ${STAGEDIR}${PREFIX}/lib/xorg-edit (cd ${WRKSRC} && ${INSTALL_PROGRAM} xorg-edit \ - ${PREFIX}/lib/xorg-edit) - @${MKDIR} ${PREFIX}/lib/xorg-edit/de_DE/LC_MESSAGES + ${STAGEDIR}${PREFIX}/lib/xorg-edit) + @${MKDIR} ${STAGEDIR}${PREFIX}/lib/xorg-edit/de_DE/LC_MESSAGES (cd ${WRKSRC}/de_DE/LC_MESSAGES && ${INSTALL_DATA} ${PORTNAME}.mo \ - ${PREFIX}/lib/xorg-edit/de_DE/LC_MESSAGES) - @${MKDIR} ${PREFIX}/lib/xorg-edit/options/devices + ${STAGEDIR}${PREFIX}/lib/xorg-edit/de_DE/LC_MESSAGES) + @${MKDIR} ${STAGEDIR}${PREFIX}/lib/xorg-edit/options/devices (cd ${WRKSRC}/options/devices && ${INSTALL_DATA} *.xml \ - ${PREFIX}/lib/xorg-edit/options/devices) + ${STAGEDIR}${PREFIX}/lib/xorg-edit/options/devices) .include <bsd.port.mk> _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"