Bug 184832 - graphics/gimmage: Fix build with clang
Summary: graphics/gimmage: Fix build with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-16 18:10 UTC by tkato432
Modified: 2013-12-20 08:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.51 KB, patch)
2013-12-16 18:10 UTC, tkato432
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2013-12-16 18:10:08 UTC
- Fix build with clang
- Support desktop-file-utils
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2013-12-19 19:55:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-12-19 20:04:46 UTC
Author: pawel
Date: Thu Dec 19 20:04:37 2013
New Revision: 336955
URL: http://svnweb.freebsd.org/changeset/ports/336955

Log:
  - Fix build with clang
  - Support desktop-file-utils
  - Port supports staging
  
  PR:		ports/184832
  Submitted by:	KATO Tsuguru <tkato432@yahoo.com>

Modified:
  head/graphics/gimmage/Makefile
  head/graphics/gimmage/files/patch-src__FileManager.cpp   (contents, props changed)
  head/graphics/gimmage/pkg-descr   (contents, props changed)

Modified: head/graphics/gimmage/Makefile
==============================================================================
--- head/graphics/gimmage/Makefile	Thu Dec 19 20:02:37 2013	(r336954)
+++ head/graphics/gimmage/Makefile	Thu Dec 19 20:04:37 2013	(r336955)
@@ -3,19 +3,18 @@
 
 PORTNAME=	gimmage
 PORTVERSION=	0.2.3
-PORTREVISION=	9
+PORTREVISION=	10
 CATEGORIES=	graphics
 MASTER_SITES=	BERLIOS CENKES
 
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Simple image viewer
 
-LIB_DEPENDS=	libgtkmm-2.4.so:${PORTSDIR}/x11-toolkits/gtkmm24 \
-		libcurl.so:${PORTSDIR}/ftp/curl
+LIB_DEPENDS=	libcurl.so:${PORTSDIR}/ftp/curl
 
-USES=		gettext pkgconfig
+USES=		desktop-file-utils gettext pkgconfig
+USE_GNOME=	gtkmm24
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS+=	--with-libintl-prefix=${LOCALBASE}
+CONFIGURE_ARGS=	--with-libintl-prefix=${LOCALBASE}
 
-NO_STAGE=	yes
 .include <bsd.port.mk>

Modified: head/graphics/gimmage/files/patch-src__FileManager.cpp
==============================================================================
--- head/graphics/gimmage/files/patch-src__FileManager.cpp	Thu Dec 19 20:02:37 2013	(r336954)
+++ head/graphics/gimmage/files/patch-src__FileManager.cpp	Thu Dec 19 20:04:37 2013	(r336955)
@@ -1,6 +1,6 @@
 --- ./src/FileManager.cpp.orig	2007-07-20 23:42:55.000000000 +0400
 +++ ./src/FileManager.cpp	2007-07-20 23:43:03.000000000 +0400
-@@ -23,6 +23,7 @@
+@@ -23,12 +23,13 @@
  
  #include "FileManager.h"
  #include "defines.h"
@@ -8,3 +8,9 @@
  
  #include "../config.h"
  
+ extern "C" {
+ #include <libintl.h>
+-// #include <unistd.h>
++#include <unistd.h>
+ #include <sys/stat.h>
+ }

Modified: head/graphics/gimmage/pkg-descr
==============================================================================
--- head/graphics/gimmage/pkg-descr	Thu Dec 19 20:02:37 2013	(r336954)
+++ head/graphics/gimmage/pkg-descr	Thu Dec 19 20:04:37 2013	(r336955)
@@ -6,5 +6,4 @@ has an in-application file browser that 
 drag images and directories into the image viewing area in order to
 have them displayed.
 
-Author: Bartek Kostrzewa
 WWW: http://gimmage.berlios.de/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2013-12-19 20:04:47 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-12-20 08:06:37 UTC
Author: bapt
Date: Fri Dec 20 08:06:28 2013
New Revision: 336986
URL: http://svnweb.freebsd.org/changeset/ports/336986

Log:
  MFH: r336955
  
  - Fix build with clang
  - Support desktop-file-utils
  - Port supports staging
  
  PR:		ports/184832
  Submitted by:	KATO Tsuguru <tkato432@yahoo.com>

Modified:
  branches/2014Q1/graphics/gimmage/Makefile
  branches/2014Q1/graphics/gimmage/files/patch-src__FileManager.cpp   (contents, props changed)
  branches/2014Q1/graphics/gimmage/pkg-descr   (contents, props changed)
Directory Properties:
  branches/2014Q1/   (props changed)

Modified: branches/2014Q1/graphics/gimmage/Makefile
==============================================================================
--- branches/2014Q1/graphics/gimmage/Makefile	Fri Dec 20 08:04:50 2013	(r336985)
+++ branches/2014Q1/graphics/gimmage/Makefile	Fri Dec 20 08:06:28 2013	(r336986)
@@ -3,19 +3,18 @@
 
 PORTNAME=	gimmage
 PORTVERSION=	0.2.3
-PORTREVISION=	9
+PORTREVISION=	10
 CATEGORIES=	graphics
 MASTER_SITES=	BERLIOS CENKES
 
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Simple image viewer
 
-LIB_DEPENDS=	libgtkmm-2.4.so:${PORTSDIR}/x11-toolkits/gtkmm24 \
-		libcurl.so:${PORTSDIR}/ftp/curl
+LIB_DEPENDS=	libcurl.so:${PORTSDIR}/ftp/curl
 
-USES=		gettext pkgconfig
+USES=		desktop-file-utils gettext pkgconfig
+USE_GNOME=	gtkmm24
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS+=	--with-libintl-prefix=${LOCALBASE}
+CONFIGURE_ARGS=	--with-libintl-prefix=${LOCALBASE}
 
-NO_STAGE=	yes
 .include <bsd.port.mk>

Modified: branches/2014Q1/graphics/gimmage/files/patch-src__FileManager.cpp
==============================================================================
--- branches/2014Q1/graphics/gimmage/files/patch-src__FileManager.cpp	Fri Dec 20 08:04:50 2013	(r336985)
+++ branches/2014Q1/graphics/gimmage/files/patch-src__FileManager.cpp	Fri Dec 20 08:06:28 2013	(r336986)
@@ -1,6 +1,6 @@
 --- ./src/FileManager.cpp.orig	2007-07-20 23:42:55.000000000 +0400
 +++ ./src/FileManager.cpp	2007-07-20 23:43:03.000000000 +0400
-@@ -23,6 +23,7 @@
+@@ -23,12 +23,13 @@
  
  #include "FileManager.h"
  #include "defines.h"
@@ -8,3 +8,9 @@
  
  #include "../config.h"
  
+ extern "C" {
+ #include <libintl.h>
+-// #include <unistd.h>
++#include <unistd.h>
+ #include <sys/stat.h>
+ }

Modified: branches/2014Q1/graphics/gimmage/pkg-descr
==============================================================================
--- branches/2014Q1/graphics/gimmage/pkg-descr	Fri Dec 20 08:04:50 2013	(r336985)
+++ branches/2014Q1/graphics/gimmage/pkg-descr	Fri Dec 20 08:06:28 2013	(r336986)
@@ -6,5 +6,4 @@ has an in-application file browser that 
 drag images and directories into the image viewing area in order to
 have them displayed.
 
-Author: Bartek Kostrzewa
 WWW: http://gimmage.berlios.de/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"