Bug 185255 - shells/ksh93 : fix exec/unexec entries in pkg-plist
Summary: shells/ksh93 : fix exec/unexec entries in pkg-plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-28 22:50 UTC by Christoph Moench-Tegeder
Modified: 2013-12-31 14:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Moench-Tegeder freebsd_committer freebsd_triage 2013-12-28 22:50:00 UTC
	Installing ksh93 adds the manpage (/usr/local/man/man1/ksh93.1.gz)
	to /etc/shells, which is not very helpful.

Fix: According to the documentation in https://wiki.freebsd.org/ports/StageDir
	and pkg_create(1)/pkg-create(1), the @exec command corresponds to the
	last installed file, and the @unexec command should go before that
	file in pkg-plist.



Regards,
Christoph--mHHA0MjtkpP8vvXgGfFKEp5yFrqG2pMfJiM0UwvYwfE2FH3X
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

Index: pkg-plist
===================================================================
--- pkg-plist	(revision 337927)
+++ pkg-plist	(working copy)
@@ -1,7 +1,7 @@
+@unexec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells
 bin/ksh93
+@exec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells; echo %D/%F >> /etc/shells
 man/man1/ksh93.1.gz
-@exec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells; echo %D/%F >> /etc/shells
-@unexec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells
 %%PORTEXAMPLES%%%%EXAMPLESDIR%%/dirs
 %%PORTEXAMPLES%%%%EXAMPLESDIR%%/popd
 %%PORTEXAMPLES%%%%EXAMPLESDIR%%/pushd
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-28 22:50:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-12-31 13:51:53 UTC
Author: sunpoet
Date: Tue Dec 31 13:51:46 2013
New Revision: 338305
URL: http://svnweb.freebsd.org/changeset/ports/338305

Log:
  - Fix /etc/shells manipulation
  
  PR:		ports/185255
  Submitted by:	Christoph Moench-Tegeder <cmt@burggraben.net>

Modified:
  head/shells/ksh93/pkg-plist   (contents, props changed)

Modified: head/shells/ksh93/pkg-plist
==============================================================================
--- head/shells/ksh93/pkg-plist	Tue Dec 31 13:35:06 2013	(r338304)
+++ head/shells/ksh93/pkg-plist	Tue Dec 31 13:51:46 2013	(r338305)
@@ -1,7 +1,7 @@
+@unexec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells
 bin/ksh93
-man/man1/ksh93.1.gz
 @exec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells; echo %D/%F >> /etc/shells
-@unexec echo "Updating /etc/shells"; sed -i "" "\|%D/%F|d" /etc/shells
+man/man1/ksh93.1.gz
 %%PORTEXAMPLES%%%%EXAMPLESDIR%%/dirs
 %%PORTEXAMPLES%%%%EXAMPLESDIR%%/popd
 %%PORTEXAMPLES%%%%EXAMPLESDIR%%/pushd
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-12-31 13:51:56 UTC
State Changed
From-To: open->closed

Committed. Thanks!