Bug 185262 - [PATCH] Fix audio/ncmpcpp on 10.0 and add stagedir support
Summary: [PATCH] Fix audio/ncmpcpp on 10.0 and add stagedir support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dennis Herrmann
URL:
Keywords:
: 187809 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-29 09:30 UTC by yamagi
Modified: 2014-08-14 23:09 UTC (History)
0 users

See Also:

Attachments
file.diff (1.31 KB, patch)
2013-12-29 09:30 UTC, yamagi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yamagi 2013-12-29 09:30:00 UTC 
Clang is currently unable to build audio/ncmpcpp due to hundreds of type missmatches between ncurses and the local C++ code. I don't think that this can be resolved by a patch of reasonable length. Therefor force the usage of g++ by adding USE_GCC=any to the port. While at it add stagedir support.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-29 09:30:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dhn

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-12-29 11:31:29 UTC 
Author: dhn
Date: Sun Dec 29 11:31:22 2013
New Revision: 337961
URL: http://svnweb.freebsd.org/changeset/ports/337961

Log:
  - Fix build on 10.x
  - Support stage
  
  PR:		ports/185262
  Submitted by:	Yamagi Burmeister <yamagi@yamagi.org>

Modified:
  head/audio/ncmpcpp/Makefile

Modified: head/audio/ncmpcpp/Makefile
==============================================================================
--- head/audio/ncmpcpp/Makefile	Sun Dec 29 11:27:58 2013	(r337960)
+++ head/audio/ncmpcpp/Makefile	Sun Dec 29 11:31:22 2013	(r337961)
@@ -15,8 +15,8 @@ LIB_DEPENDS=	libmpdclient.so:${PORTSDIR}
 		libfftw3.so:${PORTSDIR}/math/fftw3
 
 USES=		iconv ncurses pkgconfig
-NO_STAGE=	yes
 USE_BZIP2=	yes
+USE_GCC=	any
 GNU_CONFIGURE=	yes
 USE_GNOME=	glib20
 USE_AUTOTOOLS=	automake aclocal libtool
@@ -90,15 +90,15 @@ CONFIGURE_ARGS+=	NCURSES_CONFIG=/usr/bin
 .endif
 
 post-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/src/ncmpcpp ${PREFIX}/bin/
+	${INSTALL_PROGRAM} ${WRKSRC}/src/ncmpcpp ${STAGEDIR}${PREFIX}/bin/
 .if ${PORT_OPTIONS:MDOCS}
-	@${ECHO_MSG} "installing additional documentation to ${DOCSDIR}"
+	@${ECHO_MSG} "installing additional documentation to ${STAGEDIR}${DOCSDIR}"
 	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/NEWS ${DOCSDIR}/NEWS
-	${INSTALL_DATA} ${WRKSRC}/AUTHORS ${DOCSDIR}/AUTHORS
-	${INSTALL_DATA} ${WRKSRC}/COPYING ${DOCSDIR}/COPYING
-	${INSTALL_DATA} ${WRKSRC}/doc/config ${DOCSDIR}/config
-	${INSTALL_DATA} ${WRKSRC}/doc/keys ${DOCSDIR}/keys
+	${INSTALL_DATA} ${WRKSRC}/NEWS ${STAGEDIR}${DOCSDIR}/NEWS
+	${INSTALL_DATA} ${WRKSRC}/AUTHORS ${STAGEDIR}${DOCSDIR}/AUTHORS
+	${INSTALL_DATA} ${WRKSRC}/COPYING ${STAGEDIR}${DOCSDIR}/COPYING
+	${INSTALL_DATA} ${WRKSRC}/doc/config ${STAGEDIR}${DOCSDIR}/config
+	${INSTALL_DATA} ${WRKSRC}/doc/keys ${STAGEDIR}${DOCSDIR}/keys
 .endif
 
 	@${ECHO_MSG} ""
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Dennis Herrmann freebsd_committer freebsd_triage 2013-12-29 11:31:44 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-01-08 11:24:07 UTC 
Author: bapt
Date: Wed Jan  8 11:23:59 2014
New Revision: 339096
URL: http://svnweb.freebsd.org/changeset/ports/339096

Log:
  MFH: r337961
  
  - Fix build on 10.x
  - Support stage
  
  PR:		ports/185262
  Submitted by:	Yamagi Burmeister <yamagi@yamagi.org>

Modified:
  branches/2014Q1/audio/ncmpcpp/Makefile
Directory Properties:
  branches/2014Q1/   (props changed)

Modified: branches/2014Q1/audio/ncmpcpp/Makefile
==============================================================================
--- branches/2014Q1/audio/ncmpcpp/Makefile	Wed Jan  8 11:20:19 2014	(r339095)
+++ branches/2014Q1/audio/ncmpcpp/Makefile	Wed Jan  8 11:23:59 2014	(r339096)
@@ -15,8 +15,8 @@ LIB_DEPENDS=	libmpdclient.so:${PORTSDIR}
 		libfftw3.so:${PORTSDIR}/math/fftw3
 
 USES=		iconv ncurses pkgconfig
-NO_STAGE=	yes
 USE_BZIP2=	yes
+USE_GCC=	any
 GNU_CONFIGURE=	yes
 USE_GNOME=	glib20
 USE_AUTOTOOLS=	automake aclocal libtool
@@ -90,15 +90,15 @@ CONFIGURE_ARGS+=	NCURSES_CONFIG=/usr/bin
 .endif
 
 post-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/src/ncmpcpp ${PREFIX}/bin/
+	${INSTALL_PROGRAM} ${WRKSRC}/src/ncmpcpp ${STAGEDIR}${PREFIX}/bin/
 .if ${PORT_OPTIONS:MDOCS}
-	@${ECHO_MSG} "installing additional documentation to ${DOCSDIR}"
+	@${ECHO_MSG} "installing additional documentation to ${STAGEDIR}${DOCSDIR}"
 	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/NEWS ${DOCSDIR}/NEWS
-	${INSTALL_DATA} ${WRKSRC}/AUTHORS ${DOCSDIR}/AUTHORS
-	${INSTALL_DATA} ${WRKSRC}/COPYING ${DOCSDIR}/COPYING
-	${INSTALL_DATA} ${WRKSRC}/doc/config ${DOCSDIR}/config
-	${INSTALL_DATA} ${WRKSRC}/doc/keys ${DOCSDIR}/keys
+	${INSTALL_DATA} ${WRKSRC}/NEWS ${STAGEDIR}${DOCSDIR}/NEWS
+	${INSTALL_DATA} ${WRKSRC}/AUTHORS ${STAGEDIR}${DOCSDIR}/AUTHORS
+	${INSTALL_DATA} ${WRKSRC}/COPYING ${STAGEDIR}${DOCSDIR}/COPYING
+	${INSTALL_DATA} ${WRKSRC}/doc/config ${STAGEDIR}${DOCSDIR}/config
+	${INSTALL_DATA} ${WRKSRC}/doc/keys ${STAGEDIR}${DOCSDIR}/keys
 .endif
 
 	@${ECHO_MSG} ""
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-14 23:09:19 UTC 
*** Bug 187809 has been marked as a duplicate of this bug. ***