Bug 185296 - [patch] security/gnutls3: Fix missing danetool3 shared library
Summary: [patch] security/gnutls3: Fix missing danetool3 shared library
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-30 15:30 UTC by Glen Barber
Modified: 2013-12-30 16:30 UTC (History)
0 users

See Also:


Attachments
file.diff (478 bytes, patch)
2013-12-30 15:30 UTC, Glen Barber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Glen Barber freebsd_committer freebsd_triage 2013-12-30 15:30:00 UTC
pkg-plist for security/gnutls3 is incomplete, missing libgnutls-dane.{a,la,so,so.0}.

Fix: Patch attached.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-12-30 15:30:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 William Grzybowski 2013-12-30 15:35:01 UTC
It builds just fine in poudriere without this patch.
There is probably some conditional port that enables this library.

-- 
William Grzybowski
------------------------------------------
Curitiba/PR - Brasil
Comment 3 Glen Barber freebsd_committer freebsd_triage 2013-12-30 15:48:29 UTC
It builds fine for me too, without the patch.  But on install, the
libraries are missing, so danetool3 does not work.

Glen
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-12-30 16:20:02 UTC
Author: wg
Date: Mon Dec 30 16:19:54 2013
New Revision: 338132
URL: http://svnweb.freebsd.org/changeset/ports/338132

Log:
  security/gnutls3: make danetool3 work
  
  PR:		ports/185296

Modified:
  head/security/gnutls3/Makefile
  head/security/gnutls3/pkg-plist

Modified: head/security/gnutls3/Makefile
==============================================================================
--- head/security/gnutls3/Makefile	Mon Dec 30 16:18:01 2013	(r338131)
+++ head/security/gnutls3/Makefile	Mon Dec 30 16:19:54 2013	(r338132)
@@ -15,6 +15,7 @@ LIB_DEPENDS=	libgpg-error.so:${PORTSDIR}
 		libnettle.so:${PORTSDIR}/security/nettle \
 		libp11-kit.so:${PORTSDIR}/security/p11-kit \
 		libidn.so:${PORTSDIR}/dns/libidn \
+		libunbound.so:${PORTSDIR}/dns/unbound \
 		libtspi.so:${PORTSDIR}/security/trousers
 
 GNUTLS_SUFFIX=	3
@@ -62,12 +63,19 @@ EXAMPLES=	doc/examples/*.c
 
 #INFO=	gnutls
 
+post-patch:
+	@${MV} ${WRKSRC}/libdane/gnutls-dane.pc.in \
+		${WRKSRC}/libdane/gnutls${GNUTLS_SUFFIX}-dane.pc.in
+
 pre-configure:
 	@${CP} ${WRKSRC}/lib/gnutls.pc.in ${WRKSRC}/lib/gnutls${GNUTLS_SUFFIX}.pc.in
 	@${REINPLACE_CMD} \
 		-e 's,(libdir)/pkgconfig,(prefix)/libdata/pkgconfig,' \
 		-e 's,gnutls\.pc,gnutls${GNUTLS_SUFFIX}\.pc,g' \
-		${WRKSRC}/lib/Makefile.in ${WRKSRC}/configure
+		-e 's,gnutls-dane\.pc,gnutls${GNUTLS_SUFFIX}-dane\.pc,g' \
+		${WRKSRC}/lib/Makefile.in \
+		${WRKSRC}/libdane/Makefile.in \
+		${WRKSRC}/configure
 	@${REINPLACE_CMD} -e 's,(top_builddir)$$,(top_builddir) -I$$(top_builddir)/lib/includes -I$$(top_builddir)/libextra/includes,' \
 		${WRKSRC}/doc/Makefile.in
 

Modified: head/security/gnutls3/pkg-plist
==============================================================================
--- head/security/gnutls3/pkg-plist	Mon Dec 30 16:18:01 2013	(r338131)
+++ head/security/gnutls3/pkg-plist	Mon Dec 30 16:19:54 2013	(r338132)
@@ -12,6 +12,7 @@ bin/tpmtool3
 include/gnutls3/gnutls/abstract.h
 include/gnutls3/gnutls/compat.h
 include/gnutls3/gnutls/crypto.h
+include/gnutls3/gnutls/dane.h
 include/gnutls3/gnutls/dtls.h
 include/gnutls3/gnutls/gnutls.h
 %%CXX%%include/gnutls3/gnutls/gnutlsxx.h
@@ -38,6 +39,10 @@ info/gnutls3/gnutls.info
 info/gnutls3/gnutls.info-4
 info/gnutls3/gnutls.info-5
 info/gnutls3/pkcs11-vision.png
+lib/gnutls3/libgnutls-dane.a
+lib/gnutls3/libgnutls-dane.la
+lib/gnutls3/libgnutls-dane.so
+lib/gnutls3/libgnutls-dane.so.0
 lib/gnutls3/libgnutls-openssl.a
 lib/gnutls3/libgnutls-openssl.la
 lib/gnutls3/libgnutls-openssl.so
@@ -55,6 +60,8 @@ lib/gnutls3/libgnutls.so.28
 %%CXX%%lib/gnutls3/libgnutlsxx.so
 %%CXX%%lib/gnutls3/libgnutlsxx.so.28
 libdata/pkgconfig/gnutls3.pc
+libdata/pkgconfig/gnutls3-dane.pc
+man/man1/danetool3.1.gz
 man/man1/certtool3.1.gz
 man/man1/gnutls-cli-debug3.1.gz
 man/man1/gnutls-cli3.1.gz
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 William Grzybowski freebsd_committer freebsd_triage 2013-12-30 16:20:03 UTC
State Changed
From-To: open->closed

Fixed, thanks.