Bug 185493 - [PATCH] devel/subversion: Do not tie the KDE_KWALLET option to NLS
Summary: [PATCH] devel/subversion: Do not tie the KDE_KWALLET option to NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Lev A. Serebryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-05 15:10 UTC by Raphael Kubo da Costa
Modified: 2014-01-21 20:30 UTC (History)
1 user (show)

See Also:


Attachments
subversion-1.8.5.patch (783 bytes, patch)
2014-01-05 15:10 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-01-05 15:10:00 UTC
Ever since Subversion's r1466445 https://svn.apache.org/viewvc?view=revision&revision=1466445, which has been present for the whole 1.8 series, KWallet detection does not depend on NLS support anymore. The attached patch removes the KDE_KWALLET+NLS check from Makefile.common.

Port maintainer (lev@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-05 15:10:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lev

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-01-21 20:23:46 UTC
Author: rakuco
Date: Tue Jan 21 20:23:38 2014
New Revision: 340652
URL: http://svnweb.freebsd.org/changeset/ports/340652
QAT: https://qat.redports.org/buildarchive/r340652/

Log:
  Do not tie the KDE_KWALLET option to NLS.
  
  Ever since Subversion's r1466445
  https://svn.apache.org/viewvc?view=revision&revision=1466445, which has been
  present for the whole 1.8 series, KWallet detection does not depend on NLS
  support anymore.
  
  PR:		ports/185493
  Submitted by:	rakuco@
  Approved by:	maintainer timeout (16 days)

Modified:
  head/devel/subversion/Makefile.common

Modified: head/devel/subversion/Makefile.common
==============================================================================
--- head/devel/subversion/Makefile.common	Tue Jan 21 20:17:40 2014	(r340651)
+++ head/devel/subversion/Makefile.common	Tue Jan 21 20:23:38 2014	(r340652)
@@ -74,10 +74,6 @@ STATIC_CONFIGURE_ON=		--enable-all-stati
 IGNORE=	to build mod_dontdothat OPTION mod_dav_svn is required
 .endif
 
-.if ${PORT_OPTIONS:MKDE_KWALLET} && !${PORT_OPTIONS:MNLS}
-IGNORE= KWallet requires OPTION NLS set to ON
-.endif
-
 APR_CONFIG=	${LOCALBASE}/bin/apr-1-config
 APU_CONFIG=	${LOCALBASE}/bin/apu-1-config
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-01-21 20:23:55 UTC
State Changed
From-To: open->closed

Committed as r340652.