Bug 185664 - [UPDATE] games/pathological, add license and desktop entry
Summary: [UPDATE] games/pathological, add license and desktop entry
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-11 18:20 UTC by hardy.schumacher
Modified: 2014-01-30 21:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.86 KB, patch)
2014-01-11 18:20 UTC, hardy.schumacher
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hardy.schumacher 2014-01-11 18:20:00 UTC
Add license information.
Add desktop entry.
Converted to new options framework.
Fixed some issues reported by portlint.

Fix: Patch attached with submission follows:
How-To-Repeat: n/a
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-11 18:20:07 UTC
Maintainer of games/pathological,

Please note that PR ports/185664 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185664

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-11 18:20:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2014-01-30 20:07:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-01-30 21:04:46 UTC
Author: pawel
Date: Thu Jan 30 21:04:38 2014
New Revision: 341887
URL: http://svnweb.freebsd.org/changeset/ports/341887
QAT: https://qat.redports.org/buildarchive/r341887/

Log:
  - Add LICENSE, desktop entry file [1]
  - Convert to new options framework [1]
  - Fix issues reported by portlint [1]
  - Use PYGAME for RUN_DEPENDS
  - Add staging support
  - Unmute install commands
  
  PR:		ports/185664 [1]
  Submitted by:	Hardy Schumacher <hardy.schumacher@gmx.de>
  Approved by:	maintainer timeout

Modified:
  head/games/pathological/Makefile
  head/games/pathological/pkg-descr
  head/games/pathological/pkg-plist

Modified: head/games/pathological/Makefile
==============================================================================
--- head/games/pathological/Makefile	Thu Jan 30 20:58:42 2014	(r341886)
+++ head/games/pathological/Makefile	Thu Jan 30 21:04:38 2014	(r341887)
@@ -3,38 +3,41 @@
 
 PORTNAME=	pathological
 PORTVERSION=	1.1.3
-PORTREVISION=	7
+PORTREVISION=	8
 CATEGORIES=	games
 MASTER_SITES=	SF
 
 MAINTAINER=	jmohacsi@bsd.hu
 COMMENT=	Enriched clone of the game "Logical"
 
-RUN_DEPENDS=	${PYTHON_SITELIBDIR}/pygame/__init__.py:${PORTSDIR}/devel/py-game
+LICENSE=	GPLv2
+
+RUN_DEPENDS=	${PYGAME}
+
+OPTIONS_DEFINE=	DOCS
 
 USE_PYTHON=	yes
 NO_BUILD=	yes
-MAN6=		pathological.6
-MANCOMPRESSED=	yes
 
 DOC_FILES=	favicon.ico index.html
 
-NO_STAGE=	yes
+DESKTOP_ENTRIES="Pathological" \
+		"Logic game" \
+		"${DATADIR}/pathological.ico" \
+		"pathological" \
+		"Game;LogicGame;" \
+		false
+
 do-install:
-	@${MKDIR} ${DATADIR}
+	@${MKDIR} ${STAGEDIR}${DATADIR}
 	(cd ${WRKSRC}; tar -cf - circuits graphics music sounds pathological.ico pathological.py pathological.xpm) | \
-		(cd ${DATADIR}; tar --unlink -xf -)
-	@printf "#!/bin/sh\ncd ${DATADIR} && \
+		(cd ${STAGEDIR}${DATADIR}; tar --unlink -xf -)
+	@${PRINTF} "#!/bin/sh\ncd ${DATADIR} && \
 		exec ${PYTHON_CMD} ${DATADIR}/pathological.py\n" > ${WRKDIR}/pathological.sh
-	@${INSTALL_SCRIPT} ${WRKDIR}/pathological.sh ${PREFIX}/bin/pathological
-.ifndef(NO_INSTALL_MANPAGES)
-	${INSTALL_MAN} ${WRKSRC}/${MAN6}.gz ${MAN6PREFIX}/man/man6/
-.endif
-.ifndef(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
-.for file in ${DOC_FILES}
-	@${INSTALL_DATA} ${WRKSRC}/html/${file} ${DOCSDIR}
-.endfor
-.endif
+	${INSTALL_SCRIPT} ${WRKDIR}/pathological.sh \
+		${STAGEDIR}${PREFIX}/bin/pathological
+	${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.6.gz ${STAGEDIR}${MANPREFIX}/man/man6
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${DOC_FILES:S|^|${WRKSRC}/html/|g} ${STAGEDIR}${DOCSDIR}
 
 .include <bsd.port.mk>

Modified: head/games/pathological/pkg-descr
==============================================================================
--- head/games/pathological/pkg-descr	Thu Jan 30 20:58:42 2014	(r341886)
+++ head/games/pathological/pkg-descr	Thu Jan 30 21:04:38 2014	(r341887)
@@ -10,4 +10,4 @@ Features
     * 50 diverse and challenging levels (more to come...)
     * A cool 6-minute ambient soundtrack by an award-winning musician
 
-WWW:	http://pathological.sourceforge.net/
+WWW: http://pathological.sourceforge.net/

Modified: head/games/pathological/pkg-plist
==============================================================================
--- head/games/pathological/pkg-plist	Thu Jan 30 20:58:42 2014	(r341886)
+++ head/games/pathological/pkg-plist	Thu Jan 30 21:04:38 2014	(r341887)
@@ -1,4 +1,5 @@
 bin/pathological
+man/man6/pathological.6.gz
 %%DATADIR%%/circuits/all-boards
 %%DATADIR%%/graphics/backdrop.jpg
 %%DATADIR%%/graphics/blank-bg-tile.png
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Pawel Pekala freebsd_committer freebsd_triage 2014-01-30 21:04:50 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!