Bug 185723 - audio/sdl_mixer: enable MIKMOD support by default again
Summary: audio/sdl_mixer: enable MIKMOD support by default again
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Marcus von Appen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-12 20:30 UTC by Max Brazhnikov
Modified: 2014-01-17 20:50 UTC (History)
0 users

See Also:

Attachments
file.diff (579 bytes, patch)
2014-01-12 20:30 UTC, Max Brazhnikov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Brazhnikov freebsd_committer freebsd_triage 2014-01-12 20:30:00 UTC 
Enable MIKMOD support by default again. libmikmod is already installed by
sdl_sound, but sdl_mixer doesn't use it. The option was silently disabled
in r327809, as result some games fail to run, e.g. games/powermanga:

(EE) Mix_LoadMUS(/usr/local/share/powermanga/sounds/music_menu.zik) return:
Unrecognized music format [sdl_mixer.c:234, sound_load_module]

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-12 20:30:09 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mva

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-01-17 20:45:49 UTC 
Author: mva
Date: Fri Jan 17 20:45:42 2014
New Revision: 340105
URL: http://svnweb.freebsd.org/changeset/ports/340105
QAT: https://qat.redports.org/buildarchive/r340105/

Log:
  - make MIKMOD option the default again, which was lost on an earlier commit
  
  PR:		ports/185723
  Submitted by:	makc@

Modified:
  head/audio/sdl_mixer/Makefile

Modified: head/audio/sdl_mixer/Makefile
==============================================================================
--- head/audio/sdl_mixer/Makefile	Fri Jan 17 20:34:33 2014	(r340104)
+++ head/audio/sdl_mixer/Makefile	Fri Jan 17 20:45:42 2014	(r340105)
@@ -3,7 +3,7 @@
 
 PORTNAME=	sdl_mixer
 PORTVERSION=	1.2.12
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	audio
 MASTER_SITES=	http://www.libsdl.org/projects/SDL_mixer/release/
 DISTNAME=	SDL_mixer-${PORTVERSION}
@@ -22,7 +22,7 @@ CPPFLAGS+=	-I${LOCALBASE}/include
 USE_LDCONFIG=	yes
 
 OPTIONS_DEFINE=		SMPEG FLAC VORBIS TIMIDITYPLUS
-OPTIONS_DEFAULT=	SMPEG FLAC VORBIS
+OPTIONS_DEFAULT=	SMPEG FLAC VORBIS MIKMOD
 OPTIONS_RADIO=		MOD
 OPTIONS_RADIO_MOD=	MIKMOD MODPLUG
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Marcus von Appen freebsd_committer freebsd_triage 2014-01-17 20:46:19 UTC 
State Changed
From-To: open->closed

Committed. Thanks!