Bug 186107 - [patch] x11/rxvt-unicode should use gcc only wants enable mousewheel
Summary: [patch] x11/rxvt-unicode should use gcc only wants enable mousewheel
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-25 20:40 UTC by Zsolt Udvari
Modified: 2014-02-08 13:10 UTC (History)
1 user (show)

See Also:

Attachments
rxvt-unicode-gcc-only-mousewheel.patch (750 bytes, patch)
2014-01-25 20:40 UTC, Zsolt Udvari 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari freebsd_committer freebsd_triage 2014-01-25 20:40:00 UTC 
The x11/rxvt-unicode/Makefile says (rev 332906):
USE_GCC=		yes # segfaults when trying to scroll with the mouse wheel if clang

I think if user doesn't want mousewheel support can build with clang (which is default in 10.0) so gcc isn't necessary.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2014-01-25 21:28:55 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->thierry


Take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-02-08 13:06:44 UTC 
Author: thierry
Date: Sat Feb  8 13:06:37 2014
New Revision: 343325
URL: http://svnweb.freebsd.org/changeset/ports/343325
QAT: https://qat.redports.org/buildarchive/r343325/

Log:
  Don't force Gcc when MOUSEWHEEL is disabled.
  
  PR:		ports/186107
  Submitted by:	Zsolt Udvari <udvzsolt (at) gmail.com>

Modified:
  head/x11/rxvt-unicode/Makefile

Modified: head/x11/rxvt-unicode/Makefile
==============================================================================
--- head/x11/rxvt-unicode/Makefile	Sat Feb  8 12:47:51 2014	(r343324)
+++ head/x11/rxvt-unicode/Makefile	Sat Feb  8 13:06:37 2014	(r343325)
@@ -18,7 +18,6 @@ RUN_DEPENDS=	${LOCALBASE}/bin/fc-cache:$
 		${LOCALBASE}/share/misc/terminfo.db:${PORTSDIR}/devel/ncurses
 
 USES=			pkgconfig shebangfix
-USE_GCC=		yes # segfaults when trying to scroll with the mouse wheel if clang
 USE_XORG=		xpm xft xrender
 GNU_CONFIGURE=		yes
 CPPFLAGS+=		-I${LOCALBASE}/include
@@ -129,6 +128,8 @@ CONFIGURE_ARGS+=	--disable-delete-key
 # enable scrolling via mouse wheel or buttons 4 & 5
 .if !${PORT_OPTIONS:MMOUSEWHEEL}
 CONFIGURE_ARGS+=	--disable-mousewheel
+.else
+USE_GCC=		yes # segfaults when trying to scroll with the mouse wheel if clang
 .endif
 
 # enable smart resize
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2014-06-01 08:06:47 UTC 
State Changed
From-To: open->closed


Committed, thanks!