Bug 186138 - [patch] multimedia/x264: hi10p should not be enabled by default
Summary: [patch] multimedia/x264: hi10p should not be enabled by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-26 21:30 UTC by vsjcfm
Modified: 2014-01-27 03:09 UTC (History)
0 users

See Also:


Attachments
file.txt (545 bytes, text/plain)
2014-01-26 21:30 UTC, vsjcfm
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description vsjcfm 2014-01-26 21:30:00 UTC
10-bit support requires more computing resources and not commonly used, so HI10P option should be set to off by default. Who needs - will enable it explicitly.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-26 21:30:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->koobs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-01-27 01:53:41 UTC
Author: koobs
Date: Mon Jan 27 01:53:33 2014
New Revision: 341318
URL: http://svnweb.freebsd.org/changeset/ports/341318
QAT: https://qat.redports.org/buildarchive/r341318/

Log:
  multimedia/x264: Turn HI10P option off by default.
  
  Inadvertently left the new HI10P option included in OPTIONS_DEFAULT in the
  last commit while I was testing. Remove it.
  
  PR:		ports/186138
  Submitted by:	Anton Sayetsky <vsjcfm@gmail.com>

Modified:
  head/multimedia/x264/Makefile

Modified: head/multimedia/x264/Makefile
==============================================================================
--- head/multimedia/x264/Makefile	Mon Jan 27 00:12:40 2014	(r341317)
+++ head/multimedia/x264/Makefile	Mon Jan 27 01:53:33 2014	(r341318)
@@ -3,7 +3,7 @@
 
 PORTNAME=	x264
 PORTVERSION=	0.${X264_BUILD}.${X264_REV}
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	multimedia
 MASTER_SITES=	ftp://ftp.videolan.org/pub/videolan/x264/snapshots/ \
 		http://samples.mplayerhq.hu/yuv4mpeg2/:pgo
@@ -33,7 +33,7 @@ USE_LDCONFIG=	yes
 HAS_CONFIGURE=	yes
 
 OPTIONS_DEFINE=		ASM DEBUG HI10P PGO GCC GPAC X11_OUTPUT
-OPTIONS_DEFAULT=	ASM GPAC HI10P
+OPTIONS_DEFAULT=	ASM GPAC
 ASM_DESC=		Enable Assembly Optimizations
 GCC_DESC=		Use current GCC
 HI10P_DESC=		Enable High 10 Profile 10-bit encoding
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2014-01-27 03:09:31 UTC
State Changed
From-To: open->closed

Committed, thank you Anton!