Bug 186533 - Update security/luasec to 0.5
Summary: Update security/luasec to 0.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-07 15:30 UTC by Benjamin Podszun
Modified: 2014-02-07 21:50 UTC (History)
0 users

See Also:


Attachments
file.diff (1.88 KB, patch)
2014-02-07 15:30 UTC, Benjamin Podszun
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Podszun 2014-02-07 15:30:00 UTC
Luasec recently (after some pressure, some projects even forked the library just to get a new release out of the door) released 0.5

Since I'm interested in net-im/prosody, which depends on security/luasec, I would like to see this update land in FreeBSD.

The patch attached builds fine on my system and I'm successfully running prosody with this version of security/luasec. portlint complains only about minor issues:

Only one master site: That's.. a lie. Yes, one URL. But Github and a CDN hiding behind that address

No ftp/http mirrors for user behing proxies: No idea what to do about that.

License not set: I'm not sure, I'd guess that is a variation of the BSD license, but don't want to make that call

I enabled staging support - the package seems to build/install fine without the opt-out.

If no one cares enough about this port I'd gladly volunteer to take it over - prosody (and therefor luasec) is a core part of what I'm using FreeBSD for.

Fix: Apply attached patch.

Patch attached with submission follows:
How-To-Repeat: $ pkg search luasec
lua51-luasec-0.4
Comment 1 David Thiel freebsd_committer freebsd_triage 2014-02-07 21:30:56 UTC
Just to check, this should remove the dependency on luasocket, correct?
Also, -L./luasocket should be -L${WRKSRC}/src/luasocket, Iâll change
that in the commit.

Thanks,
David
Comment 2 Benjamin Podszun 2014-02-07 21:34:12 UTC
On Friday, February 7, 2014 10:30:56 PM CEST, David Thiel wrote:
> Just to check, this should remove the dependency on luasocket, correct?

I .. am not sure. This links to the locally provided fork of luasocket (and=20=

as I wrote elsewhere, according to the prosody people that very well might=20=

be just one package in the future). But I haven't tested it without=20
luasocket, to be honest. Want me to give it a try?

> Also, -L./luasocket should be -L${WRKSRC}/src/luasocket, I=E2=80=99ll chang=
e
> that in the commit.

Makes a lot more sense. That's probably a relic from my 'getting it to=20
work' struggle.

Thanks for looking into it!

Ben
Comment 3 dfilter service freebsd_committer freebsd_triage 2014-02-07 21:46:33 UTC
Author: lx
Date: Fri Feb  7 21:46:26 2014
New Revision: 343299
URL: http://svnweb.freebsd.org/changeset/ports/343299
QAT: https://qat.redports.org/buildarchive/r343299/

Log:
  Update and take maintainership. Remove dependency on luasocket.
  
  PR:		ports/186533
  Submitted by:	Benjamin Podszun <dar@darklajid.de>

Modified:
  head/security/luasec/Makefile
  head/security/luasec/distinfo

Modified: head/security/luasec/Makefile
==============================================================================
--- head/security/luasec/Makefile	Fri Feb  7 21:23:30 2014	(r343298)
+++ head/security/luasec/Makefile	Fri Feb  7 21:46:26 2014	(r343299)
@@ -2,25 +2,25 @@
 # $FreeBSD$
 
 PORTNAME=	luasec
-PORTVERSION=	0.4
+PORTVERSION=	0.5
 CATEGORIES=	security
-MASTER_SITES=	http://www.inf.puc-rio.br/~brunoos/luasec/download/
+MASTER_SITES=	https://github.com/brunoos/${PORTNAME}/archive/
 PKGNAMEPREFIX=	${LUA_PKGNAMEPREFIX}
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	lx@FreeBSD.org
 COMMENT=	Lua binding for the OpenSSL library to provide TLS/SSL communication
 
-RUN_DEPENDS+=	${LUA_MODLIBDIR}/socket/core.so:${PORTSDIR}/net/luasocket
+FETCH_ARGS=	-Fpr
+WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTNAME}-${PORTVERSION}
 
 ALL_TARGET=	bsd
-LIBDIR=		-L${LUA_LIBDIR}
-MAKE_ENV+=	INCDIR=-I${LUA_INCDIR} LUAPATH=${LUA_MODSHAREDIR} \
+LIBDIR=		-L${LUA_LIBDIR} -L${WRKSRC}/src/luasocket
+MAKE_ENV+=	INCDIR="-I${LUA_INCDIR} -I${WRKSRC}/src" LUAPATH=${LUA_MODSHAREDIR} \
 		CPATH=${LUA_MODLIBDIR}
 USE_LUA=	5.1
 WANT_LUA_VER=	5.1
 USE_OPENSSL=	yes
 
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
 # NOTE: OSVERSION is already defined here, and USE_OPENSSL_PORT
@@ -31,10 +31,12 @@ USE_OPENSSL_PORT=yes
 .endif
 
 post-patch:	.SILENT
-	${REINPLACE_CMD} -Ee '/^CC/s/=/?=/' \
-		-e '/^LD/s/gcc/$$(CC)/' \
-		-e '/^(C|LD)FLAGS/s/=/+=/' \
-		-e '/^BSD/{s/-O[0-3]?//;}' \
+	${REINPLACE_CMD} -Ee '/\(INSTALL\)/s/-D //' \
+		-e '/^LDFLAGS/s/\+=/=/' \
+		-e 's/LUAPATH/LUA_MODSHAREDIR/' \
+		-e 's/LUACPATH/LUA_MODLIBDIR/' \
 		${WRKSRC}/src/Makefile
+	${REINPLACE_CMD} -Ee '/^(INC|LIB)DIR/s/[^?]=/?=/' \
+		${WRKSRC}/Makefile
 
 .include <bsd.port.mk>

Modified: head/security/luasec/distinfo
==============================================================================
--- head/security/luasec/distinfo	Fri Feb  7 21:23:30 2014	(r343298)
+++ head/security/luasec/distinfo	Fri Feb  7 21:46:26 2014	(r343299)
@@ -1,2 +1,2 @@
-SHA256 (luasec-0.4.tar.gz) = 111732f0e646120a701d33e7d3a613a9a901c11c0a01d0805d73ef90c3f0abd5
-SIZE (luasec-0.4.tar.gz) = 27829
+SHA256 (luasec-0.5.tar.gz) = 6480598f7492ac479b6b608b5fb1488226bfa6ef675e29f6b24dbe9099083523
+SIZE (luasec-0.5.tar.gz) = 46738
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 David Thiel freebsd_committer freebsd_triage 2014-02-07 21:46:47 UTC
State Changed
From-To: open->closed

Committed, thanks!