Bug 186607 - [patch] www/mediawiki121 breaks with PCRE 8.34
Summary: [patch] www/mediawiki121 breaks with PCRE 8.34
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-09 21:40 UTC by robbertkl
Modified: 2014-02-12 14:40 UTC (History)
0 users

See Also:


Attachments
file.txt (575 bytes, text/plain)
2014-02-09 21:40 UTC, robbertkl
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description robbertkl 2014-02-09 21:40:00 UTC
Last February 5, devel/pcre was updated to 8.34, which causes www/mediawiki to break and show blank pages.

See: https://bugzilla.wikimedia.org/show_bug.cgi?id=58640

The issue has already been fixed in mediawiki release 1.22 (which isn't in ports?). AFAIK, the fix isn't yet backported to 1.21, which is the latest mediawiki in ports. Probably the same issue applies to www/mediawiki119 and www/mediawiki/120 as well!

Fix: See attached patch, which is a 1.21 backport of the final patch described in https://bugzilla.wikimedia.org/show_bug.cgi?id=58640

Patch attached with submission follows:
How-To-Repeat: Try to run mediawiki-1.21.5 with pcre-8.34 and all pages will be blank.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-09 21:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wen

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-02-12 14:32:05 UTC
Author: wen
Date: Wed Feb 12 14:31:58 2014
New Revision: 343924
URL: http://svnweb.freebsd.org/changeset/ports/343924
QAT: https://qat.redports.org/buildarchive/r343924/

Log:
  - Apply a patch from upstream to fix pcre-8.34 incompatible:
  https://bugzilla.wikimedia.org/show_bug.cgi?id=58640
  
  PR:		186607
  Submitted by:	Robbert Klarenbeek <robbertkl@renbeek.nl>

Added:
  head/www/mediawiki121/files/
  head/www/mediawiki121/files/patch-includes-MagicWord.php   (contents, props changed)
Modified:
  head/www/mediawiki121/Makefile

Modified: head/www/mediawiki121/Makefile
==============================================================================
--- head/www/mediawiki121/Makefile	Wed Feb 12 14:03:25 2014	(r343923)
+++ head/www/mediawiki121/Makefile	Wed Feb 12 14:31:58 2014	(r343924)
@@ -3,6 +3,7 @@
 
 PORTNAME=	mediawiki
 PORTVERSION=	1.21.5
+PORTREVISION=	1
 CATEGORIES=	www
 MASTER_SITES=	http://dumps.wikimedia.org/mediawiki/${PORTVERSION:R}/
 

Added: head/www/mediawiki121/files/patch-includes-MagicWord.php
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/www/mediawiki121/files/patch-includes-MagicWord.php	Wed Feb 12 14:31:58 2014	(r343924)
@@ -0,0 +1,13 @@
+--- includes/MagicWord.php.orig	2014-02-12 22:03:25.000000000 +0800
++++ includes/MagicWord.php	2014-02-12 22:05:10.000000000 +0800
+@@ -704,7 +704,9 @@
+ 				$magic = MagicWord::get( $name );
+ 				$case = intval( $magic->isCaseSensitive() );
+ 				foreach ( $magic->getSynonyms() as $i => $syn ) {
+-					$group = "(?P<{$i}_{$name}>" . preg_quote( $syn, '/' ) . ')';
++					// Group name must start with a non-digit in PCRE 8.34+
++					$it = strtr( $i, '0123456789', 'abcdefghij' );
++					$group = "(?P<{$it}_{$name}>" . preg_quote( $syn, '/' ) . ')';
+ 					if ( $this->baseRegex[$case] === '' ) {
+ 						$this->baseRegex[$case] = $group;
+ 					} else {
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Wen Heping freebsd_committer freebsd_triage 2014-02-12 14:32:49 UTC
State Changed
From-To: open->closed

Committed. Thanks!