Bug 186687 - [patch] net-im/imspector: Modernize and add an option to build PLUGINS
Summary: [patch] net-im/imspector: Modernize and add an option to build PLUGINS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 11:30 UTC by Renato Botelho
Modified: 2014-02-19 19:19 UTC (History)
0 users

See Also:


Attachments
file.diff (3.54 KB, patch)
2014-02-12 11:30 UTC, Renato Botelho
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Botelho freebsd_committer freebsd_triage 2014-02-12 11:30:01 UTC
- Replace USE_GMAKE by USES=gmake
- Use OPTIONS helpers
- Support STAGING
- Pet portlint
- Add a new option, off by default, to build PLUGINS

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-12 11:30:08 UTC
Maintainer of net-im/imspector,

Please note that PR ports/186687 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186687

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-12 11:30:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Renato Botelho freebsd_committer freebsd_triage 2014-02-12 12:03:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->garga

y
Comment 4 m.tsatsenko 2014-02-19 14:37:35 UTC
Approved, Thanks!

-- 
Mikhail
Comment 5 dfilter service freebsd_committer freebsd_triage 2014-02-19 14:52:46 UTC
Author: garga
Date: Wed Feb 19 14:52:32 2014
New Revision: 345098
URL: http://svnweb.freebsd.org/changeset/ports/345098
QAT: https://qat.redports.org/buildarchive/r345098/

Log:
  - Replace USE_GMAKE by USES=gmake
  - Use OPTIONS helpers
  - Support staging
  - Pet portlint
  - Add a new option, off by default, to build PLUGINS
  
  PR:		ports/186687
  Approved by:	Mikhail Tsatsenko <m.tsatsenko@gmail.com> (maintainer)

Modified:
  head/net-im/imspector/Makefile
  head/net-im/imspector/files/patch-Makefile
  head/net-im/imspector/pkg-plist

Modified: head/net-im/imspector/Makefile
==============================================================================
--- head/net-im/imspector/Makefile	Wed Feb 19 14:45:19 2014	(r345097)
+++ head/net-im/imspector/Makefile	Wed Feb 19 14:52:32 2014	(r345098)
@@ -13,8 +13,7 @@ COMMENT=	IM transparent proxy with monit
 LICENSE=	GPLv2
 
 CFLAGS+=	-fPIC -I ${LOCALBASE}/include -DHAVE_SSL
-USE_GMAKE=	YES
-USES=		iconv
+USES=		iconv gmake
 USE_OPENSSL=	YES
 USE_LDCONFIG=	${LOCALBASE}/lib/imspector
 
@@ -24,19 +23,20 @@ USE_RC_SUBR=	${PORTNAME}
 
 MAKE_ENV+=	ETCDIR=${ETCDIR}
 
-OPTIONS_DEFINE=	IPFW
-OPTIONS_DEFAULT=	IPFW
+OPTIONS_DEFINE=	IPFW PLUGINS
+OPTIONS_DEFAULT=IPFW
+OPTIONS_SUB=	yes
+
 IPFW_DESC=	Add IPFW support
+PLUGINS_DESC=	Build plugins
 
-NO_STAGE=	yes
-.include <bsd.port.options.mk>
+IPFW_CFLAGS=	-DIPFW_TRANSPARENT=1
+PLUGINS_USE=	MYSQL=yes SQLITE=yes PGSQL=yes
 
-.if ${PORT_OPTIONS:MIPFW}
-CFLAGS+=	-DIPFW_TRANSPARENT=1
-.endif
+.include <bsd.port.options.mk>
 
 post-extract:
-	${MV} ${WRKDIR}/${PORTNAME} ${WRKSRC}
+	@${MV} ${WRKDIR}/${PORTNAME} ${WRKSRC}
 
 post-patch:
 	@${REINPLACE_CMD} -e 's,%%PREFIX%%,${PREFIX},g' \
@@ -46,12 +46,9 @@ post-patch:
 		${WRKSRC}/sslstate.cpp
 	@${REINPLACE_CMD} -e 's,%%ICONV_LIB%%,${ICONV_LIB},' \
 		${WRKSRC}/Makefile
-
-post-install:
-.for f in ${CONFIG_FILES}
-	@if [ ! -f ${ETCDIR}/${f} ]; then \
-		${CP} -p ${ETCDIR}/${f}.sample ${ETCDIR}/${f} ; \
-	fi
-.endfor
+.if ${PORT_OPTIONS:MPLUGINS}
+	@${REINPLACE_CMD} -e 's,#ADD_PLUGINS,ADD_PLUGINS,' \
+		${WRKSRC}/Makefile
+.endif
 
 .include <bsd.port.mk>

Modified: head/net-im/imspector/files/patch-Makefile
==============================================================================
--- head/net-im/imspector/files/patch-Makefile	Wed Feb 19 14:45:19 2014	(r345097)
+++ head/net-im/imspector/files/patch-Makefile	Wed Feb 19 14:52:32 2014	(r345098)
@@ -1,5 +1,5 @@
---- Makefile.orig	2008-12-22 15:03:15.000000000 +0300
-+++ Makefile	2011-06-14 14:26:22.072210675 +0400
+--- Makefile.orig	2010-02-23 14:20:33.000000000 -0300
++++ Makefile	2014-02-11 21:23:19.000000000 -0200
 @@ -1,5 +1,5 @@
 -DESTDIR = /
 -PREFIX = /usr
@@ -46,7 +46,7 @@
  yahooprotocolplugin.so: yahooprotocolplugin.o libimspector.so
  	$(CXX) yahooprotocolplugin.o libimspector.so $(PLUGIN_FLAGS)
  ircprotocolplugin.so: ircprotocolplugin.o libimspector.so
-@@ -162,15 +162,15 @@
+@@ -162,17 +162,17 @@
  install: imspector libimspector.so $(PLUGINS)
  	-mkdir -p $(DESTDIR)/$(PREFIX)/sbin
  	-mkdir -p $(DESTDIR)/$(PREFIX)/lib/imspector
@@ -62,10 +62,14 @@
 -	-install imspector.conf $(DESTDIR)/$(PREFIX)/etc/imspector/imspector.conf
 -	-install badwords.txt $(DESTDIR)/$(PREFIX)/etc/imspector/badwords.txt
 -	-install acl.txt $(DESTDIR)/$(PREFIX)/etc/imspector/acl.txt
+-	-mkdir -p /var/log/imspector
+-	-mkdir -p /var/lib/imspector
 +	-mkdir -p $(DESTDIR)/$(ETCDIR)
 +	-${BSD_INSTALL_DATA} imspector.conf $(DESTDIR)/$(ETCDIR)/imspector.conf.sample
 +	-${BSD_INSTALL_DATA} badwords.txt $(DESTDIR)/$(ETCDIR)/badwords.txt.sample
 +	-${BSD_INSTALL_DATA} acl.txt $(DESTDIR)/$(ETCDIR)/acl.txt.sample
- 	-mkdir -p /var/log/imspector
- 	-mkdir -p /var/lib/imspector
++	-mkdir -p $(DESTDIR)/var/log/imspector
++	-mkdir -p $(DESTDIR)/var/lib/imspector
  
+ install-cert:
+ 	-mkdir -p $(DESTDIR)/$(PREFIX)/etc/imspector

Modified: head/net-im/imspector/pkg-plist
==============================================================================
--- head/net-im/imspector/pkg-plist	Wed Feb 19 14:45:19 2014	(r345097)
+++ head/net-im/imspector/pkg-plist	Wed Feb 19 14:52:32 2014	(r345098)
@@ -23,6 +23,11 @@ lib/imspector/ircprotocolplugin.so
 lib/imspector/miscfilterplugin.so
 lib/imspector/msnprotocolplugin.so
 lib/imspector/yahooprotocolplugin.so
+%%PLUGINS%%lib/imspector/dbfilterplugin.so
+%%PLUGINS%%lib/imspector/dbresponderplugin.so
+%%PLUGINS%%lib/imspector/mysqlloggingplugin.so
+%%PLUGINS%%lib/imspector/postgresqlloggingplugin.so
+%%PLUGINS%%lib/imspector/sqliteloggingplugin.so
 lib/libimspector.so
 sbin/imspector
 @dirrmtry %%ETCDIR%%
@@ -31,4 +36,4 @@ sbin/imspector
 @dirrmtry lib/imspector
 @dirrmtry lib
 @dirrmtry log/imspector
-@cwd 
+@cwd
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Renato Botelho freebsd_committer freebsd_triage 2014-02-19 19:19:54 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!