The NTLM option has no effect, meaning NTLM support is still enabled even if the NTLM option/checkbox is disabled. I went through the port Makefile and I see nothing wrong. The option controls use of --disable-ntlm or --enable-ntlm during configure. However, both of these flags are no-ops in curl's configure script. curl's autoconf/configure script allows flags of any kind to work, e.g. --disable-tiny-brained-marmots won't throw an error or warning. I have no idea when the curl folks removed --{disable,enable}-ntlm. If you do ./configure --help | grep -i ntlm, you'll see there are no such options, but there are some called --enable-ntlm-wb and --disable-ntlm-wb, but those appear to be related to NTLM delegation to winbind ntlm_auth (I don't know what that is). Fix: My fix would be to remove the NTLM option from the Makefile entirely, however I'm not sure about the NTLM vs. SSL engine logic located at lines 141 to 143. Someone may want to add something like NTLM_WB as an option, but I don't know what the necessary logics would be (for SSL, winbind checking, dependencies, etc.) for this to work. I'll leave all of this up to sunpoet@ to decide. How-To-Repeat: Building the port without NTLM support, then do curl -V and look at the Features list; NTLM support will be shown.
Responsible Changed From-To: freebsd-ports-bugs->sunpoet Over to maintainer (via the GNATS Auto Assign Tool)
Author: sunpoet Date: Sun Feb 23 15:20:40 2014 New Revision: 345728 URL: http://svnweb.freebsd.org/changeset/ports/345728 QAT: https://qat.redports.org/buildarchive/r345728/ Log: - Remove no-op NTLM option PR: ports/186902 Submitted by: Jeremy Chadwick <jdc@koitsu.org> Modified: head/ftp/curl/Makefile Modified: head/ftp/curl/Makefile ============================================================================== --- head/ftp/curl/Makefile Sun Feb 23 15:15:00 2014 (r345727) +++ head/ftp/curl/Makefile Sun Feb 23 15:20:40 2014 (r345728) @@ -13,7 +13,7 @@ COMMENT?= Non-interactive tool to get fi LICENSE= MIT -OPTIONS_DEFINE= CA_BUNDLE COOKIES CURL_DEBUG DEBUG DOCS EXAMPLES GSSAPI IDN IPV6 LDAP LDAPS LIBSSH2 NTLM PROXY RTMP SPNEGO TLS_SRP +OPTIONS_DEFINE= CA_BUNDLE COOKIES CURL_DEBUG DEBUG DOCS EXAMPLES GSSAPI IDN IPV6 LDAP LDAPS LIBSSH2 PROXY RTMP SPNEGO TLS_SRP OPTIONS_RADIO= RESOLV SSL OPTIONS_RADIO_RESOLV= CARES THREADED_RESOLVER OPTIONS_RADIO_SSL= CYASSL GNUTLS NSS OPENSSL POLARSSL @@ -92,8 +92,6 @@ LIBSSH2_LIB_DEPENDS= libssh2.so:${PORTSD NSS_CONFIGURE_OFF= --without-nss NSS_CONFIGURE_ON= --with-nss=${LOCALBASE} NSS_LIB_DEPENDS= libnss3.so:${PORTSDIR}/security/nss -NTLM_CONFIGURE_OFF= --disable-ntlm -NTLM_CONFIGURE_ON= --enable-ntlm OPENSSL_CONFIGURE_OFF= --without-ssl OPENSSL_CONFIGURE_ON= --with-ssl=${OPENSSLBASE} OPENSSL_CPPFLAGS= -I${OPENSSLINC} @@ -138,10 +136,6 @@ IGNORE= only supports LDAPS with SSL IGNORE= only supports LIBSSH2 with OpenSSL .endif -.if ${PORT_OPTIONS:MNTLM} && !${PORT_OPTIONS:MCYASSL} && !${PORT_OPTIONS:MGNUTLS} && !${PORT_OPTIONS:MNSS} && !${PORT_OPTIONS:MOPENSSL} && !${PORT_OPTIONS:MPOLARSSL} -IGNORE= only supports NTLM with SSL -.endif - post-patch: @${REINPLACE_CMD} -e 's|\(flags_dbg_off=\)".*"|\1""|; s|\(flags_opt_off=\)".*"|\1""|' ${WRKSRC}/configure @${REINPLACE_CMD} -e '/^SUBDIRS = / s|$$| docs|; /^DIST_SUBDIRS = / s| docs||; /cd docs &&/d' ${WRKSRC}/Makefile.in _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!