Bug 187213 - Build failure for games/ggz-client-libs without NLS
Summary: Build failure for games/ggz-client-libs without NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-03 03:20 UTC by Kevin Zheng
Modified: 2014-03-03 15:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2014-03-03 03:20:00 UTC
Poudriere fails to build games/ggz-client-libs when the NLS option is unset:

checking for iconv... yes
checking for iconv declaration... 
         extern size_t iconv (iconv_t cd, const char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft);
checking for gettext in -lintl... no
checking for gettext... no
checking for ngettext... no
checking libintl.h usability... no
checking libintl.h presence... no
checking for libintl.h... no
checking locale.h usability... yes
checking locale.h presence... yes
checking for locale.h... yes
Internationalization tools missing.
configure: error: Internationalization tools missing.
===>  Script "configure" failed unexpectedly.

Fix: 

Unconditionally install with NLS enabled, or find a configure flag that will disable it.
How-To-Repeat: Run a clean room build of games/ggz-client-libs without NLS set.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-03 03:20:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-03-03 15:44:21 UTC
Author: makc
Date: Mon Mar  3 15:44:12 2014
New Revision: 346922
URL: http://svnweb.freebsd.org/changeset/ports/346922
QAT: https://qat.redports.org/buildarchive/r346922/

Log:
  games/ggz-* ports:
  - Fix build without NLS option after r344109
  
  PR:		ports/187213
  Reported by:	Kevin Zheng <kevinz5000@gmail.com>

Modified:
  head/games/ggz-client-libs/Makefile
  head/games/ggz-gtk-client/Makefile
  head/games/ggz-gtk-games/Makefile
  head/games/ggz-txt-client/Makefile

Modified: head/games/ggz-client-libs/Makefile
==============================================================================
--- head/games/ggz-client-libs/Makefile	Mon Mar  3 15:43:15 2014	(r346921)
+++ head/games/ggz-client-libs/Makefile	Mon Mar  3 15:44:12 2014	(r346922)
@@ -26,7 +26,7 @@ OPTIONS_DEFINE=	NLS
 OPTIONS_SUB=	yes
 
 NLS_USES=	gettext
-NLS_CONFIGURE_ARGS=	--disable-nls
+NLS_CONFIGURE_OFF=	--disable-nls
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|libggz.la|libggz.so|g' ${WRKSRC}/configure

Modified: head/games/ggz-gtk-client/Makefile
==============================================================================
--- head/games/ggz-gtk-client/Makefile	Mon Mar  3 15:43:15 2014	(r346921)
+++ head/games/ggz-gtk-client/Makefile	Mon Mar  3 15:44:12 2014	(r346922)
@@ -25,7 +25,7 @@ OPTIONS_DEFINE=	NLS
 OPTIONS_SUB=	yes
 
 NLS_USES=	gettext
-NLS_CONFIGURE_ARGS=	--disable-nls
+NLS_CONFIGURE_OFF=	--disable-nls
 
 .include "${.CURDIR}/../libggz/bsd.ggz.mk"
 .include <bsd.port.mk>

Modified: head/games/ggz-gtk-games/Makefile
==============================================================================
--- head/games/ggz-gtk-games/Makefile	Mon Mar  3 15:43:15 2014	(r346921)
+++ head/games/ggz-gtk-games/Makefile	Mon Mar  3 15:44:12 2014	(r346922)
@@ -26,7 +26,7 @@ OPTIONS_DEFINE=	NLS
 OPTIONS_SUB=	yes
 
 NLS_USES=	gettext
-NLS_CONFIGURE_ARGS=	--disable-nls
+NLS_CONFIGURE_OFF=	--disable-nls
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|_LDADD =|_LDADD = -lggzcore|' \

Modified: head/games/ggz-txt-client/Makefile
==============================================================================
--- head/games/ggz-txt-client/Makefile	Mon Mar  3 15:43:15 2014	(r346921)
+++ head/games/ggz-txt-client/Makefile	Mon Mar  3 15:44:12 2014	(r346922)
@@ -23,7 +23,7 @@ OPTIONS_DEFINE=	NLS
 OPTIONS_SUB=	yes
 
 NLS_USES=	gettext
-NLS_CONFIGURE_ARGS=	--disable-nls
+NLS_CONFIGURE_OFF=	--disable-nls
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|_LDADD =|_LDADD = $$(LIB_GGZCORE)|' \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Max Brazhnikov freebsd_committer freebsd_triage 2014-03-03 15:45:25 UTC
State Changed
From-To: open->closed

Should be fixed in r346922. Thanks for report!