Simple change, just add info on starting slim on startup to manpage rather than fobbing user off! Fix: -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.--yVERDV0braO4bn8SkuaHdXqCsb0j3Odao7yEsE3pN1z5Tuwk Content-Type: text/plain; name="patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="patch.txt" Index: files/patch-slim.1 =================================================================== --- files/patch-slim.1 (revision 0) +++ files/patch-slim.1 (working copy) @@ -0,0 +1,12 @@ +--- slim.1.orig 2014-03-10 21:18:36.740597788 +0000 ++++ slim.1 2014-03-10 21:22:07.373025770 +0000 +@@ -42,6 +42,9 @@ + .SH STARTING SLIM AT BOOT + Please refer to documentation of your Operating System to make \fBslim\fP + automatically startup after the system boots. ++.PP ++For \fBFreeBSD\fP, you should add the line slim_enable=yes to /etc/rc.conf ++to make \fBslim\fP start on boot. + .SH CONFIGURATION + Global configuration is stored in the /etc/slim.conf file. See the comments + inside the file for a detailed explanation of the \fIoptions\fP. Property changes on: files/patch-slim.1 ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Added: svn:keywords ## -0,0 +1 ## +FreeBSD=%H \ No newline at end of property
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Maintainer of x11/slim, Please note that PR ports/187431 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187431 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
Responsible Changed From-To: freebsd-ports-bugs->crees I'll take it.
I've tested the patch and it works well. But I have an idea: shall we put it in pkg-message also? -- Cheers, Henry
State Changed From-To: feedback->open Great idea! Is the patch at http://www.bayofrum.net/~crees/patches/slim-pkg-message-too.diff OK?
This patch looks good. I've spotted that we have /etc/slim.conf in the man page. Meanwhile, let's patch that to /usr/local/etc/slim.conf. Please commit that, and bump the port version if necessary. Thanks! -- Cheers, Henry
Author: crees Date: Wed Mar 26 21:18:57 2014 New Revision: 349295 URL: http://svnweb.freebsd.org/changeset/ports/349295 QAT: https://qat.redports.org/buildarchive/r349295/ Log: Modify manpage for FreeBSD-specific information. Add rc note to pkg-message PR: ports/187431 Submitted by: Henry Hu <henry.hu.sh@gmail.com> (maintainer) Added: head/x11/slim/files/patch-slim.1 (contents, props changed) Modified: head/x11/slim/Makefile head/x11/slim/files/pkg-message.in Modified: head/x11/slim/Makefile ============================================================================== --- head/x11/slim/Makefile Wed Mar 26 21:11:12 2014 (r349294) +++ head/x11/slim/Makefile Wed Mar 26 21:18:57 2014 (r349295) @@ -3,6 +3,7 @@ PORTNAME= slim PORTVERSION= 1.3.6 +PORTREVISION= 1 CATEGORIES= x11 MASTER_SITES= ftp://ftp.berlios.de/pub/slim/ \ SF/slim.berlios @@ -49,6 +50,8 @@ post-patch: @${CP} ${WRKSRC}/slim.conf ${WRKSRC}/slim.conf.sample @${REINPLACE_CMD} -e 's|%%LOCALBASE%%|${LOCALBASE}|g' \ ${WRKSRC}/slim.conf.sample + @${REINPLACE_CMD} -e 's,/etc/slim.conf,${PREFIX}&,' \ + ${WRKSRC}/slim.1 post-install: . if ${PORT_OPTIONS:MPAM} Added: head/x11/slim/files/patch-slim.1 ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/x11/slim/files/patch-slim.1 Wed Mar 26 21:18:57 2014 (r349295) @@ -0,0 +1,14 @@ +$FreeBSD$ + +--- slim.1.orig 2014-03-10 21:18:36.740597788 +0000 ++++ slim.1 2014-03-10 21:22:07.373025770 +0000 +@@ -42,6 +42,9 @@ + .SH STARTING SLIM AT BOOT + Please refer to documentation of your Operating System to make \fBslim\fP + automatically startup after the system boots. ++.PP ++For \fBFreeBSD\fP, you should add the line slim_enable=yes to /etc/rc.conf ++to make \fBslim\fP start on boot. + .SH CONFIGURATION + Global configuration is stored in the /etc/slim.conf file. See the comments + inside the file for a detailed explanation of the \fIoptions\fP. Modified: head/x11/slim/files/pkg-message.in ============================================================================== --- head/x11/slim/files/pkg-message.in Wed Mar 26 21:11:12 2014 (r349294) +++ head/x11/slim/files/pkg-message.in Wed Mar 26 21:18:57 2014 (r349295) @@ -3,4 +3,10 @@ Thanks to Nikos Ntarmos, it is now possible to start slim from /etc/ttys. Please see %%PREFIX%%/etc/rc.d/slim for instructions on how to do that. +Alternatively, just put + +slim_enable=yes + +into /etc/rc.conf + ************************************************************************* _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!