Bug 187433 - net-mgmt/mk-livestatus fix to compile on FreeBSD 10.0
Summary: net-mgmt/mk-livestatus fix to compile on FreeBSD 10.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Olli Hauer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-10 22:40 UTC by Daniel Siechniewicz
Modified: 2014-03-16 21:36 UTC (History)
0 users

See Also:


Attachments
file.diff (630 bytes, patch)
2014-03-10 22:40 UTC, Daniel Siechniewicz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Siechniewicz 2014-03-10 22:40:00 UTC
net-mgmt/mk-livestatus wouldn't compile on FreeBSD 10.0 amd64 (compilation for nagios4) with the following error:

LogCache.cc:71:5: error: use of undeclared identifier 'pthread_mutex_init'
    pthread_mutex_init(&_lock, 0);
    ^
LogCache.cc:87:5: error: use of undeclared identifier 'pthread_mutex_destroy'
    pthread_mutex_destroy(&_lock);
    ^
LogCache.cc:92:5: error: use of undeclared identifier 'pthread_mutex_lock'
    pthread_mutex_lock(&_lock);
    ^
LogCache.cc:97:5: error: use of undeclared identifier 'pthread_mutex_unlock'
    pthread_mutex_unlock(&_lock);
    ^
1 warning and 4 errors generated.
gmake[3]: *** [livestatus_so-LogCache.o] Error 1
gmake[3]: Leaving directory `/wrkdirs/usr/ports/net-mgmt/mk-livestatus/work/mk-livestatus-1.2.4/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/wrkdirs/usr/ports/net-mgmt/mk-livestatus/work/mk-livestatus-1.2.4'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/wrkdirs/usr/ports/net-mgmt/mk-livestatus/work/mk-livestatus-1.2.4'
*** Error code 1

Stop.
make: stopped in /usr/ports/net-mgmt/mk-livestatus

Fix: Please see attached port patch. All it does is include pthread in ./src/LogCache.cc . This causes the port to compile. Also tested successfully on redports: 

https://redports.org/buildarchive/20140310170910-94842/
https://redports.org/buildarchive/20140310200429-12536/



Patch attached with submission follows:
How-To-Repeat: Attempt to build the port (tested with Nagios 4 option chosen) on FreeBSD 10.0 amd64
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-10 22:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ohauer

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-03-16 21:23:10 UTC
Author: ohauer
Date: Sun Mar 16 21:23:06 2014
New Revision: 348429
URL: http://svnweb.freebsd.org/changeset/ports/348429
QAT: https://qat.redports.org/buildarchive/r348429/

Log:
  - fix build on FreeBSD 10
  - bump PORTREVISION
  
  PR:		ports/187433
  Submitted by:	Daniel Siechniewicz <daniel@nulldowntime.com>

Added:
  head/net-mgmt/mk-livestatus/files/patch-src__LogCache.cc   (contents, props changed)
Modified:
  head/net-mgmt/mk-livestatus/Makefile

Modified: head/net-mgmt/mk-livestatus/Makefile
==============================================================================
--- head/net-mgmt/mk-livestatus/Makefile	Sun Mar 16 21:17:47 2014	(r348428)
+++ head/net-mgmt/mk-livestatus/Makefile	Sun Mar 16 21:23:06 2014	(r348429)
@@ -3,6 +3,7 @@
 
 PORTNAME=	mk-livestatus
 PORTVERSION=	1.2.4
+PORTREVISION=	1
 CATEGORIES=	net-mgmt
 MASTER_SITES=	http://mathias-kettner.de/download/ \
 		LOCAL/ohauer

Added: head/net-mgmt/mk-livestatus/files/patch-src__LogCache.cc
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/net-mgmt/mk-livestatus/files/patch-src__LogCache.cc	Sun Mar 16 21:23:06 2014	(r348429)
@@ -0,0 +1,13 @@
+PR ports/187433: fix build on FreeBSD 10 
+========================================
+
+--- ./src/LogCache.cc.orig	2014-03-16 19:32:30.000000000 +0100
++++ ./src/LogCache.cc	2014-03-16 19:33:20.000000000 +0100
+@@ -25,6 +25,7 @@
+ #include <time.h>
+ #include <sys/types.h>
+ #include <dirent.h>
++#include <pthread.h>
+ #include <unistd.h>
+ #include <stddef.h>
+ #include <stdarg.h>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Olli Hauer freebsd_committer freebsd_triage 2014-03-16 21:35:13 UTC
State Changed
From-To: open->closed

Committed, 
Thanks!