Bug fix release. Fix: Patch attached with submission follows:
Maintainer of lang/nawk, Please note that PR ports/187543 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187543 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->pawel I'll take it.
Build fails on 8.x and 9.x: https://redports.org/buildarchive/20140330115200-40569/
El 30/03/2014 07:08, PaweÅ PÄkala escribió: > Build fails on 8.x and 9.x: > > https://redports.org/buildarchive/20140330115200-40569/ > It is very probably a byacc issue. Unfortunately I am not using FreeBSD 9 or 8 anymore, and those versions are likely to need the nawk update more that the recent releases. Thank you, Pedro.
I'm putting the listed maintainer back in CC. I'm looking at the commit history of nawk and it's very curious. Pedro has been submitting PRs for nawk since at least 2007. Then on 18 Feb 2009, out of the clear blue, tabthorpe assigns maintainership to Yoshihiro Ota with no PR. Since that time, Yoshihiro Ota has never submitted a PR himself, but at 7 least PRs had to go through him (3 of which timed out). So my question is: Why did Yoshihiro Ota ask to be maintainer? From what I've seen, either it should be reset to ports@, or Pedro himself should be the maintainer. Back on this port -- the logs are gone. I guess I should take a look a this unless Pawel still intends to do something with it. (I suspect it can be built without patches too)
Feel free to take over John. I meant to close this bug due to no prospects of submitter or maintainer providing working patch.
Created attachment 149169 [details] Alternative nawk upgrade patch This builds on FreeBSD 8.4, 9.1 and 10
(In reply to Pawel Pekala from comment #7) > Feel free to take over John. I meant to close this bug due to > no prospects of submitter or maintainer providing working patch. Okay, done. I put you in CC in case you want to keep watching, but feel free to punch out.
(In reply to John Marino from comment #8) > Created attachment 149169 [details] > Alternative nawk upgrade patch > > This builds on FreeBSD 8.4, 9.1 and 10 Pedro, two questions: 1) Do you have any issue with the update? I only needed to patch the makefile. The base awk, which uses the same tarball, has two modifications: - better random number generator (submitted upstream) - A local modification for regional collate support I don't think either are required for a ports build of awk. 2) Do you want to be the maintainer? If you say no, I am very tempted to reset the port to "ports@FreeBSD.org". John
There was a time when volunteers were asked a while ago. As I don't actively use nawk on FreeBSD, if there is a better maintainer, I'm happy to transfer ownership. Best regards, Hiro
Hi Hiro, We do appreciate the effort. It's just that in this case, you haven't been actively maintaining the port. As you can see, the last update is from 2012 and it hasn't been applied -- and it was submitted by someone else Some of the PRs, such as this one, weren't answered in a timely fashion, forcing another maintainer to commit the fix without approval anyway. Under those circumstances, it better if there is no maintainer at all. My plan is to apply this updated patch and reset the port to "no maintainer" later today. If Pedro would like to be the maintainer, then he can tell me before then.
A commit references this bug: Author: marino Date: Mon Nov 10 19:18:51 UTC 2014 New revision: 372409 URL: https://svnweb.freebsd.org/changeset/ports/372409 Log: lang/nawk: Upgrade version 20110810 => 20121220 While here, set the DIST_SUBDIR to something unique since the distfile has the same name between versions. Also reset maintainship as Hiro doesn't use nawk on FreeBSD and updates are infrequent. PR: 187543 Submitted by: Pedro Giffuni Tweaks by: marino@ Changes: head/lang/nawk/Makefile head/lang/nawk/distinfo head/lang/nawk/files/patch-awk.h head/lang/nawk/files/patch-lex.c head/lang/nawk/files/patch-main.c head/lang/nawk/files/patch-makefile head/lang/nawk/files/patch-proto.h head/lang/nawk/files/patch-run.c head/lang/nawk/files/patch-tran.c
This PR is complete!
Hello; Sorry for the late rely as this was under my older (now dead) email address. (In reply to John Marino from comment #10) > (In reply to John Marino from comment #8) > > Created attachment 149169 [details] > > Alternative nawk upgrade patch > > > > This builds on FreeBSD 8.4, 9.1 and 10 > > Pedro, two questions: > > 1) Do you have any issue with the update? I only needed to patch the > makefile. The base awk, which uses the same tarball, has two modifications: > - better random number generator (submitted upstream) > - A local modification for regional collate support > > I don't think either are required for a ports build of awk. > The local modification for internationalization was rather valuable. It was never accepted upstream so we don't carry it in the base version. I guess it would have been a good reason to use the port instead of hawk from base. > 2) Do you want to be the maintainer? > Not really, thanks :). > If you say no, I am very tempted to reset the port to "ports@FreeBSD.org". > > John