Bug 187656 - Rename request of converters/igbinary
Summary: Rename request of converters/igbinary
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 11:50 UTC by Daniel Ylitalo
Modified: 2014-06-05 10:45 UTC (History)
2 users (show)

See Also:

Attachments
converters-igbinary.diff (710 bytes, patch)
2014-06-05 10:17 UTC, Bartek Rutkowski 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Ylitalo 2014-03-17 11:50:00 UTC 
All php pecl modules (or most of them atleast) are prefixed with pecl-

I suggest renaming converters/igbinary to converters/pecl-igbinary to keep some consistency for pecl modules
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-17 11:50:03 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-17 11:50:03 UTC 
Maintainer of converters/igbinary,

Please note that PR ports/187656 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187656

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Bartek Rutkowski freebsd_committer freebsd_triage 2014-06-05 10:17:39 UTC 
Created attachment 143398 [details]
converters-igbinary.diff
Comment 4 Bartek Rutkowski freebsd_committer freebsd_triage 2014-06-05 10:17:58 UTC 
- Change the package name by adding PKGNAMESUFFIX in line with other similar ports
- Pet portlint

The build log against the attached diff file:

http://pd.valinor.palantiri.org:8080/latest-per-pkg/pecl-igbinary/1.1.1/
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-06-05 10:37:05 UTC 
A commit references this bug:

Author: marino
Date: Thu Jun  5 10:36:17 UTC 2014
New revision: 356625
URL: http://svnweb.freebsd.org/changeset/ports/356625

Log:
  converters/igbinary: Add pecl- prefix for consistency

  While here, update the WWW link.

  PR:		ports/187656
  Submitted by:	daniel
  Tested by:	robak
  approved by:	maintainer timeout (3 months)

Changes:
  head/converters/igbinary/Makefile
  head/converters/igbinary/pkg-descr
Comment 6 John Marino freebsd_committer freebsd_triage 2014-06-05 10:45:41 UTC 
committed as suggested, thanks!