Bug 187687 - [MAINTAINER] multimedia/transcode: Use OPTIONS helpers
Summary: [MAINTAINER] multimedia/transcode: Use OPTIONS helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 00:40 UTC by Naram Qashat
Modified: 2014-08-02 12:37 UTC (History)
0 users

See Also:

Attachments
transcode-1.1.7.patch (7.55 KB, patch)
2014-03-18 00:40 UTC, Naram Qashat 		no flags Details | Diff
transcode-1.1.7.patch (7.80 KB, patch)
2014-07-16 04:31 UTC, Naram Qashat 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2014-03-18 00:40:00 UTC 
- Use OPTIONS helpers

Generated with FreeBSD Port Tools 1.00.2014.03.11 (mode: change, diff: SVN)
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2014-03-28 00:22:47 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jhale

I'll take it.
Comment 2 Naram Qashat 2014-04-07 12:34:33 UTC 
I realized there was one thing I didn't do when I submitted this PR, and that is 
bumping the PORTREVISION. This should probably be done because of the mjpegtools 
library bump.

Thanks,
Naram Qashat
Comment 3 Ivan Klymenko 2014-04-19 13:11:54 UTC 
Hi.

Please correct the error at the same time when using option MJPEGTOOLS

--- Makefile.orig	2014-04-18 15:39:00.000000000 +0300
+++ Makefile	2014-04-18 15:39:08.000000000 +0300
@@ -165,7 +165,7 @@
 .endif
 
 .if ${PORT_OPTIONS:MMJPEGTOOLS}
-LIB_DEPENDS+=	liblavjpeg-2.0.so:${PORTSDIR}/multimedia/mjpegtools
+LIB_DEPENDS+=	liblavjpeg-2.1.so:${PORTSDIR}/multimedia/mjpegtools
 CONFIGURE_ARGS+=	--enable-mjpegtools
 .else
 CONFIGURE_ARGS+=	--disable-mjpegtools
Comment 4 Naram Qashat 2014-04-19 15:30:33 UTC 
On 04/19/14 08:11, Ivan Klymenko wrote:
> Hi.
>
> Please correct the error at the same time when using option MJPEGTOOLS
>
> --- Makefile.orig	2014-04-18 15:39:00.000000000 +0300
> +++ Makefile	2014-04-18 15:39:08.000000000 +0300
> @@ -165,7 +165,7 @@
>   .endif
>
>   .if ${PORT_OPTIONS:MMJPEGTOOLS}
> -LIB_DEPENDS+=	liblavjpeg-2.0.so:${PORTSDIR}/multimedia/mjpegtools
> +LIB_DEPENDS+=	liblavjpeg-2.1.so:${PORTSDIR}/multimedia/mjpegtools
>   CONFIGURE_ARGS+=	--enable-mjpegtools
>   .else
>   CONFIGURE_ARGS+=	--disable-mjpegtools

This is already part of my patch. The above is not needed.

Thanks,
Naram Qashat
Comment 5 Ivan Klymenko 2014-04-20 08:55:15 UTC 
=D0=92 Sat, 19 Apr 2014 10:30:33 -0400
Naram Qashat <cyberbotx@cyberbotx.com> =D0=BF=D0=B8=D1=88=D0=B5=D1=82:

> On 04/19/14 08:11, Ivan Klymenko wrote:
> > Hi.
> >
> > Please correct the error at the same time when using option
> > MJPEGTOOLS
> >
> > --- Makefile.orig	2014-04-18 15:39:00.000000000 +0300
> > +++ Makefile	2014-04-18 15:39:08.000000000 +0300
> > @@ -165,7 +165,7 @@
> >   .endif
> >
> >   .if ${PORT_OPTIONS:MMJPEGTOOLS}
> > -LIB_DEPENDS+=3D
> > liblavjpeg-2.0.so:${PORTSDIR}/multimedia/mjpegtools
> > +LIB_DEPENDS+=3D
> > liblavjpeg-2.1.so:${PORTSDIR}/multimedia/mjpegtools
> > CONFIGURE_ARGS+=3D	--enable-mjpegtools .else
> > CONFIGURE_ARGS+=3D	--disable-mjpegtools
>=20
> This is already part of my patch. The above is not needed.
>=20
> Thanks,
> Naram Qashat

Ok.
Thanks.
Comment 6 Naram Qashat 2014-07-16 04:31:41 UTC 
Created attachment 144712 [details]
transcode-1.1.7.patch

I figure since the port has been updated a few times since I submitted this report, I may as well update the patch to match what is currently in the ports tree.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-08-02 12:35:51 UTC 
A commit references this bug:

Author: jhale
Date: Sat Aug  2 12:35:29 UTC 2014
New revision: 363809
URL: http://svnweb.freebsd.org/changeset/ports/363809

Log:
  - Convert to options helpers
  - Standardize a few option names
  - Bump PORTREVISON since option names have changed

  PR:		187687
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

Changes:
  head/multimedia/transcode/Makefile
Comment 8 Jason E. Hale freebsd_committer freebsd_triage 2014-08-02 12:37:57 UTC 
Committed, thanks!  Sorry I took so long with this.