Bug 187732 - math/reduce compilation still needs MAKE_JOBS_UNSAFE=yes
Summary: math/reduce compilation still needs MAKE_JOBS_UNSAFE=yes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-19 11:20 UTC by Mamoru IWAKI
Modified: 2014-03-28 00:20 UTC (History)
0 users

See Also:


Attachments
file.diff (235 bytes, patch)
2014-03-19 11:20 UTC, Mamoru IWAKI
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mamoru IWAKI 2014-03-19 11:20:01 UTC
Re: # $FreeBSD: head/math/reduce/Makefile 344974 2014-02-18 22:16:33Z stephen $

Compilation of math/reduce has failed these days.  I'm using a multicore machine as follows: 

   FreeBSD/SMP: Multiprocessor System Detected: 8 CPUs
   FreeBSD/SMP: 1 package(s) x 4 core(s) x 2 SMT threads

I'm not sure but it seems to require MAKE_JOBS_UNSAFE=yes in Makefile.  


oot@:/usr/ports/math/reduce # make
===>  License BSD accepted by the user
===>   reduce-20110414 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by reduce-20110414 for building
===>  Extracting for reduce-20110414
=> SHA256 Checksum OK for reduce-src-20110414.tar.bz2.

(snip-snip-snip)

mv -f .deps/u01.Tpo .deps/u01.Po
cc -DHAVE_CONFIG_H -I. -I/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase  -Dfontsdir=reduce.fonts -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/freetype2 -D_THREAD_SAFE -I/usr/local/include   -DBINDIR=/usr/local/bin -DPKGDATADIR=/usr/local/share/reduce  -O2 -pipe -fno-strict-aliasing -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/freetype2 -D_THREAD_SAFE -I/usr/local/include -fno-strict-aliasing -O2 -Wall   -MT u06.o -MD -MP -MF .deps/u06.Tpo -c -o u06.o `test -f '/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/../../cslbuild/generated-c/u06.c' || echo '/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/'`/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/../../cslbuild/generated-c/u06.c
cc -DHAVE_CONFIG_H -I. -I/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase  -Dfontsdir=reduce.fonts -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/freetype2 -D_THREAD_SAFE -I/usr/local/include   -DBINDIR=/usr/local/bin -DPKGDATADIR=/usr/local/share/reduce  -O2 -pipe -fno-strict-aliasing -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/freetype2 -D_THREAD_SAFE -I/usr/local/include -fno-strict-aliasing -O2 -Wall   -MT u07.o -MD -MP -MF .deps/u07.Tpo -c -o u07.o `test -f '/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/../../cslbuild/generated-c/u07.c' || echo '/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/'`/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/../../cslbuild/generated-c/u07.c
mv -f .deps/u04.Tpo .deps/u04.Po
/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/../../cslbuild/generated-c/u06.c:3131:40: error: cc -DHAVE_CONFIG_H -I. -I/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase  -Dfontsdir=reduce.fonts -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/freetype2 -D_THREAD_SAFE -I/usr/local/include   -DBINDIR=/usr/local/bin -DPKGDATADIR=/usr/local/share/reduce  -O2 -pipe -fno-strict-aliasing -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/freetype2 -D_THREAD_SAFE -I/usr/local/include -fno-strict-aliasing -O2 -Wall   -MT u08.o -MD -MP -MF .deps/u08.Tpo -c -o u08.o `test -f '/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/../../cslbuild/generated-c/u08.c' || echo '/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/'`/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/../../cslbuild/generated-c/u08.c
expected
      expression
    v118 = (*qfn2(fn))(qenv(fn), v119,
                                       ^
/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/../../cslbuild/generated-c/u06.c:3131:40: error: expected '}'
/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/../../cslbuild/generated-c/u06.c:3095:1: note: to match this '{'
{
^
/mnt2/usr/ports/math/reduce/work/reduce-20110414/csl/cslbase/../../cslbuild/generated-c/u06.c:3121:27: error: use of
      undeclared label 'v42'
    if (v118 == nil) goto v42;
                          ^
3 errors generated.
gmake[4]: *** [u06.o] Error 1
gmake[4]: *** Waiting for unfinished jobs....
mv -f .deps/u07.Tpo .deps/u07.Po
mv -f .deps/u05.Tpo .deps/u05.Po
mv -f .deps/u08.Tpo .deps/u08.Po
gmake[3]: *** [all] Error 2
gmake[2]: *** [all] Error 2
gmake[1]: Leaving directory `/mnt2/usr/ports/math/reduce/work/reduce-20110414'



NOTE: /usr/ports is a symlink to /mnt2/usr/ports in my environment

Fix: I made this patch to inhibit the number of jobs.  It should get right compilation order back as expected.  It works for me anyway.  


--- Makefile.orig	2014-03-12 20:32:27.000000000 +0900
+++ Makefile	2014-03-19 19:30:39.000000000 +0900
@@ -28,6 +28,8 @@
 CONFIGURE_ARGS=	--with-csl
 ALL_TARGET=
 
+MAKE_JOBS_UNSAFE=	yes
+
 .include <bsd.port.pre.mk>
 
 HMAN1=	redcsl.1


Patch attached with submission follows:
How-To-Repeat: Simply try compiling the ports on a many core machine.

cd /usr/port/math/reduce
make
(No option is changed)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-19 11:20:05 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-19 11:20:05 UTC
Maintainer of math/reduce,

Please note that PR ports/187732 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187732

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Pedro F. Giffuni 2014-03-22 21:03:48 UTC
Fix looks good to me.

Approved. Thank you!
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2014-03-23 00:03:44 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Jason E. Hale freebsd_committer freebsd_triage 2014-03-27 23:37:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jhale

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2014-03-28 00:17:58 UTC
Author: jhale
Date: Fri Mar 28 00:17:56 2014
New Revision: 349382
URL: http://svnweb.freebsd.org/changeset/ports/349382
QAT: https://qat.redports.org/buildarchive/r349382/

Log:
  - Mark MAKE_JOBS_UNSAFE (build fails with MAKE_JOBS_NUMBER=8)
  
  While here:
  - USE_BZIP2 -> USES
  - Disambiguate BSD license (BSD2CLAUSE)
  
  PR:		ports/187732
  Submitted by:	Mamoru Iwaki <1wkmmr@gmail.com>
  Approved by:	Pedro Giffuni <giffunip@tutopia.com> (maintainer)

Modified:
  head/math/reduce/Makefile

Modified: head/math/reduce/Makefile
==============================================================================
--- head/math/reduce/Makefile	Fri Mar 28 00:12:40 2014	(r349381)
+++ head/math/reduce/Makefile	Fri Mar 28 00:17:56 2014	(r349382)
@@ -10,15 +10,14 @@ DISTNAME=	${PORTNAME}-src-${PORTVERSION}
 MAINTAINER=	giffunip@tutopia.com
 COMMENT=	Portable general-purpose computer algebra system (CSL version)
 
-LICENSE=	BSD
+LICENSE=	BSD2CLAUSE
 
 RUN_DEPENDS=	gnuplot:${PORTSDIR}/math/gnuplot
 LIB_DEPENDS=	libjpeg.so:${PORTSDIR}/graphics/jpeg \
 		libpng15.so:${PORTSDIR}/graphics/png \
 		libtiff.so:${PORTSDIR}/graphics/tiff
 
-USE_BZIP2=	yes
-USES=		gmake
+USES=		gmake tar:bzip2
 USE_XORG=	xext x11 xft
 USE_GNOME=	lthack ltverhack
 
@@ -28,6 +27,8 @@ HAS_CONFIGURE=	yes
 CONFIGURE_ARGS=	--with-csl
 ALL_TARGET=
 
+MAKE_JOBS_UNSAFE=	yes
+
 .include <bsd.port.pre.mk>
 
 HMAN1=	redcsl.1
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Jason E. Hale freebsd_committer freebsd_triage 2014-03-28 00:18:18 UTC
State Changed
From-To: open->closed

Committed. Thanks!