Bug 187827 - [MAINTAINER] japanese/ja-eblook: Add 'USES=iconv' to unbreak.
Summary: [MAINTAINER] japanese/ja-eblook: Add 'USES=iconv' to unbreak.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-21 20:20 UTC by Yasuhiro Kimura
Modified: 2014-04-21 20:40 UTC (History)
0 users

See Also:


Attachments
ja-eblook-1.6.1.patch (581 bytes, patch)
2014-03-21 20:20 UTC, Yasuhiro Kimura
no flags Details | Diff
patch-ja-eblook (952 bytes, text/plain; charset=Shift_JIS)
2014-04-03 11:51 UTC, Yasuhiro Kimura
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2014-03-21 20:20:00 UTC
	- Add 'USES=iconv' to unbreak.
	- Make PORTDOCS alway install to ${STAGEDIR}${DOCSDIR}.

Generated with FreeBSD Port Tools 1.00.2014.03.21 (mode: change, diff: SVN)
Comment 1 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-04-03 11:51:20 UTC
- Fix CONFIGURE_ARGS properly.
- Set CPPFLAGS and LDFLANGS so iconv header and library are correctly
detected and used when libiconv port is used.
- Bump PORTREVISON because of dependency change.

So please commit attached patch instaed of original one.

Regards.
---
Yasuhiro KIMURA
Comment 2 John Marino freebsd_committer freebsd_triage 2014-04-21 20:22:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marino

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2014-04-21 20:35:05 UTC
Author: marino
Date: Mon Apr 21 19:35:01 2014
New Revision: 351704
URL: http://svnweb.freebsd.org/changeset/ports/351704
QAT: https://qat.redports.org/buildarchive/r351704/

Log:
  japanese/eblook: Apply maintainer patch per PR
  
  The PR claims the port is broken and this patch unbreaks it, but
  portsmon is clean.  In any case, the port builds cleanly in poudriere
  with the patch so I defer to the maintainer.
  
  PR:		ports/187827
  submitted by:	maintainer (Yasuhiro KIMURA)

Modified:
  head/japanese/eblook/Makefile

Modified: head/japanese/eblook/Makefile
==============================================================================
--- head/japanese/eblook/Makefile	Mon Apr 21 19:02:18 2014	(r351703)
+++ head/japanese/eblook/Makefile	Mon Apr 21 19:35:01 2014	(r351704)
@@ -3,7 +3,7 @@
 
 PORTNAME=	eblook
 PORTVERSION=	1.6.1
-PORTREVISION=	7
+PORTREVISION=	8
 CATEGORIES=	japanese textproc
 MASTER_SITES=	http://openlab.ring.gr.jp/edict/eblook/dist/
 DIST_SUBDIR=	eb
@@ -15,9 +15,11 @@ LICENSE=	GPLv2
 
 LIB_DEPENDS=	libeb.so:${PORTSDIR}/japanese/eb
 
+USES=		iconv
 GNU_CONFIGURE=		yes
-CONFIGURE_ARGS=		--with-eb-includes=${PREFIX}/include \
-			--with-eb-libraries=${PREFIX}/lib
+CONFIGURE_ARGS=		--with-eb-conf=${PREFIX}/etc/eb.conf
+CPPFLAGS+=	-I${ICONV_PREFIX}/include
+LDFLAGS+=	-L${ICONV_PREFIX}/lib ${ICONV_LIB}
 
 INFO=		eblook
 PLIST_FILES=	bin/eblook
@@ -28,9 +30,7 @@ OPTIONS_DEFINE=	DOCS
 .include <bsd.port.options.mk>
 
 post-install:
-.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
-.endif
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 John Marino freebsd_committer freebsd_triage 2014-04-21 20:40:14 UTC
State Changed
From-To: open->closed

Committed. Thanks!