Bug 187882 - [PATCH] math/py-networkx: Deprecate easy_install, NOPORTEXAMPLES, License
Summary: [PATCH] math/py-networkx: Deprecate easy_install, NOPORTEXAMPLES, License
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-24 00:00 UTC by Johannes Meixner
Modified: 2014-03-28 19:50 UTC (History)
1 user (show)

See Also:


Attachments
py-networkx-1.8.1.patch (1.08 KB, patch)
2014-03-24 00:00 UTC, Johannes Meixner
no flags Details | Diff
py-networkx-1.8.1.patch (117.42 KB, patch)
2014-03-26 09:05 UTC, Johannes Meixner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Meixner 2014-03-24 00:00:03 UTC
- easy_install must die. Kill with fire.
- Deprecate installation via setup_egg.py over native setup.py with setuptools.
- Add EXAMPLES knob
- Use shebangfix.

Port maintainer (dikshie@sfc.wide.ad.jp) is cc'd.

Generated with FreeBSD Port Tools 1.00.2014.03.22 (mode: change, diff: SVN)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-24 00:00:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->swills

swills@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-24 00:00:08 UTC
Maintainer of math/py-networkx,

Please note that PR ports/187882 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187882

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-24 00:00:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 dikshie 2014-03-24 09:24:13 UTC
the patch looks good for me.  
please go ahead to commit.  

thanks! 

-dikshie-
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2014-03-25 08:34:59 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 6 Johannes Meixner 2014-03-26 09:05:20 UTC
Description:
- Unbreak package build and remove orphans (correct typo: EXAMPLEDIR -> EXAMPLESDIR)

Maintainer and responsible committer (dikshie@sfc.wide.ad.jp; swills@freebsd.org) is cc'd.

Generated with FreeBSD Port Tools 1.00.2014.03.22 (mode: change, diff: SVN)
Comment 7 dikshie 2014-03-26 14:37:36 UTC
the patch looks good to me. =20
please go ahead commit it.=20

-dikshie-

On Mar 26, 2014, at 6:05 PM, Johannes Jost Meixner <xmj@chaot.net> =
wrote:

>=20
> Description:
> - Unbreak package build and remove orphans (correct typo: EXAMPLEDIR =
-> EXAMPLESDIR)
>=20
> Maintainer and responsible committer (dikshie@sfc.wide.ad.jp; =
swills@freebsd.org) is cc'd.
>=20
> Generated with FreeBSD Port Tools 1.00.2014.03.22 (mode: change, diff: =
SVN)
>=20
> <py-networkx-1.8.1.patch>
Comment 8 dfilter service freebsd_committer freebsd_triage 2014-03-28 19:41:56 UTC
Author: swills
Date: Fri Mar 28 19:41:53 2014
New Revision: 349451
URL: http://svnweb.freebsd.org/changeset/ports/349451
QAT: https://qat.redports.org/buildarchive/r349451/

Log:
  - Switch from easy_install to USE_PYDISTUTILS=yes
  - Add EXAMPLES OPTION
  - Use shebangfix
  
  PR:		ports/187882
  Submitted by:	Johannes Jost Meixner <xmj@chaot.net>
  Approved by:	dikshie <dikshie@sfc.wide.ad.jp> (maintainer)

Deleted:
  head/math/py-networkx/pkg-plist
Modified:
  head/math/py-networkx/Makefile

Modified: head/math/py-networkx/Makefile
==============================================================================
--- head/math/py-networkx/Makefile	Fri Mar 28 19:38:04 2014	(r349450)
+++ head/math/py-networkx/Makefile	Fri Mar 28 19:41:53 2014	(r349451)
@@ -9,23 +9,27 @@ MASTER_SITES=	http://networkx.lanl.gov/d
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
 
 MAINTAINER=	dikshie@sfc.wide.ad.jp
-COMMENT=	Tools for complex network
+COMMENT=	Tools for complex networks
+
+LICENSE=	BSD3CLAUSE
 
 USE_PYTHON=	yes
-USE_PYDISTUTILS=easy_install
-PYTHON_PY3K_PLIST_HACK=yes
-PYSETUP=	setup_egg.py
+USE_PYDISTUTILS=	yes
+PYDISTUTILS_AUTOPLIST=	yes
+
 PLIST_SUB+=	PYTHON_MAJOR_VER=${PYTHON_MAJOR_VER}
 
-NO_STAGE=	yes
-post-install:
-.if !defined(NOPORTEXAMPLES)
-	${MKDIR} ${EXAMPLESDIR}
-	cd ${WRKSRC}/examples \
-		&& ${FIND} . -type d -exec ${MKDIR} ${EXAMPLESDIR}/\{} \; \
-		&& ${FIND} . -type f -exec ${INSTALL_DATA} \{} ${EXAMPLESDIR}/\{} \;
-.endif
+OPTIONS_DEFINE=	EXAMPLES
+EXAMPLESDIR=	${PREFIX}/share/doc/${PYTHON_PKGNAMEPREFIX}${PORTNAME}
+PORTEXAMPLES=	*
 
+USES=	shebangfix
+
+.include <bsd.port.options.mk>
+
+post-install:
+	${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
+	cd ${WRKSRC}/examples && ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR}
 	@${CAT} ${PKGMESSAGE}
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 9 Steve Wills freebsd_committer freebsd_triage 2014-03-28 19:42:05 UTC
State Changed
From-To: open->closed

Committed. Thanks!