Bug 188524 - sysutils/grub2 and ZFS: missing feature for read 'com.delphix:hole_birth'
Summary: sysutils/grub2 and ZFS: missing feature for read 'com.delphix:hole_birth'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-12 18:40 UTC by Andrey Zholos
Modified: 2014-07-28 15:40 UTC (History)
1 user (show)

See Also:

Attachments
file.txt (398 bytes, patch)
2014-04-12 18:40 UTC, Andrey Zholos 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Zholos 2014-04-12 18:40:00 UTC 
I am using GRUB to boot the kernel directly from ZFS.

After running zpool upgrade -a recently, GRUB stopped being able to access the
ZFS filesystem.

Fix: Patch to ignore this feature flag attached.

# grub-probe -d /dev/gpt/mypool
zfs

Booting with GRUB also works so far.

However, I'm not certain whether the ZFS reading code in GRUB actually needs to
be updated for this feature flag.


Patch attached with submission follows:
How-To-Repeat: # grub-probe -d /dev/gpt/mypool
missing feature for read 'com.delphix:hole_birth'
missing feature for read 'com.delphix:hole_birth'
missing feature for read 'com.delphix:hole_birth'
missing feature for read 'com.delphix:hole_birth'
grub-probe: error: unknown filesystem.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-27 21:49:58 UTC 
grub2 isn't maintained by anyone, so the patch can go in without approval.
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-07-28 15:18:46 UTC 
A commit references this bug:

Author: marino
Date: Mon Jul 28 15:18:03 UTC 2014
New revision: 363177
URL: http://svnweb.freebsd.org/changeset/ports/363177

Log:
  sysutils/grub2: Fix feature to read 'com.delphix:hole_birth' on ZFS

  Fix for booting kernel directly from ZFS using grub.

  PR:		188524
  Submitted by:	Andrey Zholos

Changes:
  head/sysutils/grub2/Makefile
  head/sysutils/grub2/files/patch-grub-2.00-zfs-feature-flag-support
Comment 3 John Marino freebsd_committer freebsd_triage 2014-07-28 15:40:33 UTC 
Thanks!