Bug 188526 - sysutils/grub2 doesn't compile with freetype2 installed
Summary: sysutils/grub2 doesn't compile with freetype2 installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-12 19:10 UTC by Andrey Zholos
Modified: 2014-04-18 18:10 UTC (History)
0 users

See Also:

Attachments
file.txt (780 bytes, text/plain)
2014-04-12 19:10 UTC, Andrey Zholos 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Zholos 2014-04-12 19:10:00 UTC 
# make -C /usr/ports/sysutils/grub2
..
checking for freetype-config... freetype-config
checking ft2build.h usability... yes
checking ft2build.h presence... yes
checking for ft2build.h... yes
..
util/grub-mkfont.c:42:30: fatal error: freetype/ftsynth.h: No such file or directory

This happens regardless of whether the MKFONT option is enabled.

Fix: Explicit configure argument to prevent building grub-mkfont if MKFONT is not
enabled.

Source patch from upstream to fix the build if MKFONT is enabled:
http://git.savannah.gnu.org/cgit/grub.git/commit/util/grub-mkfont.c?id=fd0df6d098b1e6a4f60275c48a3ec88d15ba1fbb


Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-04-13 00:48:51 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

ports PR.
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-04-18 18:03:10 UTC 
Author: nox
Date: Fri Apr 18 17:03:05 2014
New Revision: 351550
URL: http://svnweb.freebsd.org/changeset/ports/351550
QAT: https://qat.redports.org/buildarchive/r351550/

Log:
  Fix build with MKFONT and without it but with (updated) freetype present.
  
  PR:		ports/187984 [1], ports/188526 [2]
  Submitted by:	Joseph Mingrone <jrm@ftfl.ca> [1]
  Submitted by:	Andrey Zholos <aaz@q-fu.com> [2]

Added:
  head/sysutils/grub2/files/patch-util-grub-mkfont.c   (contents, props changed)
Modified:
  head/sysutils/grub2/Makefile

Modified: head/sysutils/grub2/Makefile
==============================================================================
--- head/sysutils/grub2/Makefile	Fri Apr 18 15:26:03 2014	(r351549)
+++ head/sysutils/grub2/Makefile	Fri Apr 18 17:03:05 2014	(r351550)
@@ -48,7 +48,9 @@ PLIST_SUB+=	EFIEMU=${EFIEMU}
 LIB_DEPENDS+=	libfreetype.so:${PORTSDIR}/print/freetype2
 BUILD_DEPENDS+=	${LOCALBASE}/lib/X11/fonts/dejavu/DejaVuSans.ttf:${PORTSDIR}/x11-fonts/dejavu
 MAN1+=		grub-mkfont.1
+CONFIGURE_ARGS+=	--enable-grub-mkfont
 .else
+CONFIGURE_ARGS+=	--disable-grub-mkfont
 MKFONT=		"@comment "
 .endif
 

Added: head/sysutils/grub2/files/patch-util-grub-mkfont.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/sysutils/grub2/files/patch-util-grub-mkfont.c	Fri Apr 18 17:03:05 2014	(r351550)
@@ -0,0 +1,13 @@
+--- util/grub-mkfont.c.orig
++++ util/grub-mkfont.c
+@@ -39,7 +39,7 @@
+ #include FT_FREETYPE_H
+ #include FT_TRUETYPE_TAGS_H
+ #include FT_TRUETYPE_TABLES_H
+-#include <freetype/ftsynth.h>
++#include FT_SYNTHESIS_H
+ 
+ #undef __FTERRORS_H__
+ #define FT_ERROR_START_LIST   const char *ft_errmsgs[] = { 
+
+
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Juergen Lock freebsd_committer freebsd_triage 2014-04-18 18:03:54 UTC 
State Changed
From-To: open->closed

Committed. Thanks!