Bug 188691 - [NEW PORT] japanese/latex-jlisting: Enhancement of lstlisting environment for handling Japanese text
Summary: [NEW PORT] japanese/latex-jlisting: Enhancement of lstlisting environment for...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-16 14:50 UTC by hiroto.kagotani
Modified: 2014-09-20 15:30 UTC (History)
1 user (show)

See Also:


Attachments
file.shar (2.25 KB, text/plain)
2014-04-16 14:50 UTC, hiroto.kagotani
no flags Details
shar file (2.32 KB, text/plain)
2014-09-02 08:20 UTC, hiroto.kagotani
no flags Details
"poudriere testport -j 100amd64 -o japanese/latex-jlisting" output (17.21 KB, text/plain)
2014-09-02 08:21 UTC, hiroto.kagotani
no flags Details
"portlint -AC" output (173 bytes, text/plain)
2014-09-02 08:21 UTC, hiroto.kagotani
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description hiroto.kagotani 2014-04-16 14:50:02 UTC
jlisting.sty enhances lstlisting environment provided by listings.sty
for handling Japanese text.

Use this package with listings.sty as:
\usepackage{listings,jlisting}

WWW: http://sourceforge.jp/projects/mytexpert/

Fix: Patch attached with submission follows:
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-05 11:05:18 UTC
Is this port still valid after all those latex ports were removed recently?
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-05 11:09:11 UTC
quick review of shar:

use "NO_BUILD=yes" instead of empty "do-build:" target

don't have post-install target with do-install target, just merge them to do-install.

change "EXTRACT_SUFX=	.bz2" to "USES+= tar:bz2"

The post-install target looks very suspicious especially since it will not be run by package (you need a post-install script for that.  But I don't know what it is supposed to do...

So even if the port is still valid, it needs another iteration and poudriere test logs (either "testport" or "bulk -t") would be nice too.
Comment 3 hiroto.kagotani 2014-09-02 08:20:22 UTC
Created attachment 146667 [details]
shar file

Thank you very much for comments.
I updated and cleaned-up the port as the attached new shar file.
I also attach some log files.

Redport log can be found at https://redports.org/buildarchive/20140902081114-24629/

Regards,
Comment 4 hiroto.kagotani 2014-09-02 08:21:19 UTC
Created attachment 146668 [details]
"poudriere testport -j 100amd64 -o japanese/latex-jlisting" output
Comment 5 hiroto.kagotani 2014-09-02 08:21:46 UTC
Created attachment 146669 [details]
"portlint -AC" output
Comment 6 hiroto.kagotani 2014-09-02 08:26:53 UTC
> change "EXTRACT_SUFX=	.bz2" to "USES+= tar:bz2"

That is not the case, because the distfile is not a tar'ed file - 
just a bzipped plain file named jlisting.sty.bz2.

Thanks.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-09-02 14:18:48 UTC
ok, thanks for the update.  I'm moving this to "patch-ready" pool.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-09-20 15:28:17 UTC
A commit references this bug:

Author: marino
Date: Sat Sep 20 15:28:03 UTC 2014
New revision: 368649
URL: http://svnweb.freebsd.org/changeset/ports/368649

Log:
  Add new port japanese/latex-jlisting

  PR:		188691
  Submitted by:	Hiroto Kagotani

  jlisting.sty enhances lstlisting environment provided by listings.sty for
  handling Japanese text.

Changes:
  head/japanese/Makefile
  head/japanese/latex-jlisting/
  head/japanese/latex-jlisting/Makefile
  head/japanese/latex-jlisting/distinfo
  head/japanese/latex-jlisting/pkg-descr
Comment 9 John Marino freebsd_committer freebsd_triage 2014-09-20 15:30:28 UTC
Okay, I made some changes, the most notable one is eliminating the pkg-plist file.  I also stopped using $DISTNAME in the do-install target, which was necessary after removing the DISTNAME and WRKSRC definitions.  There were other minor tweaks done as well, but it passes poudriere cleanly.