Bug 188942 - security/sssd: Remove libldap.so from LIB_DEPENDS, it is already added by USE_OPENLDAP
Summary: security/sssd: Remove libldap.so from LIB_DEPENDS, it is already added by USE...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Craig Rodrigues
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-24 08:40 UTC by Craig Rodrigues
Modified: 2014-04-26 06:25 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Rodrigues freebsd_committer freebsd_triage 2014-04-24 08:40:00 UTC
Do not explicitly add libldap.so to LIB_DEPENDS.
Since USE_OPENLDAP is already defined in this Makefile, bsd.ldap.mk
already adds the dependency to LIB_DEPENDS.

I uncovered this problem when I set WANT_OPENLDAP_SASL in my /etc/make.conf,
and the seurity/sssd was depending on the SASL and non-SASL version
of libldap, when I built my tree with poudriere.

Fix:

--- Makefile.orig       2014-04-24 00:34:04.794966405 -0700
+++ Makefile    2014-04-24 00:34:10.981965774 -0700
@@ -26,7 +26,6 @@
                libnss3.so:${PORTSDIR}/security/nss \
                libsasl2.so:${PORTSDIR}/security/cyrus-sasl2 \
                libkrb5.so:${PORTSDIR}/security/krb5 \
-               libldap.so:${PORTSDIR}/net/openldap24-client \
                libinotify.so:${PORTSDIR}/devel/libinotify
 BUILD_DEPENDS= xmlcatalog:${PORTSDIR}/textproc/libxml2 \
                docbook-xsl>=1:${PORTSDIR}/textproc/docbook-xsl \
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-24 08:40:02 UTC
Maintainer of security/sssd,

Please note that PR ports/188942 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/188942

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-24 08:40:03 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 lukas.slebodnik 2014-04-25 14:59:57 UTC
Thank you very much for the patch.
I agree with you.

Could anyone push this patch?

LS
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2014-04-26 02:22:38 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 dfilter service freebsd_committer freebsd_triage 2014-04-26 05:29:42 UTC
Author: rodrigc (src committer)
Date: Sat Apr 26 04:29:39 2014
New Revision: 352221
URL: http://svnweb.freebsd.org/changeset/ports/352221
QAT: https://qat.redports.org/buildarchive/r352221/

Log:
  Remove libldap.so from LIB_DEPENDS, it is already added by USE_OPENLDAP.
  
  PR:		ports/188942
  Approved by:	Lukas Slebodnik <lukas.slebodnik@intrak.sk> (maintainer)

Modified:
  head/security/sssd/Makefile

Modified: head/security/sssd/Makefile
==============================================================================
--- head/security/sssd/Makefile	Sat Apr 26 02:40:20 2014	(r352220)
+++ head/security/sssd/Makefile	Sat Apr 26 04:29:39 2014	(r352221)
@@ -26,7 +26,6 @@ LIB_DEPENDS=	libpopt.so:${PORTSDIR}/deve
 		libnss3.so:${PORTSDIR}/security/nss \
 		libsasl2.so:${PORTSDIR}/security/cyrus-sasl2 \
 		libkrb5.so:${PORTSDIR}/security/krb5 \
-		libldap.so:${PORTSDIR}/net/openldap24-client \
 		libinotify.so:${PORTSDIR}/devel/libinotify
 BUILD_DEPENDS=	xmlcatalog:${PORTSDIR}/textproc/libxml2 \
 		docbook-xsl>=1:${PORTSDIR}/textproc/docbook-xsl \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Craig Rodrigues freebsd_committer freebsd_triage 2014-04-26 06:24:59 UTC
State Changed
From-To: open->closed

Patch committed. 


Comment 7 Craig Rodrigues freebsd_committer freebsd_triage 2014-04-26 06:24:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rodrigc

Patch committed.