Bug 188981 - [NEW PORT] revive port textproc/asm2html - Converts NASM syntax assembly code into (X)HTML output
Summary: [NEW PORT] revive port textproc/asm2html - Converts NASM syntax assembly code...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-25 04:00 UTC by Chris Hutchinson
Modified: 2014-06-11 13:29 UTC (History)
1 user (show)

See Also:

Attachments
file.shar (1.80 KB, text/plain)
2014-04-25 04:00 UTC, Chris Hutchinson 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2014-04-25 04:00:01 UTC 
New port intended for textproc/asm2html
asm2html converts NASM syntax assembly code into HTML output,
suitable for display as web pages on your web site.
Soon it will produce XHTML output, with additional options.

Please find attached to this pr(1) asm2html.shar which contains
all needed files to produce a standard FreeBSD port.

Thank you for all your time, and consideration.

--Chris

Fix: Patch attached with submission follows:
How-To-Repeat: N/A
Comment 1 John Marino freebsd_committer freebsd_triage 2014-06-11 12:50:31 UTC 
first discovered issues:
1) tabs removed, spaced used installed (error)
2) 2nd line in header is supposed to be "# $FreeBSD$", I saw the same mistake in another resurrection PR
3) It's not STAGED!
Comment 2 John Marino freebsd_committer freebsd_triage 2014-06-11 12:53:58 UTC 
Quick hit: the original COMMENT was correct; it's against style to use the name of the port in the COMMENT itself.  Reverting to use the previous version...
Comment 3 John Marino freebsd_committer freebsd_triage 2014-06-11 12:57:15 UTC 
Since the PLIST is only two files (executable and man page) it's probably better to just leave the list in the Makefile.

Total judgement call (there's no right answer) but I'd say a PLIST < 5 is very common to include it as part of the Makefile.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-06-11 13:14:55 UTC 
ack!

This port is not clang friendly!
It's failing on F10+ due to hardcoded gcc
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-06-11 13:27:39 UTC 
A commit references this bug:

Author: marino
Date: Wed Jun 11 13:26:53 UTC 2014
New revision: 357476
URL: http://svnweb.freebsd.org/changeset/ports/357476

Log:
  Resurrect textproc/asm2html (with stage support), assign maintainer

  This port was removed in 2011 due to a lack of distfiles.  Chris has
  rectified this and becomes the new maintainer.  Other things of note:

   * Header trimmed
   * pkg-descr updated (new WWW link too)
   * Stage support
   * Updated to newer version 1.4 => 1.7
   * BSD 3-clause license annotated
   * Fix on FreeBSD 10+

  PR:		188981
  Submitted by:	Chris Hutchinson
  Fixes by:	marino

Changes:
  head/MOVED
  head/textproc/Makefile
  head/textproc/asm2html/
  head/textproc/asm2html/Makefile
  head/textproc/asm2html/distinfo
  head/textproc/asm2html/pkg-descr
Comment 6 John Marino freebsd_committer freebsd_triage 2014-06-11 13:29:09 UTC 
The proposed port needed a lot of changes, see commit diffs.
closing...