Bug 189019 - mail/exim: Perl is always needed for build
Summary: mail/exim: Perl is always needed for build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Vsevolod Stakhov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-26 14:30 UTC by Tim Bishop
Modified: 2016-01-17 15:00 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Bishop freebsd_committer freebsd_triage 2014-04-26 14:30:00 UTC 
I'm building mail/exim without the EMBEDDED_PERL option, and in my poudriere builds this means that perl isn't included. During the build I see:

===>  Configuring for exim-4.82
/bin/sh scripts/source_checks
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found

Fix: This would probably be sufficient, but could do with a bit more testing and verification from the maintainer.



NO_STAGE=      yes
 # One can tune the following "hidden" knobs:
@@ -221,7 +222,6 @@
 .endif

 .if ${PORT_OPTIONS:MEMBEDDED_PERL}
-USES+=         perl5
 SEDLIST+=      -e 's,^\# (EXIM_PERL=),\1,'
 .endif--11DgWclOjhiOCgjOJtqcNz9E2Xx7xtec9XcxswBh6jt2uDzG
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

Index: Makefile
===================================================================
--- Makefile    (revision 352256)
+++ Makefile    (working copy)
@@ -19,6 +19,7 @@
 USE_BZIP2=     yes
 WANT_GNOME=    yes
 MAKE_JOBS_UNSAFE=      yes
+USES+=         perl5
How-To-Repeat: Build mail/exim without the EMBEDDED_PERL option, which is on by default.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-26 14:30:04 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->rea

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Vsevolod Stakhov freebsd_committer freebsd_triage 2014-07-05 15:11:25 UTC 
Committed, thanks!
Comment 3 Tim Bishop freebsd_committer freebsd_triage 2014-07-05 16:19:51 UTC 
This is partly fixed. It looks like you've added a runtime dependency on Perl? So the tools will be fine. But the build needs it too - see the configure output in the original bug report.

Tim.
Comment 4 Vsevolod Stakhov freebsd_committer freebsd_triage 2014-07-05 16:59:26 UTC 
I think it would be better to disable this script completely. It is used basically for development of exim to ensure the consistency of sources. We can safely assume that downloaded sources are consistent.
Comment 5 Tim Bishop freebsd_committer freebsd_triage 2014-07-05 18:00:36 UTC 
I've not looked in detail at it, so I'll defer to your judgement :-)
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2016-01-17 15:00:41 UTC 
Patch was committed 2014-07-05