Sorry about the formatting (description in environment) and for the missing shar (attach here).
I'll take it, review pending
Hi Samir, thanks for your submission :) Review: - Include portlint output (pass or warnings) - Create an account at redports to build test/QA future submissions, and provide the build log URL when you submit them - Use CHEESESHOP for MASTER_SITES, or USE_GITHUB for distribution files - RUN_DEPENDS:py-sqlite3 - I don't see sqlite in setup.py:install_requires, why it is required here? - pkg-descr: Strip trailing-slash from WWW: URL Please submit a second version of your changes, and let me know if you have any questions :)
Feedback timeout by maintainer for new port pending updated patch. Anyone may re-open this issue to provide the requested changes (and take maintainership if necessary(
Created attachment 146592 [details] pycarddav port corrections
Sorry about the lag, in attachment the updated patch : - Use CHEESESHOP in MASTER_SITES - Use USES and USE_PYTHON - Correct RUN_DEPENDS (port version) - Change WWW url in pkg-descr (removing the trailing slash) - distinfo checksum and size Test suite : - port test : OK - portlint : OK - poudriere testport : OK Redports logs : https://redports.org//~samir/20140831105200-59632-239202/py27-pycarddav-0.7.0.log py-sqlite3 is not in the install_requires of setup.py because sqlite is a part of the Python standard library, but this is not the case under FreeBSD (sqlite is provided in a separate port).
A commit references this bug: Author: koobs Date: Sun Jan 18 08:35:13 UTC 2015 New revision: 377285 URL: https://svnweb.freebsd.org/changeset/ports/377285 Log: [NEW] www/pycarddav: Simple to use CardDAV CLI client pyCardDAV is a simple to use CardDAV CLI client. It has built in support for mutt's query_command but also works very well solo (and with other MUAs). pyCardDAV consists of pycardsyncer, a program for syncing your CardDAV resource into a local database and of pc_query, a program for querying the local database. Features: * Tested against davical, owncloud and sabredav * Import the sender's address directly from mutt * Add email addresses directly from mutt * Backup and import to and from .vcf files WWW: http://lostpackets.de/pycarddav PR: 189098 (with changes) Submitted by: Samir Noir <samir noir im> Changes: head/www/Makefile head/www/pycarddav/ head/www/pycarddav/Makefile head/www/pycarddav/distinfo head/www/pycarddav/files/ head/www/pycarddav/files/pkg-message.in head/www/pycarddav/pkg-descr
Committed with minor changes, apologies for the delay and thank you Samir!