Bug 189135 - [PATCH] net-mgmt/zabbix22-server: update to 2.2.3
Summary: [PATCH] net-mgmt/zabbix22-server: update to 2.2.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-30 12:20 UTC by Danilo G. Baio
Modified: 2014-06-08 20:54 UTC (History)
1 user (show)

See Also:


Attachments
zabbix22-server-2.2.3.patch (6.41 KB, patch)
2014-04-30 12:20 UTC, Danilo G. Baio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Danilo G. Baio freebsd_committer freebsd_triage 2014-04-30 12:20:00 UTC
- Update to 2.2.3
- Update to use OptionsNG
- Fix stage with JAVAGW options enabled
- Drop oracle option

Port maintainer (pakhom706@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 1.01 (mode: update, diff: SVN)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-30 12:20:04 UTC
Maintainer of net-mgmt/zabbix22-server,

Please note that PR ports/189135 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/189135

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-30 12:20:05 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 pg 2014-05-01 12:27:08 UTC
Hi,
I'm on holiday. Please wait. I look patch after that.

Thanks

30.04.2014 15:20, Edwin Groothuis пиÑеÑ:
> Maintainer of net-mgmt/zabbix22-server,
>
> Please note that PR ports/189135 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/189135
>
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2014-05-27 17:33:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Take
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2014-05-27 18:53:21 UTC
State Changed
From-To: feedback->closed

Committed, thanks
Comment 6 dfilter service freebsd_committer freebsd_triage 2014-05-27 18:53:21 UTC
Author: rene
Date: Tue May 27 17:53:16 2014
New Revision: 355546
URL: http://svnweb.freebsd.org/changeset/ports/355546
QAT: https://qat.redports.org/buildarchive/r355546/

Log:
  net/mgmt/zabbix22-server: Update to 2.2.3 [1]
  - Use optionsNG
  - Drop OracleDB support
  - Add iODBC support next to unixODBC support
  - Fix staging with JAVAGW enabled
  - Drop unused ZABBIX_REQUIRE variable
  
  From myself:
  - Unmute installation commands
  - Drop patches merged upstream
  
  PR:		ports/189135 [1]
  Submitted by:	Danilo G. Baio <dbaio@bsd.com.br>
  Approved by:	maintainer timeout (Pakhom Golynga <pakhom706@gmail.com>) (13 days)

Deleted:
  head/net-mgmt/zabbix22-server/files/patch-src_shutdown.sh
  head/net-mgmt/zabbix22-server/files/patch-src_startup.sh
Modified:
  head/net-mgmt/zabbix22-server/Makefile
  head/net-mgmt/zabbix22-server/distinfo
  head/net-mgmt/zabbix22-server/pkg-plist

Modified: head/net-mgmt/zabbix22-server/Makefile
==============================================================================
--- head/net-mgmt/zabbix22-server/Makefile	Tue May 27 17:39:26 2014	(r355545)
+++ head/net-mgmt/zabbix22-server/Makefile	Tue May 27 17:53:16 2014	(r355546)
@@ -2,8 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	zabbix22
-PORTVERSION=	2.2.2
-PORTREVISION?=	1
+PORTVERSION=	2.2.3
 CATEGORIES=	net-mgmt
 MASTER_SITES=	SF/zabbix/ZABBIX%20Latest%20Stable/${PORTVERSION}
 PKGNAMESUFFIX?=	-server
@@ -70,7 +69,8 @@ CONFIGURE_ARGS+=	--with-net-snmp
 OPTIONSFILE=	${PORT_DBDIR}/${PORTNAME}${PKGNAMESUFFIX}/options
 
 OPTIONS_DEFINE=	IPV6 FPING JABBER CURL LDAP IPMI SSH NMAP JAVAGW LIBXML2
-OPTIONS_DEFAULT=	MYSQL IPV6 FPING JABBER CURL
+OPTIONS_DEFAULT=	MYSQL IPV6 FPING JABBER CURL UNIXODBC
+OPTIONS_SUB=	yes
 
 CURL_DESC=	Support for web monitoring
 FPING_DESC=	Build/install fping for ping checks
@@ -83,91 +83,55 @@ ODBC_DESC=	Support for database checks v
 JAVAGW_DESC=	Support for Java gateway
 LIBXML2_DESC=	Support for libxml2 (required by monitoring VMware)
 
-OPTIONS_SINGLE=	DB
-OPTIONS_SINGLE_DB=	MYSQL PGSQL SQLITE ORACLE ODBC
+OPTIONS_SINGLE=	DB ODBC
+OPTIONS_SINGLE_DB=	MYSQL PGSQL SQLITE
+OPTIONS_SINGLE_ODBC=	IODBC UNIXODBC
 
-.include <bsd.port.options.mk>
-
-.if ${PORT_OPTIONS:MMYSQL}
-ZABBIX_REQUIRE=	" mysql"
-USE_MYSQL=	yes
-CONFIGURE_ARGS+=	--with-mysql
-.endif
+MYSQL_CONFIGURE_WITH=	mysql
+MYSQL_USE=	MYSQL=yes
 
-.if ${PORT_OPTIONS:MPGSQL}
-ZABBIX_REQUIRE=	" postgresql"
-USE_PGSQL=	yes
-CONFIGURE_ARGS+=	--with-postgresql
-.endif
+PGSQL_CONFIGURE_WITH=	postgresql
+PGSQL_USES=	PGSQL
 
-.if ${PORT_OPTIONS:MSQLITE}
-ZABBIX_REQUIRE=	" sqlite"
-USE_SQLITE=	3
-CONFIGURE_ARGS+=	--with-sqlite3
-.endif
+SQLITE_CONFIGURE_WITH=	sqlite3
+SQLITE_USE=	SQLITE=3
 
-.if ${PORT_OPTIONS:MORACLE}
-ZABBIX_REQUIRE=
-CONFIGURE_ARGS+=	--with-oracle
-.endif
+CURL_CONFIGURE_WITH=	libcurl
+CURL_LIB_DEPENDS=	libcurl.so:${PORTSDIR}/ftp/curl
 
-.if ${PORT_OPTIONS:MCURL}
-LIB_DEPENDS+=	libcurl.so:${PORTSDIR}/ftp/curl
-CONFIGURE_ARGS+=	--with-libcurl
-.endif
+LDAP_CONFIGURE_WITH=	ldap
+LDAP_USE=	OPENLDAP=yes
 
-.if ${PORT_OPTIONS:MLDAP}
-USE_OPENLDAP=	yes
-CONFIGURE_ARGS+=	--with-ldap
-.endif
+IPMI_CONFIGURE_WITH=	openipmi
+IPMI_LIB_DEPENDS=	libOpenIPMI.so:${PORTSDIR}/sysutils/openipmi
 
-.if ${PORT_OPTIONS:MIPMI}
-LIB_DEPENDS+=	libOpenIPMI.so:${PORTSDIR}/sysutils/openipmi
-CONFIGURE_ARGS+=	--with-openipmi
-.endif
+JABBER_CONFIGURE_WITH=	jabber
+JABBER_LIB_DEPENDS=	libiksemel.so:${PORTSDIR}/textproc/iksemel
 
-.if ${PORT_OPTIONS:MJABBER}
-LIB_DEPENDS+=	libiksemel.so:${PORTSDIR}/textproc/iksemel
-CONFIGURE_ARGS+=	--with-jabber
-.endif
+FPING_RUN_DEPENDS=	fping:${PORTSDIR}/net/fping
 
-.if ${PORT_OPTIONS:MFPING}
-RUN_DEPENDS+=	fping:${PORTSDIR}/net/fping
-.endif
+SSH_CONFIGURE_WITH=	ssh2
+SSH_LIB_DEPENDS=	libssh2.so:${PORTSDIR}/security/libssh2
 
-.if ${PORT_OPTIONS:MSSH}
-LIB_DEPENDS+=	libssh2.so:${PORTSDIR}/security/libssh2
-CONFIGURE_ARGS+=	--with-ssh2
-.endif
+IODBC_CONFIGURE_WITH=	iodbc
+IODBC_LIB_DEPENDS=	libiodbc.so:${PORTSDIR}/databases/libiodbc
 
-.if ${PORT_OPTIONS:MODBC}
-LIB_DEPENDS+=	libodbc.so:${PORTSDIR}/databases/unixODBC
-CONFIGURE_ARGS+=	--with-unixodbc
-.endif
+UNIXODBC_CONFIGURE_WITH=	unixodbc
+UNIXODBC_LIB_DEPENDS=	libodbc.so:${PORTSDIR}/databases/unixODBC
 .endif # if ${ZABBIX_BUILD} != "agent"
 
-.if ${PORT_OPTIONS:MIPV6}
-CONFIGURE_ARGS+=	--enable-ipv6
-.endif
+IPV6_CONFIGURE_ENABLE=	ipv6
 
-.if ${PORT_OPTIONS:MNMAP}
-RUN_DEPENDS+=	nmap:${PORTSDIR}/security/nmap \
+NMAP_RUN_DEPENDS=	nmap:${PORTSDIR}/security/nmap \
 		sudo:${PORTSDIR}/security/sudo
-.endif
 
-.if ${PORT_OPTIONS:MJAVAGW}
-USE_JAVA=	yes
-CONFIGURE_ARGS+=	--enable-java
-PLIST_SUB+=	ZABBIX_JAVA="sbin/zabbix_java"
-PLIST_SUB+=	JAVAGW=""
-.else
-PLIST_SUB+=	JAVAGW="@comment "
-.endif
+JAVAGW_CONFIGURE_ENABLE=	java
+JAVAGW_USE=	JAVA=yes
 
-.if ${PORT_OPTIONS:MLIBXML2}
-LIB_DEPENDS+=	libxml2.so:${PORTSDIR}/textproc/libxml2
-CONFIGURE_ARGS+=	--with-libxml2
-.endif
+LIBXML2_CONFIGURE_WITH=	libxml2
+LIBXML2_LIB_DEPENDS=	libxml2.so:${PORTSDIR}/textproc/libxml2
+
+.include <bsd.port.options.mk>
 
 post-patch:
 	@${GREP} -rl "/etc/zabbix" ${WRKSRC} \
@@ -175,7 +139,7 @@ post-patch:
 	@${REINPLACE_CMD} -e 's#/usr/sbin/fping#${LOCALBASE}/sbin/fping#g' ${WRKSRC}/conf/zabbix_*.conf
 
 .if ${ZABBIX_BUILD} != "agent"
-.if empty(PORT_OPTIONS:MFPING)
+.if ! ${PORT_OPTIONS:MFPING}
 .endif
 .for d in mysql oracle postgresql sqlite3
 	@${REINPLACE_CMD} -e 's|/bin/ping|/sbin/ping|g; \
@@ -189,15 +153,14 @@ post-patch:
 	@${FIND} ${WRKSRC} -type f \( -name '*.bak' -or -name '*.orig' \) -exec ${RM} -f {} +
 
 post-install:
-
-.if defined(WITH_JAVAGW)
+.if ${PORT_OPTIONS:MJAVAGW}
 	@${MV} ${STAGEDIR}${PREFIX}/sbin/zabbix_java/settings.sh ${STAGEDIR}${PREFIX}/sbin/zabbix_java/settings.sh.sample
 .endif
 
 .if ${ZABBIX_BUILD} != "agent"
-	@${MKDIR} "${STAGEDIR}${DATADIR}/${ZABBIX_BUILD}/database"
-	@cd ${WRKSRC}/upgrades/ && ${COPYTREE_SHARE} dbpatches ${STAGEDIR}${DATADIR}/${ZABBIX_BUILD}/upgrades/
-	@cd ${WRKSRC}/database/ && ${COPYTREE_SHARE} "ibm_db2 mysql oracle postgresql sqlite3" ${STAGEDIR}${DATADIR}/${ZABBIX_BUILD}/database/
+	${MKDIR} "${STAGEDIR}${DATADIR}/${ZABBIX_BUILD}/database"
+	cd ${WRKSRC}/upgrades/ && ${COPYTREE_SHARE} dbpatches ${STAGEDIR}${DATADIR}/${ZABBIX_BUILD}/upgrades/
+	cd ${WRKSRC}/database/ && ${COPYTREE_SHARE} "ibm_db2 mysql oracle postgresql sqlite3" ${STAGEDIR}${DATADIR}/${ZABBIX_BUILD}/database/
 .endif
 .endif # if ${ZABBIX_BUILD} != "frontend"
 

Modified: head/net-mgmt/zabbix22-server/distinfo
==============================================================================
--- head/net-mgmt/zabbix22-server/distinfo	Tue May 27 17:39:26 2014	(r355545)
+++ head/net-mgmt/zabbix22-server/distinfo	Tue May 27 17:53:16 2014	(r355546)
@@ -1,2 +1,2 @@
-SHA256 (zabbix-2.2.2.tar.gz) = e00ef9a1d667284a2bc2ce04966204ee094ade2c0bc6a94efb9436a9aa5cb2be
-SIZE (zabbix-2.2.2.tar.gz) = 14595839
+SHA256 (zabbix-2.2.3.tar.gz) = 12a75762d474227f9af8b44abe48dd2660a76713335a37fc8147aca3c79844c1
+SIZE (zabbix-2.2.3.tar.gz) = 14649686

Modified: head/net-mgmt/zabbix22-server/pkg-plist
==============================================================================
--- head/net-mgmt/zabbix22-server/pkg-plist	Tue May 27 17:39:26 2014	(r355545)
+++ head/net-mgmt/zabbix22-server/pkg-plist	Tue May 27 17:53:16 2014	(r355546)
@@ -33,19 +33,19 @@ sbin/zabbix_%%ZABBIX_BUILD%%
 %%DATADIR%%/%%ZABBIX_BUILD%%/upgrades/dbpatches/1.6/postgresql/patch.sql
 %%DATADIR%%/%%ZABBIX_BUILD%%/upgrades/dbpatches/1.6/oracle/patch.sql
 %%DATADIR%%/%%ZABBIX_BUILD%%/upgrades/dbpatches/1.6/mysql/patch.sql
-%%JAVAGW%%%%ZABBIX_JAVA%%/shutdown.sh
-%%JAVAGW%%%%ZABBIX_JAVA%%/lib/logback-console.xml
-%%JAVAGW%%%%ZABBIX_JAVA%%/lib/logback-core-0.9.27.jar
-%%JAVAGW%%%%ZABBIX_JAVA%%/lib/org-json-2010-12-28.jar
-%%JAVAGW%%%%ZABBIX_JAVA%%/lib/logback-classic-0.9.27.jar
-%%JAVAGW%%%%ZABBIX_JAVA%%/lib/logback.xml
-%%JAVAGW%%%%ZABBIX_JAVA%%/lib/slf4j-api-1.6.1.jar
-%%JAVAGW%%%%ZABBIX_JAVA%%/settings.sh.sample
-%%JAVAGW%%%%ZABBIX_JAVA%%/startup.sh
-%%JAVAGW%%%%ZABBIX_JAVA%%/bin/zabbix-java-gateway-%%PORTVERSION%%.jar
-%%JAVAGW%%@dirrmtry %%ZABBIX_JAVA%%/lib
-%%JAVAGW%%@dirrmtry %%ZABBIX_JAVA%%/bin
-%%JAVAGW%%@dirrmtry %%ZABBIX_JAVA%%
+%%JAVAGW%%sbin/zabbix_java/shutdown.sh
+%%JAVAGW%%sbin/zabbix_java/lib/logback-console.xml
+%%JAVAGW%%sbin/zabbix_java/lib/logback-core-0.9.27.jar
+%%JAVAGW%%sbin/zabbix_java/lib/org-json-2010-12-28.jar
+%%JAVAGW%%sbin/zabbix_java/lib/logback-classic-0.9.27.jar
+%%JAVAGW%%sbin/zabbix_java/lib/logback.xml
+%%JAVAGW%%sbin/zabbix_java/lib/slf4j-api-1.6.1.jar
+%%JAVAGW%%sbin/zabbix_java/settings.sh.sample
+%%JAVAGW%%sbin/zabbix_java/startup.sh
+%%JAVAGW%%sbin/zabbix_java/bin/zabbix-java-gateway-%%PORTVERSION%%.jar
+%%JAVAGW%%@dirrmtry sbin/zabbix_java/lib
+%%JAVAGW%%@dirrmtry sbin/zabbix_java/bin
+%%JAVAGW%%@dirrmtry sbin/zabbix_java
 @dirrm %%DATADIR%%/%%ZABBIX_BUILD%%/upgrades/dbpatches/2.2
 @dirrm %%DATADIR%%/%%ZABBIX_BUILD%%/upgrades/dbpatches/2.0/ibm_db2
 @dirrm %%DATADIR%%/%%ZABBIX_BUILD%%/upgrades/dbpatches/2.0/postgresql
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 pg 2014-05-27 18:53:27 UTC
Hello,
Sorry for delay. I take this PR in the near future.
Why do you want to drop oracle option?

30.04.2014 15:20, Edwin Groothuis пиÑеÑ:
> Maintainer of net-mgmt/zabbix22-server,
>
> Please note that PR ports/189135 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/189135
>
Comment 8 Rene Ladan freebsd_committer freebsd_triage 2014-05-27 19:23:04 UTC
State Changed
From-To: closed->feedback

Re-open
Comment 9 Rene Ladan freebsd_committer freebsd_triage 2014-05-27 19:24:57 UTC
Dropping the Oracle extension was somehow part of the PR, but I would be
happy to add it again.

Maybe Danilo can explain?
Comment 10 pg 2014-05-27 20:09:29 UTC
Please add Oracle extension.
Thanks

27.05.2014 22:24, René Ladan пиÑеÑ:
> Dropping the Oracle extension was somehow part of the PR, but I would be
> happy to add it again.
>
> Maybe Danilo can explain?
Comment 11 Rene Ladan freebsd_committer freebsd_triage 2014-05-27 20:12:34 UTC
I re-added the Oracle option.

René
Comment 12 pg 2014-05-27 20:25:44 UTC
After that if selected postgresql:
make config
"/usr/ports/Mk/bsd.port.mk", line 1530: Could not find 
/usr/ports/Mk/Uses/PGSQL=yes.mk

Error solve with this patch:
--- Makefile.orig       2014-05-27 22:16:41.065329000 +0400
+++ Makefile    2014-05-27 23:14:20.207344837 +0400
@@ -91,7 +91,7 @@
  MYSQL_USE=     MYSQL=yes

  PGSQL_CONFIGURE_WITH=  postgresql
-PGSQL_USES=    PGSQL
+PGSQL_USES=    pgsql

  SQLITE_CONFIGURE_WITH= sqlite3
  SQLITE_USE=    SQLITE=3
Comment 13 Rene Ladan freebsd_committer freebsd_triage 2014-06-08 20:54:22 UTC
Typo for USES fixed in r355601 by mat@