Bug 190009 - [stage] Add staging support to www/autoindex2
Summary: [stage] Add staging support to www/autoindex2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-20 15:50 UTC by joe
Modified: 2014-09-06 05:16 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (1.89 KB, patch)
2014-05-20 15:50 UTC, joe 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description joe 2014-05-20 15:50:02 UTC 
Adds staging support to www/autoindex2.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-20 15:50:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->danger

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-11 14:00:12 UTC 
maintainer reset, moving to patch-ready (untested, take at your own risk)
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-13 21:55:54 UTC 
man, this port was terrible before you staged it.
It never should have needed CHMOD'ing, but then it sets graphic files to 755, this is bizarre.

Most of this CHMOD stuff can go since COPYTREE_SHARE fixes it.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-13 21:56:59 UTC 
You did not add @owner and @group to pkg-plist though.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-13 22:00:16 UTC 
This INSTALLDIR logic never worked.
It wants INSTALLDIR to be WWWDIR by default but then it hardcodes plist to WWWDIR anyway.  This port was garbage, frankly.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-08-13 22:36:23 UTC 
A commit references this bug:

Author: marino
Date: Wed Aug 13 22:35:48 UTC 2014
New revision: 364817
URL: http://svnweb.freebsd.org/changeset/ports/364817

Log:
  Stage www/autoindex2

  The original port had several issues with it beyond staging.  For example,
  the INSTALLDIR mechanism didn't work because the PLIST_SUB was hardcoded
  for WWWDIR.  All sorts of CHMOD'ing was going on because COPYTREE_SHARE
  hadn't been used.  The config.php was installed directly and therefore
  overwritten and/or removed each time the port was de/reinstalled.  The
  prefetch didn't work because it checked if INSTALLDIR was defined, but
  the makefile always defines it.  The whole thing had to be reworked, so
  very little of provided patch actually got used.

  PR:		190009
  Submitted by:	Joe (thralling.com)
  Approved by:	Nobody, maintainer was reset
  Lotsa TLC:	marino

Changes:
  head/www/autoindex2/Makefile
  head/www/autoindex2/pkg-plist
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-13 22:37:14 UTC 
glad to see this finished.
Comment 8 John Marino freebsd_committer freebsd_triage 2014-08-13 23:03:32 UTC 
actually @sample keyword can be used in the plist instead of that @exec stuff.