Bug 190107 - [patch] sysutils/graffer: update version to 1.1
Summary: [patch] sysutils/graffer: update version to 1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tim Bishop
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-22 13:50 UTC by Nikola Kolev
Modified: 2014-06-03 16:12 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (1.59 KB, patch)
2014-05-22 13:50 UTC, Nikola Kolev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikola Kolev 2014-05-22 13:50:02 UTC 
Update graffer version to 1.1.

Fix: Patch attached with submission follows:
Comment 1 Tim Bishop freebsd_committer freebsd_triage 2014-06-03 01:14:22 UTC 
Some fixes:

-PORTVERSION=   1.0
+PORTVERSION=   1.1
+PORTREVISION=  1

You don't need to set PORTREVISION.

       @${REINPLACE_CMD} -e "s|/etc/|${STAGEDIR}${PREFIX}/etc/|" \
               ${WRKSRC}/graffer.[c8]
       @${REINPLACE_CMD} -e "s|/etc/|${STAGEDIR}${PREFIX}/etc/|" \
               ${WRKSRC}/graffer.conf.example

This looks wrong to me. You don't want ${STAGEDIR} appearing in installed files. It's just for the build process. Remove it completely from those lines.
Comment 2 Nikola Kolev 2014-06-03 06:44:41 UTC 
(In reply to Tim Bishop from comment #1)
> Some fixes:
> 
> -PORTVERSION=   1.0
> +PORTVERSION=   1.1
> +PORTREVISION=  1
> 
> You don't need to set PORTREVISION.
> 
>        @${REINPLACE_CMD} -e "s|/etc/|${STAGEDIR}${PREFIX}/etc/|" \
>                ${WRKSRC}/graffer.[c8]
>        @${REINPLACE_CMD} -e "s|/etc/|${STAGEDIR}${PREFIX}/etc/|" \
>                ${WRKSRC}/graffer.conf.example
> 
> This looks wrong to me. You don't want ${STAGEDIR} appearing in installed
> files. It's just for the build process. Remove it completely from those
> lines.

Yes, you are right. I found the mistake after patch was sent.

Correct:

       @${REINPLACE_CMD} -e "s|/etc/|${PREFIX}/etc/|" \
               ${WRKSRC}/graffer.[c8]
       @${REINPLACE_CMD} -e "s|/etc/|${PREFIX}/etc/|" \
               ${WRKSRC}/graffer.conf.example
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-06-03 10:12:51 UTC 
A commit references this bug:

Author: tdb
Date: Tue Jun  3 10:12:42 UTC 2014
New revision: 356318
URL: http://svnweb.freebsd.org/changeset/ports/356318

Log:
  Update to version 1.1

  PR:		190107
  Submitted by:	Nikola Kolev <koue@chaosophia.net> (maintainer)

Changes:
  head/sysutils/graffer/Makefile
  head/sysutils/graffer/distinfo
Comment 4 Tim Bishop freebsd_committer freebsd_triage 2014-06-03 16:12:53 UTC 
Committed, thanks!