Bug 190504 - [maintainer] stagify lang/petite-chez
Summary: [maintainer] stagify lang/petite-chez
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlo Strub
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-02 12:22 UTC by Vitaly Magerya
Modified: 2014-06-05 21:58 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Magerya 2014-06-02 12:22:41 UTC
Stagify lang/petite-chez; it's build system has support for this, so it's a fairly minor change.

Note that when building as non-root, stage complains that it can't chown a bunch of files. I don't know what causes it (bug in the ports system?), but it works fine as root, so I did not investigate it further.

Also note that lang/petite-chez is a port with a peculiar license requirements (you need to set PETITECHEZ_AGREE_LICENSE environment variable to "yes" before building it), so I can't provide redports logs.

Fix:
Patch attached with submission follows:

diff -ruN petite-chez.orig/Makefile petite-chez/Makefile
--- petite-chez.orig/Makefile	2014-06-02 14:54:30.000000000 +0300
+++ petite-chez/Makefile	2014-06-02 14:59:59.000000000 +0300
@@ -29,6 +29,7 @@
 USES=		iconv
 CONFIGURE_ARGS=	--installprefix=${PREFIX} \
 		--installman=${MANPREFIX}/man \
+		--temproot=${STAGEDIR} \
 		--force-relink \
 		--nogzip-man-pages \
 		-m=${CHEZ_MACHTYPE}
@@ -40,7 +41,6 @@
 PLIST_SUB=	CHEZ_VERSION="${PORTVERSION}" \
 		CHEZ_MACHTYPE="${CHEZ_MACHTYPE}"
 
-NO_STAGE=	yes
 .include <bsd.port.pre.mk>
 
 .if ${ARCH} == "i386"
Comment 1 commit-hook freebsd_committer freebsd_triage 2014-06-05 21:55:52 UTC
A commit references this bug:

Author: cs
Date: Thu Jun  5 21:55:02 UTC 2014
New revision: 356715
URL: http://svnweb.freebsd.org/changeset/ports/356715

Log:
  - Support staging
  - Strip binaries
  - Pet portlint

  PR:		190504
  Submitted by:	vmagerya@gmail.com (maintainer)

Changes:
  head/lang/petite-chez/Makefile
  head/lang/petite-chez/pkg-plist
Comment 2 Carlo Strub freebsd_committer freebsd_triage 2014-06-05 21:58:54 UTC
Committed with some small additions. Most importantly, the binaries apparently need to be stripped.