Bug 190951 - [patch] Added stage support to www/thundercache
Summary: [patch] Added stage support to www/thundercache
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-12 01:40 UTC by joe
Modified: 2014-06-13 16:18 UTC (History)
2 users (show)

See Also:

Attachments
Added stage support to thundercache (2.36 KB, text/plain)
2014-06-12 01:40 UTC, joe 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description joe 2014-06-12 01:40:29 UTC 
Created attachment 143695 [details]
Added stage support to thundercache

Added stage support to www/thundercache.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-06-13 15:18:46 UTC 
CC: maintainer 

portlint is spewing a ton a warnings (unrelated to staging).
I'm going to make some adjustments to make portlint happy.

It's also possible pgsql isn't handled right, so that may be adjusted as well.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-06-13 15:43:02 UTC 
wow, there was a typo with the OPTIONS definition, pgsql was turned off by default due to it.  This may be why this port was never upgraded wrt to pgsql.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-06-13 16:15:57 UTC 
A commit references this bug:

Author: marino
Date: Fri Jun 13 16:15:52 UTC 2014
New revision: 357696
URL: http://svnweb.freebsd.org/changeset/ports/357696

Log:
  www/thundercache: Stage support, PGSQL option fix and more

  The PR only provided changes needed to add stage support.  However, the
  port needed some additional TLC:

   * DISTNAME reworked for single, ARCH-based definition (pets portlint)
   * LICENSE stuff moved, rearranged (pets portlint)
   * DOCS option removed (it wasn't implemented)
   * Typo for PGSQL option fixed so it's default again (bump portrevision)
   * Cosmestic alignment
   * PGSQL converted to USES+=pgsql and WANT_PGSQL=
   * php+pgsql RUN_DEPENDS refactored, and set to use USE_PHP
   * Convert to new LIB_DEPENDS style (PR)
   * Convert to USES+=tar (PR)
   * Remove WWW whitespace (PR)
   * Handle /var/run/thunder (PR) (also requires portrevision bump)

  PR:		190951
  Submitted by:	Joe Benden
  fixes by:	marino
  Approved by:	stage blanket + just fix it blanket
  verified by:	Redports 8x pass

Changes:
  head/www/thundercache/Makefile
  head/www/thundercache/pkg-descr
  head/www/thundercache/pkg-plist
Comment 4 John Marino freebsd_committer freebsd_triage 2014-06-13 16:18:31 UTC 
Even more issues were found (and fixed) - see commit log and actual diffs for details.