Created attachment 144018 [details] update-py-redis-2.10.1.patch Updates to 2.10.1 and add support to build HTML documentation via sphinx. Fix: Build archives: https://redports.org/buildarchive/20140622093200-49963/ https://redports.org/buildarchive/20140622090401-30908/ https://redports.org/buildarchive/20140622085456-77151/
Building with HTMLDOCS on fails in check-plist: ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/.buildinfo
Guess I need to wrap that for the NOPORTDOCS case, coming up.
(In reply to Raphael Kubo da Costa from comment #1) > Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/.buildinfo If that's the only one, then it's PORTDOCS=* that doesn't include hidden files. Easiest fix is to remove it in post-install, which I'm doing now. But thanks for prompting me to check the NOPORTDOCS case as well.
Created attachment 144048 [details] Fix HTMLDOCS issues Buildarchive: https://redports.org/buildarchive/20140622202300-12929/
Thanks for the update, but check-plist still fails here, albeit with a different error, when HTMLDOCS is on. With poudriere, I get this: ===> No pkg-plist issues found (check-plist) ====>> Checking for staging violations... done ====>> Error: Filesystem touched during stage (files must install to ${STAGEDIR}): extra: usr/local/share/doc/py27-redis If I just use `make clean build stage stage-qa check-plist' I get this during the installation phase: mkdir: /usr/local/share/doc/py27-redis: Permission denied *** Error code 1
Oh, it's just a missing ${STAGEDIR} in your mkdir call in post-install. I'll fix that in the commit.
A commit references this bug: Author: rakuco Date: Sun Jun 22 22:22:12 UTC 2014 New revision: 358855 URL: http://svnweb.freebsd.org/changeset/ports/358855 Log: - Updates to 2.10.1 - Add support to build HTML documentation via sphinx. PR: 191267 Submitted by: melvyn@magemana.nl (maintainer) Changes: head/databases/py-redis/Makefile head/databases/py-redis/distinfo
Committed, thanks.
Submitter is not maintainer. Re-opening. @Raphael: as per list reply, please: - Rename the HTMLDOCS option name to DOCS - Use USES=uniquefiles for uniquely-prefixed python doc directories.
Created attachment 144058 [details] Proposed fixes Sorry for the screw-up! Let me know if this is what you have in mind. It still hasn't been QA'd as you said in the list reply, though.
A commit references this bug: Author: rakuco Date: Mon Jun 23 17:20:09 UTC 2014 New revision: 358976 URL: http://svnweb.freebsd.org/changeset/ports/358976 Log: - Use the more standard DOCS option instead of HTMLDOCS. - Set PYTHON_CONCURRENT_INSTALL and do not manually set DOCSDIR so that multiple versions can be installed concurrently. PR: 191267 Submitted by: rakuco Approved by: koobs (the actual maintainer :-) Changes: head/databases/py-redis/Makefile
Committed after an ack from koobs in http://permalink.gmane.org/gmane.os.freebsd.devel.cvs.ports/310248