Bug 191313 - [PATCH] Mk/bsd.ruby.mk: fix staging error of normal user with 'USE_RUBY_EXTCONF=yes'
Summary: [PATCH] Mk/bsd.ruby.mk: fix staging error of normal user with 'USE_RUBY_EXTCO...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ruby (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-23 14:32 UTC by Yasuhiro Kimura
Modified: 2014-08-25 18:51 UTC (History)
0 users

See Also:

Attachments
Fix staging error of normal user with 'USE_RUBY_EXTCONF=yes' (463 bytes, patch)
2014-08-23 04:12 UTC, Yasuhiro Kimura 		no flags Details | Diff
noneedroot (1.87 KB, patch)
2014-08-25 18:44 UTC, Antoine Brodin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2014-06-23 14:32:15 UTC 
If 'USE_RUBY_EXTCONF=yes' is defined in Makefile of port, 'make stage' fails when it is executed by normal user.

Attached patch fixes it.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-06-25 02:43:56 UTC 
Over to maintainers.
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-08-23 04:12:35 UTC 
Created attachment 146168 [details]
Fix staging error of normal user with 'USE_RUBY_EXTCONF=yes'

Oops, I forgot to attach patch.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2014-08-25 17:26:06 UTC 
I have this patch,  I think you don't need to conditionalize on uid

Index: /usr/ports/Mk/bsd.ruby.mk
===================================================================
--- /usr/ports/Mk/bsd.ruby.mk   (revision 366094)
+++ /usr/ports/Mk/bsd.ruby.mk   (working copy)
@@ -522,6 +522,7 @@
 
 RUBY_EXTCONF?=         extconf.rb
 CONFIGURE_ARGS+=       --with-opt-dir="${LOCALBASE}"
+CONFIGURE_ENV+=                RB_USER_INSTALL=yes
 
 do-configure:  ruby-extconf-configure
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2014-08-25 18:44:19 UTC 
Created attachment 146261 [details]
noneedroot
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-08-25 18:49:43 UTC 
A commit references this bug:

Author: antoine
Date: Mon Aug 25 18:49:36 UTC 2014
New revision: 366129
URL: http://svnweb.freebsd.org/changeset/ports/366129

Log:
  Allow ports using ruby extconf to be built as non root

  PR:		ports/191313

Changes:
  head/Mk/bsd.ruby.mk
  head/databases/postgresql-plruby/Makefile
  head/databases/ruby-bdb/Makefile
  head/devel/libpafe-ruby/Makefile
  head/graphics/ruby-gd/Makefile