Bug 191422 - [patch] graphics/ufraw: hardcoded path to mkinstalldirs now is broken
Summary: [patch] graphics/ufraw: hardcoded path to mkinstalldirs now is broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-26 19:52 UTC by Dmitry Afanasiev
Modified: 2014-06-27 10:02 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Afanasiev 2014-06-26 19:52:51 UTC 
Hardcoded path to mkinstalldirs now is broken because devel/icu was updated to 53.1.

Please apply this patch:
Index: Makefile
===================================================================
--- Makefile    (revision 358905)
+++ Makefile    (working copy)
@@ -99,7 +99,7 @@
 .endfor
 
 pre-build:
-       @${INSTALL_SCRIPT} ${LOCALBASE}/share/icu/52.1/mkinstalldirs \
+       @${INSTALL_SCRIPT} ${LOCALBASE}/share/icu/53.1/mkinstalldirs \
                ${WRKSRC}
Comment 1 Rodrigo Osorio freebsd_committer freebsd_triage 2014-06-27 09:24:48 UTC 
I think this piece of code is part of the port history and is not required anymore. ufraw embed its own version of mkinstalldirs, so we must use it.

A new fix is on the run..
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-06-27 09:55:48 UTC 
A commit references this bug:

Author: rodrigo
Date: Fri Jun 27 09:55:31 UTC 2014
New revision: 359489
URL: http://svnweb.freebsd.org/changeset/ports/359489

Log:
  Don't copy mkinstalldirs from icu anymore since ufraw carry it's own version

  PR:		ports/191422
  Submitted by:	rodrigo (maintainer)
  Approved by:	bapt (mentor)

Changes:
  head/graphics/ufraw/Makefile
Comment 3 Rodrigo Osorio freebsd_committer freebsd_triage 2014-06-27 10:02:58 UTC 
Dmitry,

I finally chose a simplest and cleanest alternative
since ufraw builds perfectly with its own mkinstalldirs
script. Thanks for your report.

Regards,
- rodrigo