Bug 191521 - [maintainer][patch] Stage support for mail/courier-pythonfilter
Summary: [maintainer][patch] Stage support for mail/courier-pythonfilter
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Danilo Egea Gondolfo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-30 22:05 UTC by bsd
Modified: 2014-07-10 20:35 UTC (History)
2 users (show)

See Also:

Attachments
Port update to support staging (1.41 KB, patch)
2014-06-30 22:05 UTC, bsd 		no flags Details | Diff
New patch against current port (4.09 KB, patch)
2014-07-10 07:06 UTC, bsd 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description bsd 2014-06-30 22:05:09 UTC 
Created attachment 144301 [details]
Port update to support staging

Attempt to support staging on mail/courier-pythonfilter port
Comment 1 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-07-03 16:05:48 UTC 
I've got this error on 'make config':

===>  Returning to user credentials
cannot open /usr/local/libexec/filters/dialog4ports.sh: No such file or directory
===> Options unchanged

The problem is the SCRIPTSDIR variable overwriting.

To install the .sample file, you can use the new keyword @sample in the pkg-plist [1].

[1] - http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#plist-keywords

Can you check this, please?
Comment 2 bsd 2014-07-05 13:11:56 UTC 
(In reply to Danilo Egea Gondolfo from comment #1)
> I've got this error on 'make config':
> 
> ===>  Returning to user credentials
> cannot open /usr/local/libexec/filters/dialog4ports.sh: No such file or
> directory
> ===> Options unchanged
> 
> The problem is the SCRIPTSDIR variable overwriting.
> 

I tried change SCRIPTSDIR to PYSCRIPTSDIR and it works then. Used on line 23 and 60 of Makefile. Could you check it this way?
Comment 3 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-07-05 17:03:11 UTC 
Now I'm getting this error:
chown: /usr/ports/mail/courier-pythonfilter/work/stage/var/spool/courier/pythonfilter: Operation not permitted
*** Error code 1

With staging, all files should be installed as normal user. To set permissions use @owner and @group in pkg-plist (see the handbook). Furthermore, take a look at @sample to install the config file.
Comment 4 bsd 2014-07-10 07:06:30 UTC 
Created attachment 144549 [details]
New patch against current port
Comment 5 bsd 2014-07-10 07:10:09 UTC 
Comment on attachment 144549 [details]
New patch against current port

- package now builds as user
- @sample used for sample configuration files
- no check-plist errors reported
- post-install target converted into pkg-install script
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-07-10 20:34:14 UTC 
A commit references this bug:

Author: danilo
Date: Thu Jul 10 20:33:35 UTC 2014
New revision: 361489
URL: http://svnweb.freebsd.org/changeset/ports/361489

Log:
  - Add stage support
  - Use @sample
  while here
  - Use @owner and @group

  PR:		ports/191521
  Submitted by:	bsd@dino.sk

Changes:
  head/mail/courier-pythonfilter/Makefile
  head/mail/courier-pythonfilter/pkg-plist
Comment 7 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2014-07-10 20:35:40 UTC 
Committed, with small changes. Thanks!