Created attachment 144310 [details] patch to 0.0.10 Hi, I want to revive some old port. Here is a diff to rev 347792.
Seems the upstream version is 0.09 [1]: * Can you create an issue upstream to add a tag for that version. * Update patch to use USE_GITHUB and GH_* variables. DISTNAME, MASTER_SITES, GITVERSION, and WRKSRC overrides aren't required when using them. [1] https://github.com/openresty/lua-rds-parser/blob/master/Makefile#L1
And your forgot staging. Yep, I'll invest some time to fix this. Really soon (tm) :).
When you get the new version ready, reopen this bug report and attach it. Don't open a new PR!. I'm marking it "resolved" until then so it comes off the triage list. It's been evaluated so the state needs to change.
Triage Complete, Marking Open pending an Assignee Submitter has been requested to submit an updated patch
Oops, forgot to take this. Submitter, can you also include the relevant removal of the /usr/ports/MOVED entry in your diff too please
This bug isn't too old, is it? I can't even reeber where did I get version 0.0.10 from... It surely was there - somewhere on github or closer... but not anymore. So let it be 0.0.9. Updating patch. Redports build is at https://redports.org/buildarchive/20140715204100-28449/
Created attachment 144703 [details] lua-rds-parser.patch
Looking at the repository again, the latest tag is v0.0.5, who's Makefile contains only a reference to "version=0.09". A cursory search shows Ubuntu, Debian, and Gentoo all packaging 0.0.5. Please update your patch to suit (0.0.5), referencing the tag, not the commit in GH_TAGNAME While you're here: - Add LICENSE_FILE - Update MAINTAINER to yourself - Include MOVED changes in your patch See: [1] - Provide a proposed commit log detailing changes Finally, include portlint (-AC) output and attach a `port test`, poudriere testport or redports build log, with the latter two preferred. Great work! [1] http://www.freebsd.org/doc/en/books/porters-handbook/moved-and-updating-files.html
Pending updated patch and QA output
Submitter, please re-open this issue when you can provide the following: - Updated patch as per comment 8 - Change MAINTAINER to yourself
Created attachment 166869 [details] last version of patch Mostly fixed everything... Version changed again. - Add LICENSE_FILE: I added LICENSE as source has no specific file included. - `port test`: where to get that one? - poudriere/redports: redports down and poudriere is big. Would synth logs do? portlint -AC: WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. 0 fatal errors and 1 warning found. unfixed warning: pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:10:amd64" -- no architecture specific files found: **** could this package use a wildcard architecture? I also added binary stripping but I'm not sure whether I did that right...
Created attachment 184264 [details] Clean up a little. Update a patch a little.
New patch added.
Maintainer feedback?
Created attachment 193577 [details] full port As port is obsoleted long ago I'll attach shar instead. Also fixes plist issues.
Builds fine, committed, thanks. Please excuse the very long time to commit...
A commit references this bug: Author: pi Date: Thu May 24 18:49:19 UTC 2018 New revision: 470802 URL: https://svnweb.freebsd.org/changeset/ports/470802 Log: New (resurrected) port: devel/lua-rds-parser The lua-rds-parser can be used to parse the Resty-DBD-Stream formatted data generated by drizzle and/or postgres nginx modules into lua data structures. In the past, we have to use JSON as the intermediate data format which is quite inefficient in terms of both memory and CPU time. To maximize speed and minimize memory footprint, this library is implemented in pure C. WWW: https://github.com/agentzh/lua-rds-parser/ PR: 191526 Submitted by: arcade@b1t.name Changes: head/MOVED head/devel/Makefile head/devel/lua-rds-parser/ head/devel/lua-rds-parser/Makefile head/devel/lua-rds-parser/distinfo head/devel/lua-rds-parser/files/patch-Makefile