Bug 191531 - [new port] databases/lua-resty-redis
Summary: [new port] databases/lua-resty-redis
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-01 15:47 UTC by Volodymyr Kostyrko
Modified: 2017-11-16 20:03 UTC (History)
4 users (show)

See Also:

Attachments
new port source (2.63 KB, text/plain)
2014-07-01 15:47 UTC, Volodymyr Kostyrko 		no flags Details
Move to databases, rename to reflect github project page name (2.46 KB, text/plain)
2017-07-11 16:31 UTC, Volodymyr Kostyrko 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volodymyr Kostyrko 2014-07-01 15:47:11 UTC 
Created attachment 144318 [details]
new port source

I just created a port for lua-resty-redis - for accessing redis from nginx lua.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-01 22:53:06 UTC 
We prefer to add to devel/ only if there's not a more obvious alternative place to put it, databases/ sounds like a more intuitive primary category.

Please feel free to update the summy
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-01 22:59:02 UTC 
On first glance at your patch:

- Replace the custom DISTNAME, MASTER_SITES, GITVERSION and WRKSRC with the USE_GITHUB and the GH_* variables. 

For more detail, see /usr/ports/Mk/bsd.sites.mk

- Strip "This Lua library is a" from COMMENT

See: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-comment

- Bug summary says nginx-resty-redis, but the Makefile says lua-resty-redis, please clarify and update patch if necessary.

Finally, if you haven't already, run your port through portlint(8) port test (in ports-mgmt/porttools) and redports.org, fix any QA issues identified and report back here with URL's or output if they pass.

Thanks for your new port submission!
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-07 15:36:59 UTC 
No response in 5 weeks, port submission is not in an acceptable state so closing PR.
Comment 4 Volodymyr Kostyrko 2017-07-11 16:31:03 UTC 
Created attachment 184265 [details]
Move to databases, rename to reflect github project page name

New version, new variant...
Comment 5 Volodymyr Kostyrko 2017-07-11 16:31:22 UTC 
Added new patch.
Comment 6 Jochen Neumeister freebsd_committer freebsd_triage 2017-11-15 21:05:46 UTC 
Can you please check the new port again? If i test it in poudriere, all jails: stopped: crashed:
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-11-16 20:02:57 UTC 
A commit references this bug:

Author: joneum
Date: Thu Nov 16 20:02:09 UTC 2017
New revision: 454333
URL: https://svnweb.freebsd.org/changeset/ports/454333

Log:
  New Port: lua-resty-redis - for accessing redis from nginx lua

  This Lua library is a Redis client driver for the ngx_lua nginx module:

  http://wiki.nginx.org/HttpLuaModule

  This Lua library takes advantage of ngx_lua's cosocket API, which ensures 100%
  nonblocking behavior.

  WWW: https://github.com/openresty/lua-resty-redis

  PR:		191531
  Submitted by:	arcade@b1t.name (maintainer)
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D13121

Changes:
  head/databases/Makefile
  head/databases/lua-resty-redis/
  head/databases/lua-resty-redis/Makefile
  head/databases/lua-resty-redis/distinfo
  head/databases/lua-resty-redis/files/
  head/databases/lua-resty-redis/files/patch-Makefile
  head/databases/lua-resty-redis/pkg-descr
  head/databases/lua-resty-redis/pkg-plist
Comment 8 Jochen Neumeister freebsd_committer freebsd_triage 2017-11-16 20:03:20 UTC 
landed, thx