Bug 191643 - [ patch ] security/sks doesn't build on 9.1-R
Summary: [ patch ] security/sks doesn't build on 9.1-R
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-05 22:02 UTC by Dan Lukes
Modified: 2014-07-06 09:29 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Lukes 2014-07-05 22:02:42 UTC 
Port doesn't compile on FreeBSD 9.1
	It call 'patch -p 0' during the build phase. Unfortunately, it's not equivalent of 'patch -p0' and cause fail

How-To-Repeat:
Try it

Fix:
${WRKDIR}/Makefile needs to be patched to call 'patch -p0' instead of 'patch -p 0'

There are already two patches related to such file. The first one is
files/patch-Makefile
the second one is post-patch: ... @${REINPLACE_CMD}

Either add the attached patch to files/patch-Makefile or modify {REINPLACE_CMD} acordingly


--- Makefile.orig	2014-07-05 22:35:09.000000000 +0200
+++ Makefile	2014-07-05 22:59:21.000000000 +0200
@@ -283,8 +280,8 @@
 
 $(CKVER)/README.txt:
 	tar xmvfz $(CKVER).tar.gz
-	patch -p 0 < $(CKVER)-sks.patch
-	patch -p 0 < $(CKVER)-sks-custom_compare.patch
+	patch -p0 < $(CKVER)-sks.patch
+	patch -p0 < $(CKVER)-sks-custom_compare.patch
 
 $(CKDIR)/cryptokit.cma: $(CKVER)/README.txt
 	cd $(CKDIR) && $(MAKE) all
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-07-05 23:34:49 UTC 
Over to maintainer.
Comment 2 Johan van Selst freebsd_committer freebsd_triage 2014-07-06 09:28:54 UTC 
Committed, thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-07-06 09:29:16 UTC 
A commit references this bug:

Author: johans
Date: Sun Jul  6 09:28:30 UTC 2014
New revision: 360866
URL: http://svnweb.freebsd.org/changeset/ports/360866

Log:
  Fix build on FreeBSD 9 (and earlier)
  While here, merge another patch from files to makefile to avoid
  patching the same file from multiple locations

  PR:		 ports/191643
  Submitted by:	 Dan Lukes

Changes:
  head/security/sks/Makefile
  head/security/sks/files/patch-Makefile