Bug 191779 - games/einstein doesn't work since staging
Summary: games/einstein doesn't work since staging
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 12:09 UTC by Andrey Zholos
Modified: 2014-07-27 19:20 UTC (History)
3 users (show)

See Also:

Attachments
Fix (620 bytes, patch)
2014-07-10 12:10 UTC, Andrey Zholos 		edwin: maintainer-approval+
edwin: maintainer-approval+
Details | Diff
Alternative fix (825 bytes, patch)
2014-07-18 21:21 UTC, Andrey Zholos 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Zholos 2014-07-10 12:09:47 UTC 
The executable looks for its data file in the temporary staging directory and
not in the final installation directory.

This happens because in the program's Makefile, the PREFIX variable (set to
STAGEDIR+PREFIX) is both embedded in the executable and used as the install
target.

How to reproduce:

# make -C /usr/ports/games/einstein install
$ einstein
... works ...

# make -C /usr/ports/games/einstein clean
$ einstein
0x4a0004Resource 'cursor.bmp' not found


The attached patch changes the path that is embedded in the executable to just
the PREFIX without STAGEDIR. The install target still includes STAGEDIR.
Comment 1 Andrey Zholos 2014-07-10 12:10:48 UTC 
Created attachment 144552 [details]
Fix
Comment 2 Andrey Zholos 2014-07-18 21:21:11 UTC 
Created attachment 144786 [details]
Alternative fix

Discovered DESTDIR. It all makes sense now.
Alternative fix attached.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-07-27 19:20:35 UTC 
A commit references this bug:

Author: wg
Date: Sun Jul 27 19:20:07 UTC 2014
New revision: 363095
URL: http://svnweb.freebsd.org/changeset/ports/363095

Log:
  games/einstein: fix staging

  PR:		191779
  Submitted by:	Andrey Zholos
  Approved by:	maintainer (timeout)

Changes:
  head/games/einstein/files/patch-Makefile