Bug 191860 - [maintainer update] sysutils/backuppc: fix typos
Summary: [maintainer update] sysutils/backuppc: fix typos
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jonathan Chu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-14 11:15 UTC by Alexander Moisseev
Modified: 2014-07-15 05:29 UTC (History)
2 users (show)

See Also:


Attachments
patch (2.07 KB, patch)
2014-07-14 11:16 UTC, Alexander Moisseev
moiseev: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Moisseev 2014-07-14 11:15:10 UTC
- Fix typos
- Install BackupPC.html unconditionally

I consider the BackupPC.html is not optional, since it also used as documentation page in the CGI.
Comment 1 Alexander Moisseev 2014-07-14 11:16:27 UTC
Created attachment 144648 [details]
patch
Comment 2 Jonathan Chu freebsd_committer freebsd_triage 2014-07-14 16:23:28 UTC
I'll take this.

Submitted for review.
Comment 3 Jonathan Chu freebsd_committer freebsd_triage 2014-07-15 03:57:51 UTC
You've removed the DOCS option but the pod file is still using PORTDOCS. Do you intend to also unconditionally install the pod?
Comment 4 Alexander Moisseev 2014-07-15 05:07:27 UTC
(In reply to milki from comment #3)
> You've removed the DOCS option but the pod file is still using PORTDOCS. Do
> you intend to also unconditionally install the pod?

DOCS option is still in place, see line 39:
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=144648&action=diff#a/sysutils/backuppc/Makefile_sec2
I've just removed another one.

I am not sure about the pod. On the one hand it is primary documentation source, but on the other hand there is a man. I have decided to leave it optional by now. DOCS option is required any way, since it also affects files specified in PORTDOCS.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-07-15 05:15:43 UTC
A commit references this bug:

Author: milki
Date: Tue Jul 15 05:15:23 UTC 2014
New revision: 361864
URL: http://svnweb.freebsd.org/changeset/ports/361864

Log:
  Cleanup sysutils/backuppc pkg-plist

  - Main html doc should be unconditionally installed
  - Remove stopdaemon
  - Remove extra DOCS options

  PR:		191860
  Submitted by:	Alexander Moisseev <moiseev@mezonplus.ru> (maintainer)
  Approved by:	swills (mentor)

Changes:
  head/sysutils/backuppc/Makefile
  head/sysutils/backuppc/pkg-plist
Comment 6 Jonathan Chu freebsd_committer freebsd_triage 2014-07-15 05:16:38 UTC
Thanks! Committed.