Bug 191866 - [PATCH] textproc/docbook-xml: fix install using portmaster
Summary: [PATCH] textproc/docbook-xml: fix install using portmaster
Status: Closed Unable to Reproduce
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bartek Rutkowski
URL:
Keywords: easy, patch, patch-ready
: 191240 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-14 17:01 UTC by martin
Modified: 2015-03-05 14:01 UTC (History)
7 users (show)

See Also:


Attachments
Patch to change RUN_DEPENDS to BUILD_DEPENDS (542 bytes, patch)
2014-07-14 17:01 UTC, martin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description martin 2014-07-14 17:01:38 UTC
Created attachment 144661 [details]
Patch to change RUN_DEPENDS to BUILD_DEPENDS

Installing textproc/docbook using portmaster fails like this:

===> Fetching all distfiles required by docbook-xml-5.0_2 for building
===>  Extracting for docbook-xml-5.0_2
=> SHA256 Checksum OK for docbkx412.zip.
=> SHA256 Checksum OK for docbook-xml-4.2.zip.
=> SHA256 Checksum OK for docbook-xml-4.3.zip.
=> SHA256 Checksum OK for docbook-xml-4.4.zip.
=> SHA256 Checksum OK for docbook-xml-4.5.zip.
=> SHA256 Checksum OK for docbook-5.0.zip.
===>  Patching for docbook-xml-5.0_2
===>  Configuring for docbook-xml-5.0_2
===>  Staging for docbook-xml-5.0_2
echo "CATALOG \"/usr/local/share/xml/xmlcharent/catalog\""  > /usr/ports/textproc/docbook-xml/work/stage/usr/local/share/xml/docbook/catalog
/usr/local/bin/xmlcatmgr -c /usr/ports/textproc/docbook-xml/work/stage/usr/local/share/xml/docbook/catalog.xml create
make: exec(/usr/local/bin/xmlcatmgr) failed (No such file or directory)
*** Error code 1

The problem is that xmlcatmgr is a RUN_DEPENDS but it is needed at installation time.  I don't see any runtime dependency, so the attach patch builddep.patch changes it to a BUILD_DEPENDS.
Comment 1 martin 2014-07-15 09:37:11 UTC
Minor correction: I meant to say "installing textproc/docbook-xml".
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2014-07-15 16:32:51 UTC
*** Bug 191240 has been marked as a duplicate of this bug. ***
Comment 3 simon.tesar 2014-08-18 10:01:09 UTC
Also affected - installing textproc/xmlcatmgr before textproc/docbook-xml fixes install with portmaster.
Comment 4 f0andrey 2014-10-11 15:45:54 UTC
The problem is still relevant, a patch works fine
Comment 5 Bradley T. Hughes freebsd_committer freebsd_triage 2014-11-16 08:37:54 UTC
+1 on the patch. I hit this build error today while trying to install devel/git on a clean 10.1-RELEASE install.
Comment 6 Hiroki Sato freebsd_committer freebsd_triage 2014-12-08 07:21:25 UTC
I'll handle this.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2015-03-02 21:03:04 UTC
Maintainer timeout
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-03-02 21:03:23 UTC
Maintainer timeout, open up for anyone to take
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-03-03 13:55:29 UTC
A commit references this bug:

Author: robak
Date: Tue Mar  3 13:54:44 UTC 2015
New revision: 380367
URL: https://svnweb.freebsd.org/changeset/ports/380367

Log:
  textproc/docbook-xml: fix build

  - Change RUN_DEPENDS to BUILD_DEPENDS

  PR:		191866
  Submitted by:	Martin Simmons <martin@lispworks.com>
  MFH:		2015Q1

Changes:
  head/textproc/docbook-xml/Makefile
Comment 10 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-03 13:56:20 UTC
Committed, thanks for your work!
Comment 11 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-03 15:22:11 UTC
As antoine@ pointed out, this in fact wasnt a proper patch, and the commit was reverted back.
Comment 12 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-03 15:50:16 UTC
With the change reverted I've tested both devel/git and textproc/docbook and I cant reproduce the reported issues, so I am closing this PR as unable to reproduce.
Comment 13 martin 2015-03-03 16:57:46 UTC
For correctness, the change wasn't just reverted -- the RUN_DEPENDS was added back, but the new BUILD_DEPENDS remains.  I'm not sure why a port containing data files depends on anything at run time though...
Comment 14 Antoine Brodin freebsd_committer freebsd_triage 2015-03-03 17:22:07 UTC
I can't reproduce the failure when BUILD_DEPENDS are removed.

The RUN_DEPENDS are installed before staging occurs:

===>  Patching for docbook-xml-5.0_3
===>  Configuring for docbook-xml-5.0_3
===>  Staging for docbook-xml-5.0_3
===>   docbook-xml-5.0_3 depends on file: /usr/local/share/xml/xmlcharent/catalog.xml - not found
===>    Verifying install for /usr/local/share/xml/xmlcharent/catalog.xml in /usr/ports/textproc/xmlcharent
===>   xmlcharent-0.3_2 depends on file: /usr/local/sbin/pkg - found
=> xmlcharent-0.3.zip doesn't seem to exist in /portdistfiles/.
=> Attempting to fetch http://www.oasis-open.org/docbook/xmlcharent/0.3/xmlcharent-0.3.zip
...
Comment 15 Antoine Brodin freebsd_committer freebsd_triage 2015-03-03 17:25:04 UTC
Note that I don't use portmaster,  I just type "make" in textproc/docbook-xml
Comment 16 martin 2015-03-05 14:01:49 UTC
Sorry, my mistake -- the RUN_DEPENDS is needed because xmlcatmgr is used in the @exec and @unexec clauses of pkg-plist.  The BUILD_DEPENDS is needed for portmaster because that doesn't install the RUN_DEPENDS before staging.