Bug 191969 - update: mail/notmuch
Summary: update: mail/notmuch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-19 16:31 UTC by mp39590
Modified: 2014-08-09 22:10 UTC (History)
2 users (show)

See Also:


Attachments
patch (2.02 KB, patch)
2014-07-19 16:31 UTC, mp39590
no flags Details | Diff
failed poudriere log (19.79 KB, text/plain)
2014-08-09 21:37 UTC, John Marino
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description mp39590 2014-07-19 16:31:47 UTC
Created attachment 144797 [details]
patch

- update from 0.17 to 0.18.1
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-07 15:49:45 UTC
maintainer timed out so it's considered approved, anyone can commit this.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-09 21:35:06 UTC
This was untested.  I confirmed the previous version built cleanly in poudriere, so these errors are new:

====> Running Q/A tests (stage-qa)
Warning: 'bin/notmuch' is not stripped consider using ${STRIP_CMD}
Warning: 'lib/libnotmuch.so.3.1.0' is not stripped consider using ${STRIP_CMD}
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: man/man1/notmuch-compact.1.gz
Error: Missing: man/man1/notmuch-config.1.gz
Error: Missing: man/man1/notmuch-count.1.gz
Error: Missing: man/man1/notmuch-dump.1.gz
Error: Missing: man/man1/notmuch-insert.1.gz
Error: Missing: man/man1/notmuch-new.1.gz
Error: Missing: man/man1/notmuch-reply.1.gz
Error: Missing: man/man1/notmuch-restore.1.gz
Error: Missing: man/man1/notmuch-search.1.gz
Error: Missing: man/man1/notmuch-setup.1.gz
Error: Missing: man/man1/notmuch-show.1.gz
Error: Missing: man/man1/notmuch-tag.1.gz
Error: Missing: man/man1/notmuch.1.gz
Error: Missing: man/man5/notmuch-hooks.5.gz
Error: Missing: man/man7/notmuch-search-terms.7.gz
===> Error: Plist issues found.





I think at least python has been introduced as a dependency and that's not listed.  I'll upload the log in a minute.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-09 21:37:24 UTC
Created attachment 145583 [details]
failed poudriere log
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-09 21:42:49 UTC
it looks like documentation is now built with sphinx.

Also the STRIP warnings needs to be fixed with patches, should be easy enough.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-08-09 22:07:48 UTC
A commit references this bug:

Author: marino
Date: Sat Aug  9 22:07:21 UTC 2014
New revision: 364482
URL: http://svnweb.freebsd.org/changeset/ports/364482

Log:
  mail/notmuch: Update version 0.17 => 0.18.1

  PR:		191969
  Submitted by:	mp39590 (gmail.com)
  Approved by:	maintainer timeout
  QA fixes by:	marino

Changes:
  head/mail/notmuch/Makefile
  head/mail/notmuch/distinfo
  head/mail/notmuch/files/
  head/mail/notmuch/files/patch-Makefile.local
  head/mail/notmuch/files/patch-doc_Makefile.local
  head/mail/notmuch/files/patch-lib_Makefile.local
  head/mail/notmuch/pkg-plist
Comment 6 John Marino freebsd_committer freebsd_triage 2014-08-09 22:10:35 UTC
MP, In order to fix this, I had to add sphinx and python as build dependencies, and also patch 3 makefiles.

The stripping issues would have been caught by this procedure:
https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html

That procedure might not have caught sphinx/python if they were already install on the system for other reasons.

This is why poudriere testing is very important, this is real proof.  Please consider using it to test future patches, thanks.