Bug 191994 - [patch] last commit to mail/tkrat2 broke it
Summary: [patch] last commit to mail/tkrat2 broke it
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-20 21:58 UTC by Don Lewis
Modified: 2014-09-01 17:53 UTC (History)
4 users (show)

See Also:


Attachments
patch to update files/patch-tkrat_Makefile.in (1.40 KB, patch)
2014-07-20 21:58 UTC, Don Lewis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Lewis freebsd_committer freebsd_triage 2014-07-20 21:58:38 UTC
Created attachment 144826 [details]
patch to update files/patch-tkrat_Makefile.in

Commit r361322, which added STAGE support to mail/tkrat2 broke the port.  The mail client no longer starts after this change because the startup script now looks for things under /share instead of $PREFIX/share.

The attached patch fixes the port.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-11 14:22:54 UTC
Muhammad, you want to take a look?

If you fix it, consider resetting the port, we haven't heard from the maintainer in 3 years.

Actually, Don says the patch is ready to go so I'm moving it to patch-ready in any case (maintainer timeout)
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-31 10:00:22 UTC
This is an excellent example of what happens when PRs are assigned to non-FreeBSD people, especially when they are MIA for 3 years.

Removing maintainer from PR, it's long sinced timed-out.  it's already marked patch-ready.

The port maintainer should be reset too.
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-08-31 10:30:09 UTC
Hi John,
Seems like I missed your previous mail. I was going through the patch. So far it seems it's not patch-ready .. I repeat not patch-ready. There are STAGING problems and pkg-plist issues with this patch.

(In reply to John Marino from comment #2)
> This is an excellent example of what happens when PRs are assigned to
> non-FreeBSD people, especially when they are MIA for 3 years.
> 
> Removing maintainer from PR, it's long sinced timed-out.  it's already
> marked patch-ready.
> 
> The port maintainer should be reset too.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-31 10:35:42 UTC
(In reply to Muhammad Moinur Rahman from comment #3)
> Hi John,
> Seems like I missed your previous mail. I was going through the patch. So
> far it seems it's not patch-ready .. I repeat not patch-ready. There are
> STAGING problems and pkg-plist issues with this patch.


Don has a good track record, I didn't expect that. :)

Moving back to open.  And I'm removing "stage" from title, it messes up searches for unstaged ports.
Comment 5 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-08-31 10:37:16 UTC
Let me check it. It might be a problem with my poudriere too. Getting similar problems with other ports too. :(

(In reply to John Marino from comment #4)
> (In reply to Muhammad Moinur Rahman from comment #3)
> > Hi John,
> > Seems like I missed your previous mail. I was going through the patch. So
> > far it seems it's not patch-ready .. I repeat not patch-ready. There are
> > STAGING problems and pkg-plist issues with this patch.
> 
> 
> Don has a good track record, I didn't expect that. :)
> 
> Moving back to open.  And I'm removing "stage" from title, it messes up
> searches for unstaged ports.
Comment 6 Don Lewis freebsd_committer freebsd_triage 2014-08-31 19:00:26 UTC
I'm not seeing a problem here.

====> Compressing man pages (compress-man)
===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
====>> Checking for staging violations... done
=======================<phase: package        >============================
===>  Building package for tkrat-2.1.5_5
===========================================================================
=======================<phase: install-mtree  >============================
===========================================================================
=======================<phase: install        >============================
===>  Installing for tkrat-2.1.5_5
===>   tkrat-2.1.5_5 depends on file: /usr/local/libdata/pkgconfig/x11.pc - found
===>   tkrat-2.1.5_5 depends on file: /usr/local/libdata/pkgconfig/xt.pc - found
===>   tkrat-2.1.5_5 depends on shared library: libtcl84.so - found (/usr/local/lib/libtcl84.so.1)
===>   tkrat-2.1.5_5 depends on shared library: libtk84.so - found (/usr/local/lib/libtk84.so.1)
===>   tkrat-2.1.5_5 depends on shared library: libc-client4.so - found (/usr/local/lib/libc-client4.so.9)
===>  Checking if tkrat already installed
===>   Registering installation for tkrat-2.1.5_5
===========================================================================
====>> Checking shared library dependencies
	libc.so.7 => /lib/libc.so.7 (0x48091000)
	libcrypt.so.5 => /lib/libcrypt.so.5 (0x48564000)
	libcrypto.so.6 => /lib/libcrypto.so.6 (0x48408000)
	libssl.so.6 => /usr/lib/libssl.so.6 (0x481ad000)
=======================<phase: deinstall      >============================
===>  Deinstalling for tkrat
===>   Deinstalling tkrat-2.1.5_5
Updating database digests format... done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	tkrat-2.1.5_5

The operation will free 2 MB.
[ajail-default] [1/1] Deleting tkrat-2.1.5_5... done
===========================================================================
====>> Checking for extra files and directories
====>> Installing from package
[ajail-default] Installing tkrat-2.1.5_5... done
====>> Cleaning up
===>  Cleaning for tkrat-2.1.5_5
====>> Deinstalling package
Updating database digests format... done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	tkrat-2.1.5_5

The operation will free 2 MB.
[ajail-default] [1/1] Deleting tkrat-2.1.5_5... done
build of /usr/ports/mail/tkrat2 ended at Sun Aug 31 11:45:07 PDT 2014
build time: 00:00:59
====>> Cleaning up
====>> Umounting file systems
Comment 7 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-09-01 13:37:04 UTC
Yeap. It was caused by a degraded zpool. :(. Now everything is fine with my poudriere. :D
Poudriere logs:
http://pdr.s.ubze.ro/bulk/latest-per-pkg/tkrat/2.1.5_5/

(In reply to Don Lewis from comment #6)
> I'm not seeing a problem here.
> 
> ====> Compressing man pages (compress-man)
> ===========================================================================
> ====> Running Q/A tests (stage-qa)
> ====> Checking for pkg-plist issues (check-plist)
> ===> Parsing plist
> ===> Checking for items in STAGEDIR missing from pkg-plist
> ===> Checking for directories owned by MTREEs
> ===> Checking for directories handled by dependencies
> ===> Checking for items in pkg-plist which are not in STAGEDIR
> ===> No pkg-plist issues found (check-plist)
> ====>> Checking for staging violations... done
> =======================<phase: package        >============================
> ===>  Building package for tkrat-2.1.5_5
> ===========================================================================
> =======================<phase: install-mtree  >============================
> ===========================================================================
> =======================<phase: install        >============================
> ===>  Installing for tkrat-2.1.5_5
> ===>   tkrat-2.1.5_5 depends on file: /usr/local/libdata/pkgconfig/x11.pc -
> found
> ===>   tkrat-2.1.5_5 depends on file: /usr/local/libdata/pkgconfig/xt.pc -
> found
> ===>   tkrat-2.1.5_5 depends on shared library: libtcl84.so - found
> (/usr/local/lib/libtcl84.so.1)
> ===>   tkrat-2.1.5_5 depends on shared library: libtk84.so - found
> (/usr/local/lib/libtk84.so.1)
> ===>   tkrat-2.1.5_5 depends on shared library: libc-client4.so - found
> (/usr/local/lib/libc-client4.so.9)
> ===>  Checking if tkrat already installed
> ===>   Registering installation for tkrat-2.1.5_5
> ===========================================================================
> ====>> Checking shared library dependencies
> 	libc.so.7 => /lib/libc.so.7 (0x48091000)
> 	libcrypt.so.5 => /lib/libcrypt.so.5 (0x48564000)
> 	libcrypto.so.6 => /lib/libcrypto.so.6 (0x48408000)
> 	libssl.so.6 => /usr/lib/libssl.so.6 (0x481ad000)
> =======================<phase: deinstall      >============================
> ===>  Deinstalling for tkrat
> ===>   Deinstalling tkrat-2.1.5_5
> Updating database digests format... done
> Checking integrity... done (0 conflicting)
> Deinstallation has been requested for the following 1 packages (of 0
> packages in the universe):
> 
> Installed packages to be REMOVED:
> 	tkrat-2.1.5_5
> 
> The operation will free 2 MB.
> [ajail-default] [1/1] Deleting tkrat-2.1.5_5... done
> ===========================================================================
> ====>> Checking for extra files and directories
> ====>> Installing from package
> [ajail-default] Installing tkrat-2.1.5_5... done
> ====>> Cleaning up
> ===>  Cleaning for tkrat-2.1.5_5
> ====>> Deinstalling package
> Updating database digests format... done
> Checking integrity... done (0 conflicting)
> Deinstallation has been requested for the following 1 packages (of 0
> packages in the universe):
> 
> Installed packages to be REMOVED:
> 	tkrat-2.1.5_5
> 
> The operation will free 2 MB.
> [ajail-default] [1/1] Deleting tkrat-2.1.5_5... done
> build of /usr/ports/mail/tkrat2 ended at Sun Aug 31 11:45:07 PDT 2014
> build time: 00:00:59
> ====>> Cleaning up
> ====>> Umounting file systems
Comment 8 John Marino freebsd_committer freebsd_triage 2014-09-01 13:39:00 UTC
restore this to "patch-ready" status.
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-09-01 17:53:12 UTC
A commit references this bug:

Author: pi
Date: Mon Sep  1 17:52:27 UTC 2014
New revision: 366912
URL: http://svnweb.freebsd.org/changeset/ports/366912

Log:
  mail/tkrat2: fix start of mail client, reset maintainer as requested by marino

  PR:		191994
  Submitted by:	Don Lewis <truckman@FreeBSD.org>
  Approved by:	maintainer (timeout)

Changes:
  head/mail/tkrat2/Makefile
  head/mail/tkrat2/files/patch-tkrat_Makefile.in
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2014-09-01 17:53:51 UTC
Committed, thanks.